You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2023/01/04 14:27:07 UTC

[GitHub] [zookeeper] eolivelli commented on pull request #1947: ZOOKEEPER-4656: Allow ZooKeeperAdmin creation with custom HostProvider

eolivelli commented on PR #1947:
URL: https://github.com/apache/zookeeper/pull/1947#issuecomment-1370997242

   I would prefer to not commit the new constructor and then remove it.
   There is no hurry in committing a patch, and sometimes if someone adds a new API it may stay there forever if we forget about it.
   So overall I believe that it is better to add the builder and do not add a new public constructor..
   
   For the test, we can a very simple test that bootstraps an instance using the new builder.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org