You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/03/21 16:48:10 UTC

[GitHub] [camel] davsclaus opened a new pull request #7243: Summary

davsclaus opened a new pull request #7243:
URL: https://github.com/apache/camel/pull/7243


   <!-- Uncomment and fill this section if your PR is not trivial
   - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
   - [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   Below are the contribution guidelines:
   https://github.com/apache/camel/blob/main/CONTRIBUTING.md
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #7243: Summary

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #7243:
URL: https://github.com/apache/camel/pull/7243#issuecomment-1074145650


   <img width="2148" alt="Screenshot 2022-03-21 at 17 48 18" src="https://user-images.githubusercontent.com/477100/159312772-1b54700a-85ad-4847-b4ba-9de06907939f.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] essobedo commented on a change in pull request #7243: Summary

Posted by GitBox <gi...@apache.org>.
essobedo commented on a change in pull request #7243:
URL: https://github.com/apache/camel/pull/7243#discussion_r832048856



##########
File path: core/camel-api/src/main/java/org/apache/camel/spi/PropertiesComponent.java
##########
@@ -116,6 +117,25 @@
      */
     Properties loadProperties(Predicate<String> filter);
 
+    /**
+     * Loads the properties from the default locations and sources filtering them out according to a predicate, and maps
+     * the key using the key mapper.
+     * </p>
+     *
+     * <pre>
+     * {
+     *     &#64;code
+     *     PropertiesComponent pc = getPropertiesComponent();
+     *     Properties props = pc.loadProperties(key -> key.startsWith("camel.component.seda"), StringHelper.dashToCamelCase);
+     * }

Review comment:
       ```suggestion
        *  <code>
        *     PropertiesComponent pc = getPropertiesComponent();
        *     Properties props = pc.loadProperties(key -> key.startsWith("camel.component.seda"), StringHelper.dashToCamelCase);
        * </code>
   ```
   The formatter broke the Javadoc




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orpiske commented on pull request #7243: Summary

Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #7243:
URL: https://github.com/apache/camel/pull/7243#issuecomment-1075023053


   This looks nice!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus edited a comment on pull request #7243: Summary

Posted by GitBox <gi...@apache.org>.
davsclaus edited a comment on pull request #7243:
URL: https://github.com/apache/camel/pull/7243#issuecomment-1074145650


   jbang run   -Dcamel.jbang.version=3.16.0-SNAPSHOT -Dcamel.main.name=Killroy camel@apache/camel run chuck-out.yaml myapp.properties
   
   <img width="2148" alt="Screenshot 2022-03-21 at 17 48 18" src="https://user-images.githubusercontent.com/477100/159312772-1b54700a-85ad-4847-b4ba-9de06907939f.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #7243: Summary

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #7243:
URL: https://github.com/apache/camel/pull/7243#issuecomment-1074151194


   You can now see from where all these configured options is coming from, as this can be "hard to guess" when you have many ways to configure this with ENV/SYS/properties/yaml/code and whatnot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #7243: Summary

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #7243:
URL: https://github.com/apache/camel/pull/7243#issuecomment-1075035801


   The order may seem random, but its the order they are configured .. if we sort them a..z then we may loose a little bit of detail that can help the end user to trouble shoot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus merged pull request #7243: Summary

Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #7243:
URL: https://github.com/apache/camel/pull/7243


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org