You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/05 16:44:56 UTC

[GitHub] [kafka] rhauch opened a new pull request #8814: KAFKA-10111: Make SinkTaskContext.errantRecordReporter() a default method

rhauch opened a new pull request #8814:
URL: https://github.com/apache/kafka/pull/8814


   Connector projects may have their own mock or testing implementations of the `SinkTaskContext`, and this newly-added method should be a default method to prevent breaking those projects. Changing this to a default method that returns null also makes sense w/r/t the method semantics, since the method is already defined to return null if the reporter has not been configured.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] rhauch merged pull request #8814: KAFKA-10111: Make SinkTaskContext.errantRecordReporter() a default method

Posted by GitBox <gi...@apache.org>.
rhauch merged pull request #8814:
URL: https://github.com/apache/kafka/pull/8814


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org