You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "rhuan080 (via GitHub)" <gi...@apache.org> on 2023/05/07 03:32:47 UTC
[GitHub] [camel] rhuan080 opened a new pull request, #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
rhuan080 opened a new pull request, #10009:
URL: https://github.com/apache/camel/pull/10009
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I formatted the code using `mvn -Pformat,fastinstall install && mvn -Psourcecheck`
<!--
You can run the aforementioned command in your module so that the build auto-formats your code and the source check verifies that is complies with our coding style. This will also be verified as part of the checks and your PR may be rejected if the checkstyle does not pass.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] simon-ras commented on pull request #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
Posted by "simon-ras (via GitHub)" <gi...@apache.org>.
simon-ras commented on PR #10009:
URL: https://github.com/apache/camel/pull/10009#issuecomment-1540775803
The proposed PR does not work for injected clients. I would suggest reverting the previous "fix" instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] rhuan080 commented on pull request #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
Posted by "rhuan080 (via GitHub)" <gi...@apache.org>.
rhuan080 commented on PR #10009:
URL: https://github.com/apache/camel/pull/10009#issuecomment-1540785957
Thus, I will revert the connections and apply a fix just to KinesisClient, as it has an real scenario of connection leak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] rhuan080 commented on pull request #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
Posted by "rhuan080 (via GitHub)" <gi...@apache.org>.
rhuan080 commented on PR #10009:
URL: https://github.com/apache/camel/pull/10009#issuecomment-1538355910
I'll create a separated client for the health checker and reuse it. I'll send a commit to change it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #10009:
URL: https://github.com/apache/camel/pull/10009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10009:
URL: https://github.com/apache/camel/pull/10009#issuecomment-1537859681
I would assume for health-checks we should reuse the existing client, and NOT close it when check is done.
Creating a new client is "expensive" as you then setup a new connection to the cloud.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] simon-ras commented on pull request #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
Posted by "simon-ras (via GitHub)" <gi...@apache.org>.
simon-ras commented on PR #10009:
URL: https://github.com/apache/camel/pull/10009#issuecomment-1540750217
The reporter of https://issues.apache.org/jira/browse/CAMEL-19281 claimed that they saw a connection leak from the original implementation. Would it be possible to maybe verify this before making further changes?
We manage our aws clients as Spring beans and our client shouldn't not be shut down before the spring context is destroyed. We are heavily using the SNS and SQS camel components across many services and have not seen any connection leaks on version 3.20.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10009:
URL: https://github.com/apache/camel/pull/10009#issuecomment-1538587823
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 17 | 17 | 17 | 0 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10009:
URL: https://github.com/apache/camel/pull/10009#issuecomment-1547333431
Is this PR ready to be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] rhuan080 commented on pull request #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
Posted by "rhuan080 (via GitHub)" <gi...@apache.org>.
rhuan080 commented on PR #10009:
URL: https://github.com/apache/camel/pull/10009#issuecomment-1540767271
Hi @simon-ras,
I have reviewed the changes applied on https://issues.apache.org/jira/browse/CAMEL-19281 and I have seen a potential connection leak to KinesisClient only. I agree the client should not be shut down. However, this fix will solve the problem of closing connections. I think after applying this fix we can back to https://issues.apache.org/jira/browse/CAMEL-19281 and ask to the customer for a reproducer and further information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] simon-ras commented on pull request #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
Posted by "simon-ras (via GitHub)" <gi...@apache.org>.
simon-ras commented on PR #10009:
URL: https://github.com/apache/camel/pull/10009#issuecomment-1549223677
This PR also need to be backported into 3.20.x as all AWS components are broken on that branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10009:
URL: https://github.com/apache/camel/pull/10009#issuecomment-1537279632
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] rhuan080 commented on pull request #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
Posted by "rhuan080 (via GitHub)" <gi...@apache.org>.
rhuan080 commented on PR #10009:
URL: https://github.com/apache/camel/pull/10009#issuecomment-1540769975
Now, after reviewing the https://issues.apache.org/jira/browse/CAMEL-19281, I'm not sure the KinesisClient is used by the reporter, then I'm not sure the issue is generated by the health checker. However, I think we can apply this fix to solve the close connection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10009:
URL: https://github.com/apache/camel/pull/10009#issuecomment-1537288635
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 16 | 16 | 0 | 16 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10009:
URL: https://github.com/apache/camel/pull/10009#issuecomment-1540917457
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 19 | 19 | 0 | 19 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] rhuan080 commented on pull request #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
Posted by "rhuan080 (via GitHub)" <gi...@apache.org>.
rhuan080 commented on PR #10009:
URL: https://github.com/apache/camel/pull/10009#issuecomment-1548630242
Hi, @davsclaus
Yes, we can merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] simon-ras commented on pull request #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
Posted by "simon-ras (via GitHub)" <gi...@apache.org>.
simon-ras commented on PR #10009:
URL: https://github.com/apache/camel/pull/10009#issuecomment-1549225987
> This PR also need to be backported into 3.20.x as all AWS components are broken on that branch.
I just realized that this was already done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10009:
URL: https://github.com/apache/camel/pull/10009#issuecomment-1540868149
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 19 | 19 | 17 | 2 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10009:
URL: https://github.com/apache/camel/pull/10009#issuecomment-1538647425
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 17 | 17 | 0 | 17 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10009:
URL: https://github.com/apache/camel/pull/10009#issuecomment-1537297329
Does this create a new client for each health check call?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10009: CAMEL-19314 - Fixing the connection pool shutdown when aws health checks are used
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10009:
URL: https://github.com/apache/camel/pull/10009#issuecomment-1537287669
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 16 | 16 | 3 | 14 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org