You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/05 06:25:02 UTC
[GitHub] [dolphinscheduler] Abingcbc opened a new pull request #8706: [Feature][Login] Add SSO login by Casdoor
Abingcbc opened a new pull request #8706:
URL: https://github.com/apache/dolphinscheduler/pull/8706
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
Add SSO login for Dolphinscheduler
This pull request will close
https://github.com/apache/dolphinscheduler/issues/4531
https://github.com/apache/dolphinscheduler/issues/3451
## Brief change log
https://user-images.githubusercontent.com/34068205/156871076-8d746d80-d335-41d4-a843-1ac5a3fed244.mp4
## Verify this pull request
This change added tests and can be verified as follows:
- Added CasdoorAuthenticator test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Abingcbc commented on pull request #8706: [Feature][Login] Add SSO login by Casdoor
Posted by GitBox <gi...@apache.org>.
Abingcbc commented on pull request #8706:
URL: https://github.com/apache/dolphinscheduler/pull/8706#issuecomment-1064206255
@CalvinKirs @ruanwenjun I have fixed the CI error. Please approve to rerun :) Thanks❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #8706: [Feature][Login] Add SSO login by Casdoor
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #8706:
URL: https://github.com/apache/dolphinscheduler/pull/8706#issuecomment-1068888672
@Abingcbc Thanks, right now we put the front-end code in [dolphinscheduler-ui-next](https://github.com/apache/dolphinscheduler/tree/dev/dolphinscheduler-ui-next), and we will not maintain the [dolphinscheduler-ui](https://github.com/apache/dolphinscheduler/tree/dev/dolphinscheduler-ui), could you please put your change in dolphinscheduler-ui-next.
And you may also need to add the document about this new feature in [dolphinscheduler-website](https://github.com/apache/dolphinscheduler-website).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] hsluoyz commented on pull request #8706: [Feature][Login] Add SSO login by Casdoor
Posted by GitBox <gi...@apache.org>.
hsluoyz commented on pull request #8706:
URL: https://github.com/apache/dolphinscheduler/pull/8706#issuecomment-1060395275
Hi @William-GuoWei @dailidong @break60 , I am Yang Luo from Casdoor team. Casdoor is a powerful open-source single-sign-on (SSO) platform. It has the following features:
1. Support OIDC, OAuth 2.0, SAML, LDAP
2. With [Casbin](https://casbin.org/) based authorization management, Casdoor supports ACL, RBAC, ABAC, RESTful accessing control models
3. Front-end and back-end separate architecture, Casdoor supports high concurrency, provides web-based managing UI and have mature solution for springboot project https://casdoor.org/docs/integration/spring-boot
4. Casdoor supports Github, Google, QQ, WeChat third-party applications login, and support the extension of third-party login with plugins.
5. Phone verification code, email verification code and forget password features.
6. Accessing logs auditing and recording.
7. Casdoor supports integration with existing systems using db sync method, users can transition to Casdoor smoothly.
8. Casdoor supports mainstream databases: MySQL, PostgreSQL, SQL Server etc, and support the extension of new database with plugins.
There have been a lot of user requests about the SSO scenario. This integration proposal will greatly enhance the SSO feature of DolphinScheduler with better authentication and security protection. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] CalvinKirs commented on a change in pull request #8706: [Feature][Login] Add SSO login by Casdoor
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #8706:
URL: https://github.com/apache/dolphinscheduler/pull/8706#discussion_r825876104
##########
File path: tools/dependencies/known-dependencies.txt
##########
@@ -270,4 +270,12 @@ okhttp-3.14.9.jar
okio-1.17.2.jar
jmespath-java-1.12.160.jar
jackson-dataformat-cbor-2.12.5.jar
-ion-java-1.0.2.jar
\ No newline at end of file
+ion-java-1.0.2.jar
+casdoor-java-sdk-1.5.1.jar
+casdoor-spring-boot-starter-1.2.0.jar
+jcip-annotations-1.0-1.jar
+json-20140107.jar
+lombok-1.18.22.jar
+nimbus-jose-jwt-9.10.1.jar
+org.apache.oltu.oauth2.client-1.0.2.jar
+org.apache.oltu.oauth2.common-1.0.2.jar
Review comment:
you can refer this https://dolphinscheduler.apache.org/en-us/community/development/DS-License.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #8706: [Feature][Login] Add SSO login by Casdoor
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #8706:
URL: https://github.com/apache/dolphinscheduler/pull/8706#issuecomment-1065125856
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/8706?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8706](https://codecov.io/gh/apache/dolphinscheduler/pull/8706?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe2884b) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/aa5392529bb8d2ba7b4b73a9527adf713f8884c8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa53925) will **increase** coverage by `0.00%`.
> The diff coverage is `72.22%`.
[](https://codecov.io/gh/apache/dolphinscheduler/pull/8706?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## dev #8706 +/- ##
=========================================
Coverage 45.32% 45.33%
- Complexity 4078 4082 +4
=========================================
Files 702 704 +2
Lines 27112 27129 +17
Branches 2897 2899 +2
=========================================
+ Hits 12289 12298 +9
- Misses 13667 13678 +11
+ Partials 1156 1153 -3
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/8706?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nscheduler/api/configuration/AppConfiguration.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbmZpZ3VyYXRpb24vQXBwQ29uZmlndXJhdGlvbi5qYXZh) | `94.11% <ø> (ø)` | |
| [...lphinscheduler/api/controller/LoginController.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvTG9naW5Db250cm9sbGVyLmphdmE=) | `60.00% <0.00%> (-8.19%)` | :arrow_down: |
| [...inscheduler/api/service/impl/UsersServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9Vc2Vyc1NlcnZpY2VJbXBsLmphdmE=) | `74.89% <ø> (+0.20%)` | :arrow_up: |
| [...er/api/security/impl/sso/CasdoorAuthenticator.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L2ltcGwvc3NvL0Nhc2Rvb3JBdXRoZW50aWNhdG9yLmphdmE=) | `80.00% <80.00%> (ø)` | |
| [.../org/apache/dolphinscheduler/api/enums/Status.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2VudW1zL1N0YXR1cy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...phinscheduler/api/security/AuthenticationType.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L0F1dGhlbnRpY2F0aW9uVHlwZS5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../dolphinscheduler/api/security/SecurityConfig.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1NlY3VyaXR5Q29uZmlnLmphdmE=) | `71.42% <100.00%> (+3.00%)` | :arrow_up: |
| [...er/api/security/impl/AbstractSsoAuthenticator.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L2ltcGwvQWJzdHJhY3RTc29BdXRoZW50aWNhdG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...he/dolphinscheduler/common/enums/SqoopJobType.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1Nxb29wSm9iVHlwZS5qYXZh) | `0.00% <0.00%> (-88.89%)` | :arrow_down: |
| [...inscheduler/common/task/sqoop/SqoopParameters.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3AvU3Fvb3BQYXJhbWV0ZXJzLmphdmE=) | `74.00% <0.00%> (-2.00%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/8706?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/8706?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aa53925...fe2884b](https://codecov.io/gh/apache/dolphinscheduler/pull/8706?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] removed a comment on pull request #8706: [Feature][Login] Add SSO login by Casdoor
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #8706:
URL: https://github.com/apache/dolphinscheduler/pull/8706#issuecomment-1065132815
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8706&metric=new_coverage&view=list) [70.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8706&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8706&metric=new_duplicated_lines_density&view=list) [0.8% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8706&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] CalvinKirs commented on a change in pull request #8706: [Feature][Login] Add SSO login by Casdoor
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #8706:
URL: https://github.com/apache/dolphinscheduler/pull/8706#discussion_r820533471
##########
File path: dolphinscheduler-api/pom.xml
##########
@@ -245,6 +245,12 @@
</exclusions>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>org.casbin</groupId>
+ <artifactId>casdoor-spring-boot-starter</artifactId>
+ <version>1.2.0</version>
+ </dependency>
Review comment:
Version dependencies should be managed uniformly in the root pom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on a change in pull request #8706: [Feature][Login] Add SSO login by Casdoor
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #8706:
URL: https://github.com/apache/dolphinscheduler/pull/8706#discussion_r821604227
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/SecurityConfig.java
##########
@@ -66,6 +67,9 @@ public Authenticator authenticator() {
case LDAP:
authenticator = new LdapAuthenticator();
break;
+ case SSO:
Review comment:
```suggestion
case CASDOOR_SSO:
```
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/AuthenticationType.java
##########
@@ -26,6 +26,7 @@
PASSWORD(0, "verify via user name and password"),
LDAP(1, "verify via LDAP server"),
+ SSO(1, "verify via sso provider")
Review comment:
```suggestion
CASDOOR_SSO(2, "verify via casdoor sso provider")
```
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/impl/sso/CasdoorAuthenticator.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.api.security.impl.sso;
+
+import org.apache.dolphinscheduler.api.security.impl.AbstractSsoAuthenticator;
+import org.apache.dolphinscheduler.api.service.UsersService;
+import org.apache.dolphinscheduler.common.enums.UserType;
+import org.apache.dolphinscheduler.dao.entity.User;
+import org.casbin.casdoor.entity.CasdoorUser;
+import org.casbin.casdoor.service.CasdoorAuthService;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.beans.factory.annotation.Value;
+
+
+public class CasdoorAuthenticator extends AbstractSsoAuthenticator {
+
+ @Autowired
+ private UsersService usersService;
+ @Autowired
+ private CasdoorAuthService casdoorAuthService;
+ @Value("${casdoor.redirect-url}")
+ private String redirectUrl;
Review comment:
Can these fields be injected? I am not sure, it seems you just use constructor to create `CasdoorAuthenticator`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Abingcbc commented on a change in pull request #8706: [Feature][Login] Add SSO login by Casdoor
Posted by GitBox <gi...@apache.org>.
Abingcbc commented on a change in pull request #8706:
URL: https://github.com/apache/dolphinscheduler/pull/8706#discussion_r823371544
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/impl/sso/CasdoorAuthenticator.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.api.security.impl.sso;
+
+import org.apache.dolphinscheduler.api.security.impl.AbstractSsoAuthenticator;
+import org.apache.dolphinscheduler.api.service.UsersService;
+import org.apache.dolphinscheduler.common.enums.UserType;
+import org.apache.dolphinscheduler.dao.entity.User;
+import org.casbin.casdoor.entity.CasdoorUser;
+import org.casbin.casdoor.service.CasdoorAuthService;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.beans.factory.annotation.Value;
+
+
+public class CasdoorAuthenticator extends AbstractSsoAuthenticator {
+
+ @Autowired
+ private UsersService usersService;
+ @Autowired
+ private CasdoorAuthService casdoorAuthService;
+ @Value("${casdoor.redirect-url}")
+ private String redirectUrl;
Review comment:
Yes, it is the same as the existing `LdapAuthenticator` https://github.com/apache/dolphinscheduler/blob/dev/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/impl/ldap/LdapAuthenticator.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on a change in pull request #8706: [Feature][Login] Add SSO login by Casdoor
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #8706:
URL: https://github.com/apache/dolphinscheduler/pull/8706#discussion_r823427377
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/impl/sso/CasdoorAuthenticator.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.api.security.impl.sso;
+
+import org.apache.dolphinscheduler.api.security.impl.AbstractSsoAuthenticator;
+import org.apache.dolphinscheduler.api.service.UsersService;
+import org.apache.dolphinscheduler.common.enums.UserType;
+import org.apache.dolphinscheduler.dao.entity.User;
+import org.casbin.casdoor.entity.CasdoorUser;
+import org.casbin.casdoor.service.CasdoorAuthService;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.beans.factory.annotation.Value;
+
+
+public class CasdoorAuthenticator extends AbstractSsoAuthenticator {
+
+ @Autowired
+ private UsersService usersService;
+ @Autowired
+ private CasdoorAuthService casdoorAuthService;
+ @Value("${casdoor.redirect-url}")
+ private String redirectUrl;
Review comment:
OK, it seems using `@Bean` can still inject these fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter edited a comment on pull request #8706: [Feature][Login] Add SSO login by Casdoor
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8706:
URL: https://github.com/apache/dolphinscheduler/pull/8706#issuecomment-1065125856
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/8706?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8706](https://codecov.io/gh/apache/dolphinscheduler/pull/8706?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (558b996) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/60fbbcb790bb30d204c49b7cf3ee0bc6fb5ed707?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (60fbbcb) will **decrease** coverage by `0.01%`.
> The diff coverage is `72.22%`.
```diff
@@ Coverage Diff @@
## dev #8706 +/- ##
============================================
- Coverage 39.78% 39.77% -0.02%
- Complexity 4264 4267 +3
============================================
Files 808 810 +2
Lines 32547 32566 +19
Branches 3647 3651 +4
============================================
+ Hits 12950 12954 +4
- Misses 18373 18382 +9
- Partials 1224 1230 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/8706?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nscheduler/api/configuration/AppConfiguration.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbmZpZ3VyYXRpb24vQXBwQ29uZmlndXJhdGlvbi5qYXZh) | `94.11% <ø> (ø)` | |
| [...lphinscheduler/api/controller/LoginController.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvTG9naW5Db250cm9sbGVyLmphdmE=) | `60.00% <0.00%> (-8.19%)` | :arrow_down: |
| [...inscheduler/api/service/impl/UsersServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9Vc2Vyc1NlcnZpY2VJbXBsLmphdmE=) | `74.79% <ø> (ø)` | |
| [...er/api/security/impl/sso/CasdoorAuthenticator.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L2ltcGwvc3NvL0Nhc2Rvb3JBdXRoZW50aWNhdG9yLmphdmE=) | `80.00% <80.00%> (ø)` | |
| [.../org/apache/dolphinscheduler/api/enums/Status.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2VudW1zL1N0YXR1cy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...phinscheduler/api/security/AuthenticationType.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L0F1dGhlbnRpY2F0aW9uVHlwZS5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../dolphinscheduler/api/security/SecurityConfig.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1NlY3VyaXR5Q29uZmlnLmphdmE=) | `71.42% <100.00%> (+3.00%)` | :arrow_up: |
| [...er/api/security/impl/AbstractSsoAuthenticator.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L2ltcGwvQWJzdHJhY3RTc29BdXRoZW50aWNhdG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `77.77% <0.00%> (-5.56%)` | :arrow_down: |
| [...inscheduler/server/log/LoggerRequestProcessor.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1sb2ctc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZlci9sb2cvTG9nZ2VyUmVxdWVzdFByb2Nlc3Nvci5qYXZh) | `21.95% <0.00%> (-3.37%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/dolphinscheduler/pull/8706/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/8706?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/8706?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [60fbbcb...558b996](https://codecov.io/gh/apache/dolphinscheduler/pull/8706?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on a change in pull request #8706: [Feature][Login] Add SSO login by Casdoor
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #8706:
URL: https://github.com/apache/dolphinscheduler/pull/8706#discussion_r825436955
##########
File path: tools/dependencies/known-dependencies.txt
##########
@@ -270,4 +270,12 @@ okhttp-3.14.9.jar
okio-1.17.2.jar
jmespath-java-1.12.160.jar
jackson-dataformat-cbor-2.12.5.jar
-ion-java-1.0.2.jar
\ No newline at end of file
+ion-java-1.0.2.jar
+casdoor-java-sdk-1.5.1.jar
+casdoor-spring-boot-starter-1.2.0.jar
+jcip-annotations-1.0-1.jar
+json-20140107.jar
+lombok-1.18.22.jar
+nimbus-jose-jwt-9.10.1.jar
+org.apache.oltu.oauth2.client-1.0.2.jar
+org.apache.oltu.oauth2.common-1.0.2.jar
Review comment:
The `lombok` is not belong to `apache 2.0`, so we need to add license in `dolphinscheduler-dist` and the other dependencies belong to `apache 2.0` we still need to announce in NOTICE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Abingcbc commented on a change in pull request #8706: [Feature][Login] Add SSO login by Casdoor
Posted by GitBox <gi...@apache.org>.
Abingcbc commented on a change in pull request #8706:
URL: https://github.com/apache/dolphinscheduler/pull/8706#discussion_r825959632
##########
File path: tools/dependencies/known-dependencies.txt
##########
@@ -270,4 +270,12 @@ okhttp-3.14.9.jar
okio-1.17.2.jar
jmespath-java-1.12.160.jar
jackson-dataformat-cbor-2.12.5.jar
-ion-java-1.0.2.jar
\ No newline at end of file
+ion-java-1.0.2.jar
+casdoor-java-sdk-1.5.1.jar
+casdoor-spring-boot-starter-1.2.0.jar
+jcip-annotations-1.0-1.jar
+json-20140107.jar
+lombok-1.18.22.jar
+nimbus-jose-jwt-9.10.1.jar
+org.apache.oltu.oauth2.client-1.0.2.jar
+org.apache.oltu.oauth2.common-1.0.2.jar
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Abingcbc commented on a change in pull request #8706: [Feature][Login] Add SSO login by Casdoor
Posted by GitBox <gi...@apache.org>.
Abingcbc commented on a change in pull request #8706:
URL: https://github.com/apache/dolphinscheduler/pull/8706#discussion_r820597703
##########
File path: dolphinscheduler-api/pom.xml
##########
@@ -245,6 +245,12 @@
</exclusions>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>org.casbin</groupId>
+ <artifactId>casdoor-spring-boot-starter</artifactId>
+ <version>1.2.0</version>
+ </dependency>
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #8706: [Feature][Login] Add SSO login by Casdoor
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #8706:
URL: https://github.com/apache/dolphinscheduler/pull/8706#issuecomment-1065132815
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8706&metric=new_coverage&view=list) [70.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8706&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8706&metric=new_duplicated_lines_density&view=list) [0.8% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8706&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Abingcbc commented on a change in pull request #8706: [Feature][Login] Add SSO login by Casdoor
Posted by GitBox <gi...@apache.org>.
Abingcbc commented on a change in pull request #8706:
URL: https://github.com/apache/dolphinscheduler/pull/8706#discussion_r825851369
##########
File path: tools/dependencies/known-dependencies.txt
##########
@@ -270,4 +270,12 @@ okhttp-3.14.9.jar
okio-1.17.2.jar
jmespath-java-1.12.160.jar
jackson-dataformat-cbor-2.12.5.jar
-ion-java-1.0.2.jar
\ No newline at end of file
+ion-java-1.0.2.jar
+casdoor-java-sdk-1.5.1.jar
+casdoor-spring-boot-starter-1.2.0.jar
+jcip-annotations-1.0-1.jar
+json-20140107.jar
+lombok-1.18.22.jar
+nimbus-jose-jwt-9.10.1.jar
+org.apache.oltu.oauth2.client-1.0.2.jar
+org.apache.oltu.oauth2.common-1.0.2.jar
Review comment:
@ruanwenjun Do we also need to add licenses of dependencies which belong to `apache 2.0` into `dolphinscheduler-dist`? Because I found a lot of `apache 2.0` licenses in `dolphinscheduler-dist`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #8706: [Feature][Login] Add SSO login by Casdoor
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #8706:
URL: https://github.com/apache/dolphinscheduler/pull/8706#issuecomment-1068715573
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8706&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8706&metric=new_coverage&view=list) [70.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8706&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8706&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8706&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org