You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org> on 2023/12/24 10:26:40 UTC

[PR] [opt](assert_num_rows) support filter in AssertNumRows operator and fix some explain [doris]

zhiqiang-hhhh opened a new pull request, #28935:
URL: https://github.com/apache/doris/pull/28935

   1. support filter in AssertNumRows on BE
   2. explain of AssertNumRows prints predicates
   3. explain of DataGenScanNode prints predicates


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](assert_num_rows) support filter in AssertNumRows operator and fix some explain [doris]

Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on PR #28935:
URL: https://github.com/apache/doris/pull/28935#issuecomment-1868483845

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](assert_num_rows) support filter in AssertNumRows operator and fix some explain [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28935:
URL: https://github.com/apache/doris/pull/28935#issuecomment-1868768975

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 44.22 seconds
    stream load tsv:          563 seconds loaded 74807831229 Bytes, about 126 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          67 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          33 seconds loaded 861443392 Bytes, about 24 MB/s
    insert into select:          29.8 seconds inserted 10000000 Rows, about 335K ops/s
    storage size: 17183695479 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](assert_num_rows) support filter in AssertNumRows operator and fix some explain [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28935:
URL: https://github.com/apache/doris/pull/28935#issuecomment-1868762512

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit 317c04aee8314489386389325557276faa5a5cd2, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4679	4387	4391	4387
   q2	370	145	159	145
   q3	1459	1256	1199	1199
   q4	1115	902	927	902
   q5	3166	3178	3151	3151
   q6	250	134	132	132
   q7	1009	488	498	488
   q8	2203	2250	2219	2219
   q9	6692	6667	6675	6667
   q10	3214	3290	3287	3287
   q11	323	184	190	184
   q12	359	207	213	207
   q13	4545	3811	3805	3805
   q14	247	216	217	216
   q15	582	525	522	522
   q16	438	383	393	383
   q17	1032	685	587	587
   q18	7231	6721	6761	6721
   q19	1538	1471	1349	1349
   q20	544	326	297	297
   q21	3104	2653	2684	2653
   q22	353	273	278	273
   Total cold run time: 44453 ms
   Total hot run time: 39774 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4320	4373	4332	4332
   q2	270	168	171	168
   q3	3513	3501	3494	3494
   q4	2407	2374	2382	2374
   q5	5706	5750	5726	5726
   q6	242	123	123	123
   q7	2354	1892	1869	1869
   q8	3529	3535	3529	3529
   q9	9019	9038	9006	9006
   q10	3909	3999	3999	3999
   q11	490	365	367	365
   q12	763	591	606	591
   q13	4318	3590	3546	3546
   q14	295	260	261	260
   q15	572	527	520	520
   q16	502	487	491	487
   q17	1890	1870	1872	1870
   q18	8468	8177	8057	8057
   q19	1757	1749	1772	1749
   q20	2252	1954	1932	1932
   q21	6470	6195	6145	6145
   q22	499	435	418	418
   Total cold run time: 63545 ms
   Total hot run time: 60560 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](assert_num_rows) support filter in AssertNumRows operator and fix some explain [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28935:
URL: https://github.com/apache/doris/pull/28935#issuecomment-1868489670

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit eb4040e018c5606ac6f93082d0100f81bdd8a4c1, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4653	4420	4427	4420
   q2	367	188	159	159
   q3	1440	1245	1263	1245
   q4	1113	894	902	894
   q5	3126	3141	3168	3141
   q6	248	126	128	126
   q7	996	485	498	485
   q8	2159	2226	2196	2196
   q9	6688	6672	6631	6631
   q10	3211	3308	3297	3297
   q11	304	189	188	188
   q12	354	205	208	205
   q13	4546	3821	3778	3778
   q14	242	208	218	208
   q15	571	522	527	522
   q16	448	386	388	386
   q17	1018	601	529	529
   q18	7066	6848	6841	6841
   q19	1518	1395	1445	1395
   q20	579	325	300	300
   q21	3057	2654	2621	2621
   q22	353	277	285	277
   Total cold run time: 44057 ms
   Total hot run time: 39844 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4347	4349	4324	4324
   q2	269	165	173	165
   q3	3500	3499	3479	3479
   q4	2391	2373	2382	2373
   q5	5688	5696	5688	5688
   q6	241	121	122	121
   q7	2338	1841	1904	1841
   q8	3517	3518	3500	3500
   q9	8999	8966	8918	8918
   q10	3901	3995	4020	3995
   q11	474	369	367	367
   q12	761	611	591	591
   q13	4262	3576	3590	3576
   q14	296	262	247	247
   q15	576	522	522	522
   q16	490	452	443	443
   q17	1872	1845	1866	1845
   q18	8479	8202	8152	8152
   q19	1750	1720	1729	1720
   q20	2262	1943	1937	1937
   q21	6499	6116	6135	6116
   q22	492	427	424	424
   Total cold run time: 63404 ms
   Total hot run time: 60344 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](assert_num_rows) support filter in AssertNumRows operator and fix some explain [doris]

Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on PR #28935:
URL: https://github.com/apache/doris/pull/28935#issuecomment-1868531133

   run build all


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](assert_num_rows) support filter in AssertNumRows operator and fix some explain [doris]

Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on PR #28935:
URL: https://github.com/apache/doris/pull/28935#issuecomment-1868531178

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](assert_num_rows) support filter in AssertNumRows operator and fix some explain [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28935:
URL: https://github.com/apache/doris/pull/28935#issuecomment-1869002129

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](assert_num_rows) support filter in AssertNumRows operator and fix some explain [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #28935:
URL: https://github.com/apache/doris/pull/28935


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](assert_num_rows) support filter in AssertNumRows operator and fix some explain [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28935:
URL: https://github.com/apache/doris/pull/28935#issuecomment-1868756213

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](assert_num_rows) support filter in AssertNumRows operator and fix some explain [doris]

Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on PR #28935:
URL: https://github.com/apache/doris/pull/28935#issuecomment-1868754035

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](assert_num_rows) support filter in AssertNumRows operator and fix some explain [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28935:
URL: https://github.com/apache/doris/pull/28935#issuecomment-1868489042

   TeamCity be ut coverage result:
    Function Coverage: 36.59% (8550/23364) 
    Line Coverage: 28.67% (69529/242503)
    Region Coverage: 27.67% (35950/129946)
    Branch Coverage: 24.40% (18379/75326)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/eb4040e018c5606ac6f93082d0100f81bdd8a4c1_eb4040e018c5606ac6f93082d0100f81bdd8a4c1/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](assert_num_rows) support filter in AssertNumRows operator and fix some explain [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28935:
URL: https://github.com/apache/doris/pull/28935#issuecomment-1868485048

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](assert_num_rows) support filter in AssertNumRows operator and fix some explain [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28935:
URL: https://github.com/apache/doris/pull/28935#issuecomment-1868531521

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](assert_num_rows) support filter in AssertNumRows operator and fix some explain [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28935:
URL: https://github.com/apache/doris/pull/28935#issuecomment-1868492063

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 44.69 seconds
    stream load tsv:          571 seconds loaded 74807831229 Bytes, about 124 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          66 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          29.1 seconds inserted 10000000 Rows, about 343K ops/s
    storage size: 17183953654 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](assert_num_rows) support filter in AssertNumRows operator and fix some explain [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28935:
URL: https://github.com/apache/doris/pull/28935#issuecomment-1869002119

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](assert_num_rows) support filter in AssertNumRows operator and fix some explain [doris]

Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on PR #28935:
URL: https://github.com/apache/doris/pull/28935#issuecomment-1868530296

   run build all


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](assert_num_rows) support filter in AssertNumRows operator and fix some explain [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28935:
URL: https://github.com/apache/doris/pull/28935#issuecomment-1868768835

   TeamCity be ut coverage result:
    Function Coverage: 36.58% (8554/23387) 
    Line Coverage: 28.65% (69565/242770)
    Region Coverage: 27.66% (35979/130085)
    Branch Coverage: 24.39% (18392/75414)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/317c04aee8314489386389325557276faa5a5cd2_317c04aee8314489386389325557276faa5a5cd2/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org