You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "MichaelChirico (via GitHub)" <gi...@apache.org> on 2026/04/27 17:02:28 UTC
[PR] MINOR: [R] Skip translation tests if NLS is not enabled [arrow]
MichaelChirico opened a new pull request, #49874:
URL: https://github.com/apache/arrow/pull/49874
### Rationale for this change
R builds with `--disable-nls` and no `-DENABLE_NLS=1` will not translate any messages, so associated tests don't really make sense.
### What changes are included in this PR?
Skip such tests by reading from `capabilities()`.
### Are these changes tested?
GHA/CI
### Are there any user-facing changes?
No
### Could this be solved another way?
Yes, I think we could just use `withr::with_language()` instead which has its own `capabilities()` check:
https://github.com/r-lib/withr/blob/22e392c9cc13efaa9ba042bb193991f78316edb1/R/language.R#L81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [R] Skip translation tests if NLS is not enabled [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #49874:
URL: https://github.com/apache/arrow/pull/49874#issuecomment-4329689584
Agreed, building R from source is overkill. Let's merge this as is — I don't think it needs anything else (or a news entry, etc.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [R] Skip translation tests if NLS is not enabled [arrow]
Posted by "MichaelChirico (via GitHub)" <gi...@apache.org>.
MichaelChirico commented on PR #49874:
URL: https://github.com/apache/arrow/pull/49874#issuecomment-4329635012
Don't have one handy, I'd bet re-building R (needed for `--disable-nls` to take hold, AFAIK) is overkill. I'm also not sure how useful mocking is here. WDYT? Worth pursuing further?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [R] Skip translation tests if NLS is not enabled [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane merged PR #49874:
URL: https://github.com/apache/arrow/pull/49874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org