You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Erick Tryzelaar (JIRA)" <ji...@apache.org> on 2010/04/16 06:49:25 UTC

[jira] Created: (CASSANDRA-988) DatacenterEndPointSnitch does not work with RackAwareStrategy

DatacenterEndPointSnitch does not work with RackAwareStrategy
-------------------------------------------------------------

                 Key: CASSANDRA-988
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-988
             Project: Cassandra
          Issue Type: Bug
          Components: Core
    Affects Versions: 0.6, 0.6.1, 0.6.2, 0.7, 0.8
            Reporter: Erick Tryzelaar


RackAwareStrategy explicitly tests for the snitch to be a subclass of EndPointSnitch, but DatacenterEndPointSnitch doesn't subclass from it, but rather AbstractEndPointSnitch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CASSANDRA-988) DatacenterEndPointSnitch does not work with RackAwareStrategy

Posted by "Erick Tryzelaar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erick Tryzelaar updated CASSANDRA-988:
--------------------------------------

    Attachment: 0001-Rename-AbstractEndpointSnitch-to-AbstractEndPointSni.patch
                0002-Fix-RackAwareStrategy-to-work-with-DatacenterEndPoin.patch

These depend on #984 being committed. The first patch is a simple rename of AbstractEndpointSnitch to AbstractEndPointSnitch to be consistent with the other locator files. The second changes the RackAwareStrategy to test for subclasses of AbstractEndPointSnitch instead of EndPointSnitch. Not sure if there's a more appropriate way to fix this though.

> DatacenterEndPointSnitch does not work with RackAwareStrategy
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-988
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-988
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7, 0.8
>            Reporter: Erick Tryzelaar
>         Attachments: 0001-Rename-AbstractEndpointSnitch-to-AbstractEndPointSni.patch, 0002-Fix-RackAwareStrategy-to-work-with-DatacenterEndPoin.patch
>
>
> RackAwareStrategy explicitly tests for the snitch to be a subclass of EndPointSnitch, but DatacenterEndPointSnitch doesn't subclass from it, but rather AbstractEndPointSnitch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CASSANDRA-988) DatacenterEndPointSnitch does not work with RackAwareStrategy

Posted by "Erick Tryzelaar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857674#action_12857674 ] 

Erick Tryzelaar commented on CASSANDRA-988:
-------------------------------------------

It looks like things aren't completely fixed yet. I'm now getting this assertion on a couple of my nodes:

java.lang.AssertionError
	at org.apache.cassandra.locator.TokenMetadata.removeEndpoint(TokenMetadata.java:192)
	at org.apache.cassandra.locator.TokenMetadata.cloneAfterAllLeft(TokenMetadata.java:296)
	at org.apache.cassandra.service.StorageService.calculatePendingRanges(StorageService.java:725)
	at org.apache.cassandra.service.StorageService.calculatePendingRanges(StorageService.java:703)
	at org.apache.cassandra.service.StorageService.handleStateNormal(StorageService.java:571)
	at org.apache.cassandra.service.StorageService.onChange(StorageService.java:514)
	at org.apache.cassandra.service.StorageService.onJoin(StorageService.java:881)
	at org.apache.cassandra.gms.Gossiper.handleMajorStateChange(Gossiper.java:588)
	at org.apache.cassandra.gms.Gossiper.handleNewJoin(Gossiper.java:563)
	at org.apache.cassandra.gms.Gossiper.applyStateLocally(Gossiper.java:630)
	at org.apache.cassandra.gms.Gossiper$GossipDigestAck2VerbHandler.doVerb(Gossiper.java:1016)
	at org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:41)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
	at java.lang.Thread.run(Thread.java:636)


> DatacenterEndPointSnitch does not work with RackAwareStrategy
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-988
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-988
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7, 0.8
>            Reporter: Erick Tryzelaar
>         Attachments: 0001-Rename-AbstractEndpointSnitch-to-AbstractEndPointSni.patch, 0002-Fix-RackAwareStrategy-to-work-with-DatacenterEndPoin.patch
>
>
> RackAwareStrategy explicitly tests for the snitch to be a subclass of EndPointSnitch, but DatacenterEndPointSnitch doesn't subclass from it, but rather AbstractEndPointSnitch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CASSANDRA-988) DatacenterEndPointSnitch does not work with RackAwareStrategy

Posted by "Erick Tryzelaar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857679#action_12857679 ] 

Erick Tryzelaar commented on CASSANDRA-988:
-------------------------------------------

That exception seems to be coming from a race condition. It occurred when I started the 10 nodes all at the same time. I repeated this while starting one node at a time, and they all came up cleanly.

> DatacenterEndPointSnitch does not work with RackAwareStrategy
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-988
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-988
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7, 0.8
>            Reporter: Erick Tryzelaar
>         Attachments: 0001-Rename-AbstractEndpointSnitch-to-AbstractEndPointSni.patch, 0002-Fix-RackAwareStrategy-to-work-with-DatacenterEndPoin.patch
>
>
> RackAwareStrategy explicitly tests for the snitch to be a subclass of EndPointSnitch, but DatacenterEndPointSnitch doesn't subclass from it, but rather AbstractEndPointSnitch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira