You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "baibaichen (via GitHub)" <gi...@apache.org> on 2024/05/07 15:25:55 UTC
[PR] [GLUTEN-5639] [CH] [DRAFT] Support spark.sql.decimalOperations.allowPrecisionLoss = true [incubator-gluten]
baibaichen opened a new pull request, #5640:
URL: https://github.com/apache/incubator-gluten/pull/5640
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: \#5639)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5639] [CH] [DRAFT] Support spark.sql.decimalOperations.allowPrecisionLoss = true [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5640:
URL: https://github.com/apache/incubator-gluten/pull/5640#issuecomment-2099630870
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5639] [CH] Support spark.sql.decimalOperations.allowPrecisionLoss = true [incubator-gluten]
Posted by "loneylee (via GitHub)" <gi...@apache.org>.
loneylee commented on PR #5640:
URL: https://github.com/apache/incubator-gluten/pull/5640#issuecomment-2100622714
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5639] [CH] [DRAFT] Support spark.sql.decimalOperations.allowPrecisionLoss = true [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5640:
URL: https://github.com/apache/incubator-gluten/pull/5640#issuecomment-2098713054
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5639] [CH] [DRAFT] Support spark.sql.decimalOperations.allowPrecisionLoss = true [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5640:
URL: https://github.com/apache/incubator-gluten/pull/5640#issuecomment-2100088677
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5639] [CH] [DRAFT] Support spark.sql.decimalOperations.allowPrecisionLoss = true [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5640:
URL: https://github.com/apache/incubator-gluten/pull/5640#issuecomment-2098712220
https://github.com/apache/incubator-gluten/issues/5639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5639] [CH] Support spark.sql.decimalOperations.allowPrecisionLoss = true [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #5640:
URL: https://github.com/apache/incubator-gluten/pull/5640#issuecomment-2100757821
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_5640_time.csv</font></td>
<td><font color=#000000>log/native_master_05_07_2024_254d62e72_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#F92663>q1</font></td>
<td><font color=#F92663>33.90</font></td>
<td><font color=#F92663>34.69</font></td>
<td><font color=#F92663>0.786</font></td>
<td><font color=#F92663>102.32%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q2</font></td>
<td><font color=#6F9915>23.82</font></td>
<td><font color=#6F9915>23.52</font></td>
<td><font color=#6F9915>-0.303</font></td>
<td><font color=#6F9915>98.73%</font></td>
</tr>
<tr>
<td><font color=#F92663>q3</font></td>
<td><font color=#F92663>36.29</font></td>
<td><font color=#F92663>39.12</font></td>
<td><font color=#F92663>2.836</font></td>
<td><font color=#F92663>107.82%</font></td>
</tr>
<tr>
<td><font color=#F92663>q4</font></td>
<td><font color=#F92663>36.04</font></td>
<td><font color=#F92663>38.99</font></td>
<td><font color=#F92663>2.952</font></td>
<td><font color=#F92663>108.19%</font></td>
</tr>
<tr>
<td><font color=#F92663>q5</font></td>
<td><font color=#F92663>69.22</font></td>
<td><font color=#F92663>70.47</font></td>
<td><font color=#F92663>1.250</font></td>
<td><font color=#F92663>101.81%</font></td>
</tr>
<tr>
<td><font color=#F92663>q6</font></td>
<td><font color=#F92663>5.91</font></td>
<td><font color=#F92663>7.99</font></td>
<td><font color=#F92663>2.084</font></td>
<td><font color=#F92663>135.29%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q7</font></td>
<td><font color=#6F9915>83.50</font></td>
<td><font color=#6F9915>82.58</font></td>
<td><font color=#6F9915>-0.922</font></td>
<td><font color=#6F9915>98.90%</font></td>
</tr>
<tr>
<td><font color=#F92663>q8</font></td>
<td><font color=#F92663>83.75</font></td>
<td><font color=#F92663>85.88</font></td>
<td><font color=#F92663>2.135</font></td>
<td><font color=#F92663>102.55%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q9</font></td>
<td><font color=#6F9915>126.72</font></td>
<td><font color=#6F9915>125.69</font></td>
<td><font color=#6F9915>-1.029</font></td>
<td><font color=#6F9915>99.19%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q10</font></td>
<td><font color=#6F9915>45.71</font></td>
<td><font color=#6F9915>44.17</font></td>
<td><font color=#6F9915>-1.536</font></td>
<td><font color=#6F9915>96.64%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q11</font></td>
<td><font color=#6F9915>20.66</font></td>
<td><font color=#6F9915>19.52</font></td>
<td><font color=#6F9915>-1.147</font></td>
<td><font color=#6F9915>94.45%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q12</font></td>
<td><font color=#6F9915>27.23</font></td>
<td><font color=#6F9915>25.07</font></td>
<td><font color=#6F9915>-2.156</font></td>
<td><font color=#6F9915>92.08%</font></td>
</tr>
<tr>
<td><font color=#F92663>q13</font></td>
<td><font color=#F92663>53.96</font></td>
<td><font color=#F92663>54.78</font></td>
<td><font color=#F92663>0.817</font></td>
<td><font color=#F92663>101.51%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q14</font></td>
<td><font color=#6F9915>17.88</font></td>
<td><font color=#6F9915>16.46</font></td>
<td><font color=#6F9915>-1.418</font></td>
<td><font color=#6F9915>92.07%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q15</font></td>
<td><font color=#6F9915>29.44</font></td>
<td><font color=#6F9915>29.15</font></td>
<td><font color=#6F9915>-0.283</font></td>
<td><font color=#6F9915>99.04%</font></td>
</tr>
<tr>
<td><font color=#F92663>q16</font></td>
<td><font color=#F92663>12.92</font></td>
<td><font color=#F92663>14.27</font></td>
<td><font color=#F92663>1.351</font></td>
<td><font color=#F92663>110.46%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q17</font></td>
<td><font color=#6F9915>105.30</font></td>
<td><font color=#6F9915>104.34</font></td>
<td><font color=#6F9915>-0.963</font></td>
<td><font color=#6F9915>99.09%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q18</font></td>
<td><font color=#6F9915>146.46</font></td>
<td><font color=#6F9915>144.89</font></td>
<td><font color=#6F9915>-1.560</font></td>
<td><font color=#6F9915>98.93%</font></td>
</tr>
<tr>
<td><font color=#F92663>q19</font></td>
<td><font color=#F92663>13.58</font></td>
<td><font color=#F92663>15.16</font></td>
<td><font color=#F92663>1.575</font></td>
<td><font color=#F92663>111.59%</font></td>
</tr>
<tr>
<td><font color=#F92663>q20</font></td>
<td><font color=#F92663>26.09</font></td>
<td><font color=#F92663>26.39</font></td>
<td><font color=#F92663>0.300</font></td>
<td><font color=#F92663>101.15%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q21</font></td>
<td><font color=#6F9915>285.67</font></td>
<td><font color=#6F9915>283.25</font></td>
<td><font color=#6F9915>-2.415</font></td>
<td><font color=#6F9915>99.15%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q22</font></td>
<td><font color=#6F9915>15.02</font></td>
<td><font color=#6F9915>14.47</font></td>
<td><font color=#6F9915>-0.553</font></td>
<td><font color=#6F9915>96.32%</font></td>
</tr>
<tr>
<td><font color=#F92663>total</font></td>
<td><font color=#F92663>1299.05</font></td>
<td><font color=#F92663>1300.85</font></td>
<td><font color=#F92663>1.802</font></td>
<td><font color=#F92663>100.14%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5639] [CH] Support spark.sql.decimalOperations.allowPrecisionLoss = true [incubator-gluten]
Posted by "baibaichen (via GitHub)" <gi...@apache.org>.
baibaichen merged PR #5640:
URL: https://github.com/apache/incubator-gluten/pull/5640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org