You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Akshesh Doshi (JIRA)" <ji...@apache.org> on 2019/06/11 05:00:00 UTC
[jira] [Updated] (AIRFLOW-4763) DockerOperator command parameter
does not allow lists
[ https://issues.apache.org/jira/browse/AIRFLOW-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Akshesh Doshi updated AIRFLOW-4763:
-----------------------------------
Description:
According to the docstring `command` parameter allows `list` as input ([https://github.com/apache/airflow/blob/master/airflow/operators/docker_operator.py#L56])
But the `strip` function being called here indicates that `command` is assumed to be a string ([https://github.com/apache/airflow/blob/master/airflow/operators/docker_operator.py#L250])
It would be very nice to allow `list` inputs as well. I think the fix would be to add this before the line calling `.strip()`:
{code:python}
if type(command) == list:
commands = command
{code}
was:
According to the docstring `command` parameter allows `list` as input ([https://github.com/apache/airflow/blob/master/airflow/operators/docker_operator.py#L56])
But the `strip` function being called here indicates that `command` is assumed to be a string ([https://github.com/apache/airflow/blob/master/airflow/operators/docker_operator.py#L250])
It would be very nice to allow `list` inputs as well. The fix would be to add this before the line calling `.strip()`
```
if type(command) == list:
commands = command
```
> DockerOperator command parameter does not allow lists
> -----------------------------------------------------
>
> Key: AIRFLOW-4763
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4763
> Project: Apache Airflow
> Issue Type: Bug
> Components: operators
> Affects Versions: 1.10.4
> Reporter: Akshesh Doshi
> Priority: Minor
>
> According to the docstring `command` parameter allows `list` as input ([https://github.com/apache/airflow/blob/master/airflow/operators/docker_operator.py#L56])
> But the `strip` function being called here indicates that `command` is assumed to be a string ([https://github.com/apache/airflow/blob/master/airflow/operators/docker_operator.py#L250])
>
>
> It would be very nice to allow `list` inputs as well. I think the fix would be to add this before the line calling `.strip()`:
> {code:python}
> if type(command) == list:
> commands = command
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)