You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/03 01:29:42 UTC
[GitHub] [arrow-ballista] andygrove opened a new pull request, #110: MINOR: Use `sqlparser` version exported by `datafusion` crates
andygrove opened a new pull request, #110:
URL: https://github.com/apache/arrow-ballista/pull/110
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
N/A
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Ballista should always use the same version of sqlparser as DataFusion.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- Remove Cargo dependency on `sqlparser`
- Use the version exported by DataFusion
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] avantgardnerio commented on pull request #110: MINOR: Use `sqlparser` version exported by `datafusion` crates
Posted by GitBox <gi...@apache.org>.
avantgardnerio commented on PR #110:
URL: https://github.com/apache/arrow-ballista/pull/110#issuecomment-1205516505
Thanks for providing the link @andygrove . If I understand correctly, I think I have to agree with this comment: https://github.com/rust-lang/api-guidelines/discussions/176#discussioncomment-232635
> no way of discerning that this doc is lifted from the futures crate
Except that it's not just about docs, it's about information loss. Cargo is able to maintian a DAG of dependencies and detect conflicts. If I understand correctly, if a dependency is re-exported, then this information is lost?
Also, if ballista were to add another important 3rd party dependency that followed the same practice (re-exporting their own SQL parser) it would be impossible to pass a `sqlparser::ast::Statement` between the two crates in a safe way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #110: MINOR: Use `sqlparser` version exported by `datafusion` crates
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #110:
URL: https://github.com/apache/arrow-ballista/pull/110#issuecomment-1212114838
> Also, if ballista were to add another important 3rd party dependency that followed the same practice (re-exporting their own SQL parser) it would be impossible to pass a `sqlparser::ast::Statement` between the two crates in a safe way?
I just learned this lesson rather painfully in another project. I am no longer a fan of re-exporting!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #110: MINOR: Use `sqlparser` version exported by `datafusion` crates
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #110:
URL: https://github.com/apache/arrow-ballista/pull/110#issuecomment-1212223496
I may have closed this prematurely. I should have just used `[patch.crates-io]` to override versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #110: MINOR: Use `sqlparser` version exported by `datafusion` crates
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #110:
URL: https://github.com/apache/arrow-ballista/pull/110#issuecomment-1204487949
> If you have any external links to best practices, or if this was discussed previously, I'd love to see those discussions as well.
The best resource I can find is this: https://github.com/rust-lang/api-guidelines/discussions/176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove closed pull request #110: MINOR: Use `sqlparser` version exported by `datafusion` crates
Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #110: MINOR: Use `sqlparser` version exported by `datafusion` crates
URL: https://github.com/apache/arrow-ballista/pull/110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #110: MINOR: Use `sqlparser` version exported by `datafusion` crates
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #110:
URL: https://github.com/apache/arrow-ballista/pull/110#issuecomment-1203381530
fyi @avantgardnerio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org