You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/27 07:24:58 UTC

[GitHub] [doris] Kikyou1997 commented on a diff in pull request #11035: [Feature](nereids) support sub-query and alias for TPC-H

Kikyou1997 commented on code in PR #11035:
URL: https://github.com/apache/doris/pull/11035#discussion_r930709610


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Slot.java:
##########
@@ -30,4 +32,8 @@ public Slot toSlot() {
     public Slot withNullable(boolean newNullable) {
         throw new RuntimeException("Do not implement");
     }
+
+    public Slot withQualifier(List<String> qualifiers) {
+        throw new RuntimeException("Do not implement");

Review Comment:
   "Not implemented" may be a better exception message here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org