You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/21 11:16:48 UTC
[GitHub] [camel-website] CSElonewolf opened a new pull request #255:
SearchBox inside Menu in Mobile Version
CSElonewolf opened a new pull request #255: SearchBox inside Menu in Mobile Version
URL: https://github.com/apache/camel-website/pull/255
*Previously the SearchBox disappered in mobile version but now it appears inside the menu*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #255: SearchBox inside
Menu in Mobile Version
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #255: SearchBox inside Menu in Mobile Version
URL: https://github.com/apache/camel-website/pull/255#issuecomment-607970264
@CSElonewolf are you working on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #255: SearchBox inside
Menu in Mobile Version
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #255: SearchBox inside Menu in Mobile Version
URL: https://github.com/apache/camel-website/pull/255#issuecomment-604960363
@CSElonewolf remember that you can build locally to preview the result, this is how this change currently looks like:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#255: SearchBox inside Menu in Mobile Version
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #255: SearchBox inside Menu in Mobile Version
URL: https://github.com/apache/camel-website/pull/255#discussion_r399212274
##########
File path: antora-ui-camel/src/partials/header-content.hbs
##########
@@ -15,6 +15,10 @@
{{/each}}
</div>
</div>
+ <div class="navbar-search results-hidden">
+ <input id="search_mobile" class="search" placeholder="Search" autocomplete="off">
+ <div id="search_results_mobile"></div>
+ </div>
Review comment:
I think problem with this is that it's rendered multiple times (notice the `#each @items` on line 8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#255: SearchBox inside Menu in Mobile Version
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #255: SearchBox inside Menu in Mobile Version
URL: https://github.com/apache/camel-website/pull/255#discussion_r399824093
##########
File path: layouts/partials/header.html
##########
@@ -46,6 +46,10 @@
{{ end }}
</div>
</div>
+ <div class="navbar-search results-hidden">
+ <input id="search_mobile" class="search" placeholder="Search" autocomplete="off">
+ <div id="search_results_mobile"></div>
+ </div>
Review comment:
This is also within the range loop on line 39, I think it should be placed outside as in the Antora UI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf commented on issue #255: SearchBox
inside Menu in Mobile Version
Posted by GitBox <gi...@apache.org>.
CSElonewolf commented on issue #255: SearchBox inside Menu in Mobile Version
URL: https://github.com/apache/camel-website/pull/255#issuecomment-603683390
> The checks fail due to repeating id:
>
> ```
> [2020-03-23T17:09:51.309Z] public/acknowledgments/index.html
> [2020-03-23T17:09:51.309Z] 1:3599 error Duplicate ID "search_mobile" no-dup-id
> [2020-03-23T17:09:51.309Z] 1:3679 error Duplicate ID "search_results_mobile" no-dup-id
> [2020-03-23T17:09:51.309Z] 1:4330 error Duplicate ID "search_mobile" no-dup-id
> [2020-03-23T17:09:51.309Z] 1:4410 error Duplicate ID "search_results_mobile" no-dup-id
> [2020-03-23T17:09:51.309Z] 1:5135 error Duplicate ID "search_mobile" no-dup-id
> [2020-03-23T17:09:51.309Z] 1:5215 error Duplicate ID "search_results_mobile" no-dup-id
> ```
>
> We also need the corresponding change in the Anotra UI layout as this changes only the Hugo layout.
I couldn't find the actual file inside [link](https://github.com/apache/camel-website/tree/master/antora-ui-camel/src/partials).
Please can you help me with this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#255: SearchBox inside Menu in Mobile Version
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #255: SearchBox inside Menu in Mobile Version
URL: https://github.com/apache/camel-website/pull/255#discussion_r397077595
##########
File path: antora-ui-camel/src/css/header.css
##########
@@ -416,3 +416,21 @@ body {
display: none;
}
}
+
+@media screen and (min-width: 610px) {
Review comment:
Let's not add another media breakpoint, please use the ones we have already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf commented on issue #255: SearchBox
inside Menu in Mobile Version
Posted by GitBox <gi...@apache.org>.
CSElonewolf commented on issue #255: SearchBox inside Menu in Mobile Version
URL: https://github.com/apache/camel-website/pull/255#issuecomment-607980777
I am currently not working on this.Actually I got little bit confused with the range of the loop and thus I am struggling with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#255: SearchBox inside Menu in Mobile Version
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #255: SearchBox inside Menu in Mobile Version
URL: https://github.com/apache/camel-website/pull/255#discussion_r400468983
##########
File path: layouts/partials/header.html
##########
@@ -46,6 +46,10 @@
{{ end }}
</div>
</div>
+ <div class="navbar-search results-hidden">
+ <input id="search_mobile" class="search" placeholder="Search" autocomplete="off">
+ <div id="search_results_mobile"></div>
+ </div>
Review comment:
Odd that you say that it's not within the loop then. The range loop starts on line 39 and ends on line 56
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf commented on issue #255: SearchBox
inside Menu in Mobile Version
Posted by GitBox <gi...@apache.org>.
CSElonewolf commented on issue #255: SearchBox inside Menu in Mobile Version
URL: https://github.com/apache/camel-website/pull/255#issuecomment-604662763
@zregvart I have made the requested Changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf commented on issue #255: SearchBox
inside Menu in Mobile Version
Posted by GitBox <gi...@apache.org>.
CSElonewolf commented on issue #255: SearchBox inside Menu in Mobile Version
URL: https://github.com/apache/camel-website/pull/255#issuecomment-604963414
Then I think we need to place it after `{{/withMenuData}}` at line 22
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf commented on a change in pull request
#255: SearchBox inside Menu in Mobile Version
Posted by GitBox <gi...@apache.org>.
CSElonewolf commented on a change in pull request #255: SearchBox inside Menu in Mobile Version
URL: https://github.com/apache/camel-website/pull/255#discussion_r399836481
##########
File path: layouts/partials/header.html
##########
@@ -46,6 +46,10 @@
{{ end }}
</div>
</div>
+ <div class="navbar-search results-hidden">
+ <input id="search_mobile" class="search" placeholder="Search" autocomplete="off">
+ <div id="search_results_mobile"></div>
+ </div>
Review comment:
No.But I have placed it outside the as I have placed in Antora UI.
Actually I couldn't find till which line the range of the loop is in Hugo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf edited a comment on issue #255:
SearchBox inside Menu in Mobile Version
Posted by GitBox <gi...@apache.org>.
CSElonewolf edited a comment on issue #255: SearchBox inside Menu in Mobile Version
URL: https://github.com/apache/camel-website/pull/255#issuecomment-604963414
Then I think we need to place it before `{{/withMenuData}}` at line 22
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services