You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "janhoy (via GitHub)" <gi...@apache.org> on 2024/01/08 21:48:34 UTC
[PR] Introduce stale bot [solr]
janhoy opened a new pull request, #2184:
URL: https://github.com/apache/solr/pull/2184
Following Lucene's lead and adding a stale bot that will label open, non-draft PRs as `Stale` after 14 days of inactivity. It is almost identical fork of Lucene's config: https://github.com/apache/lucene/blob/main/.github/workflows/stale.yml
I re-wrote the stale-message text a bit. I don't think random contributors can tag developers as reviewer, so I encouraged instead tagging people in a comment or emailing the dev-list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Introduce stale bot [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on code in PR #2184:
URL: https://github.com/apache/solr/pull/2184#discussion_r1446719703
##########
.github/workflows/stale.yml:
##########
@@ -0,0 +1,39 @@
+# This workflow warns of PRs that have had no activity for a specified amount of time.
+#
+# For more information, see https://github.com/actions/stale
+name: Mark stale pull requests
+
+on:
+ # Run every day at 00:00 UTC
+ schedule:
+ - cron: '0 0 * * *'
+ # Or run on demand
+ workflow_dispatch:
+
+jobs:
+ stale:
+
+ runs-on: ubuntu-latest
+ permissions:
+ pull-requests: write
+
+ steps:
+ - uses: actions/stale@v9
+ with:
+ repo-token: ${{ secrets.GITHUB_TOKEN }}
+
+ days-before-pr-stale: 14
+ days-before-issue-stale: -1 # we don't use issues
+ days-before-close: -1 # don't close stale PRs/issues
+ exempt-draft-pr: true # don't mark draft PRs as stale
+ stale-pr-label: "stale" # label to use when marking as stale
+
+ stale-pr-message: >
+ This PR has not had activity in the past 2 weeks, labeling it as stale.
+ Any new activity will remove the stale label. To attract more reviewers, tag
Review Comment:
I don't think it matters whether there are merge conflicts or not. If a PR is stale, it should be quite obvious what next steps are? Or is it unclear? A contributor should aim to get all lights green, and then ask for review. But if the contributor needs help she can of course ask for help at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Introduce stale bot [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on code in PR #2184:
URL: https://github.com/apache/solr/pull/2184#discussion_r1460699180
##########
.github/workflows/stale.yml:
##########
@@ -0,0 +1,39 @@
+# This workflow warns of PRs that have had no activity for a specified amount of time.
+#
+# For more information, see https://github.com/actions/stale
+name: Mark stale pull requests
+
+on:
+ # Run every day at 00:00 UTC
+ schedule:
+ - cron: '0 0 * * *'
+ # Or run on demand
+ workflow_dispatch:
+
+jobs:
+ stale:
+
+ runs-on: ubuntu-latest
+ permissions:
+ pull-requests: write
+
+ steps:
+ - uses: actions/stale@v9
+ with:
+ repo-token: ${{ secrets.GITHUB_TOKEN }}
+
+ days-before-pr-stale: 14
Review Comment:
I wonder if we can should consider 30 days stale time to avoid some noise over holidays etc.
And what if we sent an automated monthly email to dev@ with list of stale PS. That would let both committers and contributors triage and decide whether to close or contribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Introduce stale bot [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #2184:
URL: https://github.com/apache/solr/pull/2184#discussion_r1461836649
##########
.github/workflows/stale.yml:
##########
@@ -0,0 +1,39 @@
+# This workflow warns of PRs that have had no activity for a specified amount of time.
+#
+# For more information, see https://github.com/actions/stale
+name: Mark stale pull requests
+
+on:
+ # Run every day at 00:00 UTC
+ schedule:
+ - cron: '0 0 * * *'
+ # Or run on demand
+ workflow_dispatch:
+
+jobs:
+ stale:
+
+ runs-on: ubuntu-latest
+ permissions:
+ pull-requests: write
+
+ steps:
+ - uses: actions/stale@v9
+ with:
+ repo-token: ${{ secrets.GITHUB_TOKEN }}
+
+ days-before-pr-stale: 14
Review Comment:
When I first saw this, I thought 14 days was pretty aggressive! Quepid has 120 days till stale (though of course tiny community!).... And then another 60 days till the ticket gets closed... (because I like having only a few issues!).
The automated email is an interesting idea! If it had the labels, then folks might be able to see "oh, here is a PR in an area I care about" and move them along...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Introduce stale bot [solr]
Posted by "cpoerschke (via GitHub)" <gi...@apache.org>.
cpoerschke commented on code in PR #2184:
URL: https://github.com/apache/solr/pull/2184#discussion_r1446319712
##########
.github/workflows/stale.yml:
##########
@@ -0,0 +1,39 @@
+# This workflow warns of PRs that have had no activity for a specified amount of time.
+#
+# For more information, see https://github.com/actions/stale
+name: Mark stale pull requests
+
+on:
+ # Run every day at 00:00 UTC
+ schedule:
+ - cron: '0 0 * * *'
+ # Or run on demand
+ workflow_dispatch:
+
+jobs:
+ stale:
+
+ runs-on: ubuntu-latest
+ permissions:
+ pull-requests: write
+
+ steps:
+ - uses: actions/stale@v9
+ with:
+ repo-token: ${{ secrets.GITHUB_TOKEN }}
+
+ days-before-pr-stale: 14
+ days-before-issue-stale: -1 # we don't use issues
+ days-before-close: -1 # don't close stale PRs/issues
+ exempt-draft-pr: true # don't mark draft PRs as stale
+ stale-pr-label: "stale" # label to use when marking as stale
+
+ stale-pr-message: >
+ This PR has not had activity in the past 2 weeks, labeling it as stale.
+ Any new activity will remove the stale label. To attract more reviewers, tag
Review Comment:
And wondering about pull requests with merge conflicts e.g. to suggest or not to suggest to try and resolve any merge conflicts. Maybe that would be a different kind of bot though.
```suggestion
Any new activity will remove the stale label. To attract more reviewers, please tag
```
##########
.github/workflows/stale.yml:
##########
@@ -0,0 +1,39 @@
+# This workflow warns of PRs that have had no activity for a specified amount of time.
+#
+# For more information, see https://github.com/actions/stale
+name: Mark stale pull requests
+
+on:
+ # Run every day at 00:00 UTC
+ schedule:
+ - cron: '0 0 * * *'
+ # Or run on demand
+ workflow_dispatch:
+
+jobs:
+ stale:
+
+ runs-on: ubuntu-latest
+ permissions:
+ pull-requests: write
+
+ steps:
+ - uses: actions/stale@v9
+ with:
+ repo-token: ${{ secrets.GITHUB_TOKEN }}
+
+ days-before-pr-stale: 14
+ days-before-issue-stale: -1 # we don't use issues
+ days-before-close: -1 # don't close stale PRs/issues
+ exempt-draft-pr: true # don't mark draft PRs as stale
+ stale-pr-label: "stale" # label to use when marking as stale
+
+ stale-pr-message: >
+ This PR has not had activity in the past 2 weeks, labeling it as stale.
Review Comment:
Maybe shortening "has not had" to "had no" and use "visible" to signal that maybe someone looked but did not (yet) comment?
```suggestion
This PR had no visible activity in the past 2 weeks, labeling it as stale.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Introduce stale bot [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on code in PR #2184:
URL: https://github.com/apache/solr/pull/2184#discussion_r1463332602
##########
.github/workflows/stale.yml:
##########
@@ -0,0 +1,39 @@
+# This workflow warns of PRs that have had no activity for a specified amount of time.
+#
+# For more information, see https://github.com/actions/stale
+name: Mark stale pull requests
+
+on:
+ # Run every day at 00:00 UTC
+ schedule:
+ - cron: '0 0 * * *'
+ # Or run on demand
+ workflow_dispatch:
+
+jobs:
+ stale:
+
+ runs-on: ubuntu-latest
+ permissions:
+ pull-requests: write
+
+ steps:
+ - uses: actions/stale@v9
+ with:
+ repo-token: ${{ secrets.GITHUB_TOKEN }}
+
+ days-before-pr-stale: 14
Review Comment:
Changed to 30 days.
The monthly email would be a separate bot/script in a different GH action. It would need to use a pre-accepted email address as sender to be allowed to post to dev@ list, and a SMTP server to send from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Introduce stale bot [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #2184:
URL: https://github.com/apache/solr/pull/2184#issuecomment-1912252079
Being on the conservative side, I upped to 60 days before stale, and a daily budget of 10 PRs labeled.
This should create a minimum of friction and accomodate for the fact that in the Solr project, some development cycles are just slow without being stale. If noone touched a PR for 60 days, it's hard to argue that it is active, so a nudge by the bot may help drive some of those that just fell off the radar further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Introduce stale bot [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy merged PR #2184:
URL: https://github.com/apache/solr/pull/2184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org