You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tez.apache.org by hi...@apache.org on 2015/01/21 01:20:43 UTC

tez git commit: TEZ-1980. Suppress tez-dag findbugs warnings until addressed. (htesh)

Repository: tez
Updated Branches:
  refs/heads/master ecf1ff58f -> 31ae9be54


TEZ-1980. Suppress tez-dag findbugs warnings until addressed. (htesh)


Project: http://git-wip-us.apache.org/repos/asf/tez/repo
Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/31ae9be5
Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/31ae9be5
Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/31ae9be5

Branch: refs/heads/master
Commit: 31ae9be540b81f24c5796ab5b99bc4c6d2888fc6
Parents: ecf1ff5
Author: Hitesh Shah <hi...@apache.org>
Authored: Tue Jan 20 16:20:14 2015 -0800
Committer: Hitesh Shah <hi...@apache.org>
Committed: Tue Jan 20 16:20:14 2015 -0800

----------------------------------------------------------------------
 CHANGES.txt                  |   1 +
 tez-dag/findbugs-exclude.xml | 104 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 105 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tez/blob/31ae9be5/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index 3ec7002..38cd91c 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -7,6 +7,7 @@ Release 0.7.0: Unreleased
 INCOMPATIBLE CHANGES
 
 ALL CHANGES:
+  TEZ-1980. Suppress tez-dag findbugs warnings until addressed.
   TEZ-1855. Avoid scanning for previously written files within Inputs / Outputs.
   TEZ-1902. Fix findbugs warnings in tez-mapreduce.
   TEZ-1963. Fix post memory merge to be > 2 GB.

http://git-wip-us.apache.org/repos/asf/tez/blob/31ae9be5/tez-dag/findbugs-exclude.xml
----------------------------------------------------------------------
diff --git a/tez-dag/findbugs-exclude.xml b/tez-dag/findbugs-exclude.xml
index 77a18ec..233f76c 100644
--- a/tez-dag/findbugs-exclude.xml
+++ b/tez-dag/findbugs-exclude.xml
@@ -115,4 +115,108 @@
     <Bug pattern="EI_EXPOSE_REP"/>
   </Match>
 
+  <!-- TEZ-1952 -->
+  <Match>
+    <Class name="org.apache.tez.dag.app.dag.impl.Edge"/>
+    <Field name="edgeProperty"/>
+    <Bug pattern="IS2_INCONSISTENT_SYNC"/>
+  </Match>
+
+  <!-- TEZ-1953 -->
+  <Match>
+    <Class name="org.apache.tez.dag.app.dag.impl.VertexImpl"/>
+    <Field name="groupInputSpecList"/>
+    <Bug pattern="IS2_INCONSISTENT_SYNC"/>
+  </Match>
+
+  <!-- TEZ-1954 -->
+  <Match>
+    <Class name="org.apache.tez.dag.app.DAGAppMaster"/>
+    <Or>
+      <Field name="context"/>
+      <Field name="currentDAG"/>
+      <Field name="state"/>
+      <Field name="taskSchedulerEventHandler"/>
+      <Field name="versionMismatch"/>
+      <Field name="versionMismatchDiagnostics"/>
+    </Or>
+    <Bug pattern="IS2_INCONSISTENT_SYNC"/>
+  </Match>
+
+  <!-- TEZ-1955 -->
+  <Match>
+    <Class name="org.apache.tez.dag.app.rm.TaskSchedulerEventHandler"/>
+    <Field name="taskScheduler"/>
+    <Bug pattern="IS2_INCONSISTENT_SYNC"/>
+  </Match>
+
+  <!-- TEZ-1956 -->
+  <Match>
+    <Class name="org.apache.tez.dag.app.rm.YarnTaskSchedulerService"/>
+    <Or>
+      <Field name="delayedContainerManager"/>
+      <Field name="heartbeatAtLastPreemption"/>
+      <Field name="localitySchedulingDelay"/>
+      <Field name="preemptionPercentage"/>
+      <Field name="shouldReuseContainers"/>
+    </Or>
+    <Bug pattern="IS2_INCONSISTENT_SYNC"/>
+  </Match>
+
+  <!-- TEZ-1957 -->
+  <Match>
+    <Class name="org.apache.tez.dag.app.DAGAppMaster$DAGAppMasterShutdownHandler"/>
+    <Method name="shutdown" params="boolean" returns="void"/>
+    <Bug pattern="JLM_JSR166_UTILCONCURRENT_MONITORENTER"/>
+  </Match>
+
+  <!-- TEZ-1957 -->
+  <Match>
+    <Class name="org.apache.tez.dag.app.DAGAppMaster$DAGAppMasterShutdownHandler$AMShutdownRunnable"/>
+    <Method name="run"/><Field name="shutdownHandlerRunning"/>
+    <Bug pattern="JLM_JSR166_UTILCONCURRENT_MONITORENTER"/>
+  </Match>
+
+  <!-- TEZ-1957 -->
+  <Match>
+    <Class name="org.apache.tez.dag.app.DAGAppMaster$DAGAppMasterShutdownHook"/>
+    <Method name="run"/><Field name="shutdownHandlerRunning"/>
+    <Bug pattern="JLM_JSR166_UTILCONCURRENT_MONITORENTER"/>
+  </Match>
+
+  <!-- TEZ-1958 -->
+  <Match>
+    <Class name="org.apache.tez.dag.app.rm.LocalTaskSchedulerService$AsyncDelegateRequestHandler"/>
+    <Method name="addDeallocateTaskRequest" params="java.lang.Object" returns="boolean"/>
+    <Bug pattern="JLM_JSR166_UTILCONCURRENT_MONITORENTER"/>
+  </Match>
+
+  <!-- TEZ-1958 -->
+  <Match>
+    <Class name="org.apache.tez.dag.app.rm.LocalTaskSchedulerService$AsyncDelegateRequestHandler"/>
+    <Method name="run"/><Field name="taskRequestQueue"/>
+    <Bug pattern="JLM_JSR166_UTILCONCURRENT_MONITORENTER"/>
+  </Match>
+
+  <!-- TEZ-1959 -->
+  <Match>
+    <Class name="org.apache.tez.dag.app.rm.YarnTaskSchedulerService$DelayedContainerManager"/>
+    <Method name="run"/><Field name="drainedDelayedContainersForTest"/>
+    <Bug pattern="JLM_JSR166_UTILCONCURRENT_MONITORENTER"/>
+  </Match>
+
+  <!-- TEZ-1981 -->
+  <Match>
+    <Class name="org.apache.tez.dag.app.dag.TaskAttempt$TaskAttemptStatus"/>
+    <Field name="id"/>
+    <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD"/>
+  </Match>
+
+  <!-- TEZ-1981 -->
+  <Match>
+    <Class name="org.apache.tez.dag.app.dag.TaskAttempt$TaskAttemptStatus"/>
+    <Field name="state"/>
+    <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD"/>
+  </Match>
+
 </FindBugsFilter>