You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by ma...@apache.org on 2016/02/29 03:08:40 UTC

logging-log4j2 git commit: Make comparators implement Serializable.

Repository: logging-log4j2
Updated Branches:
  refs/heads/master 686b90713 -> f7b53fe82


Make comparators implement Serializable.


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/f7b53fe8
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/f7b53fe8
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/f7b53fe8

Branch: refs/heads/master
Commit: f7b53fe826945b5a59045d81cb44f0d3f1349395
Parents: 686b907
Author: Matt Sicker <bo...@gmail.com>
Authored: Sun Feb 28 20:08:26 2016 -0600
Committer: Matt Sicker <bo...@gmail.com>
Committed: Sun Feb 28 20:08:26 2016 -0600

----------------------------------------------------------------------
 .../appender/rolling/action/PathSortByModificationTime.java    | 6 +++++-
 .../org/apache/logging/log4j/core/config/OrderComparator.java  | 4 +++-
 .../org/apache/logging/log4j/jul/DefaultLevelConverter.java    | 4 +++-
 3 files changed, 11 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/f7b53fe8/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/PathSortByModificationTime.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/PathSortByModificationTime.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/PathSortByModificationTime.java
index 0375c49..d5a91ce 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/PathSortByModificationTime.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/PathSortByModificationTime.java
@@ -17,6 +17,8 @@
 
 package org.apache.logging.log4j.core.appender.rolling.action;
 
+import java.io.Serializable;
+
 import org.apache.logging.log4j.core.config.plugins.Plugin;
 import org.apache.logging.log4j.core.config.plugins.PluginAttribute;
 import org.apache.logging.log4j.core.config.plugins.PluginFactory;
@@ -25,7 +27,9 @@ import org.apache.logging.log4j.core.config.plugins.PluginFactory;
  * {@link PathSorter} that sorts path by their LastModified attribute.
  */
 @Plugin(name = "SortByModificationTime", category = "Core", printObject = true)
-public class PathSortByModificationTime implements PathSorter {
+public class PathSortByModificationTime implements PathSorter, Serializable {
+
+    private static final long serialVersionUID = 1L;
 
     private final boolean recentFirst;
     private final int multiplier;

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/f7b53fe8/log4j-core/src/main/java/org/apache/logging/log4j/core/config/OrderComparator.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/OrderComparator.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/OrderComparator.java
index 5623e38..a3b06fe 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/OrderComparator.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/OrderComparator.java
@@ -16,6 +16,7 @@
  */
 package org.apache.logging.log4j.core.config;
 
+import java.io.Serializable;
 import java.util.Comparator;
 import java.util.Objects;
 
@@ -24,8 +25,9 @@ import java.util.Objects;
  *
  * @since 2.1
  */
-public class OrderComparator implements Comparator<Class<?>> {
+public class OrderComparator implements Comparator<Class<?>>, Serializable {
 
+    private static final long serialVersionUID = 1L;
     private static final Comparator<Class<?>> INSTANCE = new OrderComparator();
 
     /**

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/f7b53fe8/log4j-jul/src/main/java/org/apache/logging/log4j/jul/DefaultLevelConverter.java
----------------------------------------------------------------------
diff --git a/log4j-jul/src/main/java/org/apache/logging/log4j/jul/DefaultLevelConverter.java b/log4j-jul/src/main/java/org/apache/logging/log4j/jul/DefaultLevelConverter.java
index 23ea0f9..adaf4eb 100644
--- a/log4j-jul/src/main/java/org/apache/logging/log4j/jul/DefaultLevelConverter.java
+++ b/log4j-jul/src/main/java/org/apache/logging/log4j/jul/DefaultLevelConverter.java
@@ -17,6 +17,7 @@
 
 package org.apache.logging.log4j.jul;
 
+import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Comparator;
@@ -38,7 +39,8 @@ import org.apache.logging.log4j.Level;
  */
 public class DefaultLevelConverter implements LevelConverter {
 
-    static final class JulLevelComparator implements Comparator<java.util.logging.Level> {
+    static final class JulLevelComparator implements Comparator<java.util.logging.Level>, Serializable {
+        private static final long serialVersionUID = 1L;
         @Override
         public int compare(final java.util.logging.Level level1, final java.util.logging.Level level2) {
             return Integer.compare(level1.intValue(), level2.intValue());