You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "samraHanif0340 (via GitHub)" <gi...@apache.org> on 2024/12/23 12:19:14 UTC
[PR] feat(Sqllab): Enabling selection and copying of columns and rows in sql lab and dataset view [superset]
samraHanif0340 opened a new pull request, #31602:
URL: https://github.com/apache/superset/pull/31602
### SUMMARY
**Problem**
- Currently, the users are not able to copy column headers in Sql Lab results section.
- The table columns and rows are not selectable while viewing the datasets metadata before creation.
**UseCase**
- The copy column name/rows is required to utilise the column names easily while creating the metrics and calculated columns.
**Technical Details**
- [ ] Enable user-select to text in AntTable and VirtualTables in `superset-frontend/src/components/Table/index.tsx` and `superset-frontend/src/components/Table/VirtualTable.tsx`
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**BEFORE**
https://github.com/user-attachments/assets/ed988135-d2ad-4cd5-bfbb-334000511565
**AFTER**
https://github.com/user-attachments/assets/68bdaf00-af7e-492e-a550-b09ef37f7fc5
### TESTING INSTRUCTIONS
- Go to Sql Lab
- Select any relevant database
- Write and execute and sql query
- In the results section, the query results should appear
- Try selecting column from column header content in the results section
- Go to Dataset and create a new dataset
- Select relevant database,schema, table. A dataset metadata view will get generated
- Try selecting the columns or rows from the table view
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(Sqllab): Enabling selection and copying of columns and rows in sql lab and dataset view [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #31602:
URL: https://github.com/apache/superset/pull/31602#issuecomment-2562735925
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(Sqllab): Enabling selection and copying of columns and rows in sql lab and dataset view [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #31602:
URL: https://github.com/apache/superset/pull/31602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(Sqllab): Enabling selection and copying of columns and rows in sql lab and dataset view [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #31602:
URL: https://github.com/apache/superset/pull/31602#discussion_r1902232693
##########
superset-frontend/src/components/Table/VirtualTable.tsx:
##########
@@ -53,7 +53,7 @@ const StyledTable = styled(AntTable)<{ height?: number }>(
th.ant-table-cell {
font-weight: ${theme.typography.weights.bold};
color: ${theme.colors.grayscale.dark1};
- user-select: none;
Review Comment:
Is it possible to just _remove_ these three `user-select: none` statements rather than setting them to `text`? The less CSS, the merrier :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(Sqllab): Enabling selection and copying of columns and rows in sql lab and dataset view [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31602:
URL: https://github.com/apache/superset/pull/31602#issuecomment-2562736331
@sfirke Processing your ephemeral environment request [here](https://github.com/apache/superset/actions/runs/12504502739).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(Sqllab): Enabling selection and copying of columns and rows in sql lab and dataset view [superset]
Posted by "samraHanif0340 (via GitHub)" <gi...@apache.org>.
samraHanif0340 commented on code in PR #31602:
URL: https://github.com/apache/superset/pull/31602#discussion_r1904375777
##########
superset-frontend/src/components/Table/VirtualTable.tsx:
##########
@@ -53,7 +53,7 @@ const StyledTable = styled(AntTable)<{ height?: number }>(
th.ant-table-cell {
font-weight: ${theme.typography.weights.bold};
color: ${theme.colors.grayscale.dark1};
- user-select: none;
Review Comment:
Incorporated and tested :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(Sqllab): Enabling selection and copying of columns and rows in sql lab and dataset view [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31602:
URL: https://github.com/apache/superset/pull/31602#issuecomment-2562750717
@sfirke Ephemeral environment spinning up at http://34.219.200.53:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(Sqllab): Enabling selection and copying of columns and rows in sql lab and dataset view [superset]
Posted by "samraHanif0340 (via GitHub)" <gi...@apache.org>.
samraHanif0340 commented on code in PR #31602:
URL: https://github.com/apache/superset/pull/31602#discussion_r1904375421
##########
superset-frontend/src/components/Table/VirtualTable.tsx:
##########
@@ -53,7 +53,7 @@ const StyledTable = styled(AntTable)<{ height?: number }>(
th.ant-table-cell {
font-weight: ${theme.typography.weights.bold};
color: ${theme.colors.grayscale.dark1};
- user-select: none;
Review Comment:
Makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(Sqllab): Enabling selection and copying of columns and rows in sql lab and dataset view [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #31602:
URL: https://github.com/apache/superset/pull/31602#discussion_r1905882166
##########
superset-frontend/src/components/Table/VirtualTable.tsx:
##########
@@ -53,7 +53,7 @@ const StyledTable = styled(AntTable)<{ height?: number }>(
th.ant-table-cell {
font-weight: ${theme.typography.weights.bold};
color: ${theme.colors.grayscale.dark1};
- user-select: none;
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org