You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/12/07 19:07:26 UTC
[GitHub] [geode] jdeppe-pivotal opened a new pull request #7171: GEODE-9870: Avoid Radish MOVED error during flushAll in AuthWhileServersRestartDUnitTest
jdeppe-pivotal opened a new pull request #7171:
URL: https://github.com/apache/geode/pull/7171
- Since servers have been stopped and restarted, as part of the test,
buckets may be moving. Occasionally this may still be the case when
the test is done and flushAll is cleaning up. To avoid that, make sure
that everything is rebalanced before flushAll is called.
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7171: GEODE-9870: Avoid Radish MOVED error during flushAll in AuthWhileServersRestartDUnitTest
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #7171:
URL: https://github.com/apache/geode/pull/7171#discussion_r764503814
##########
File path: geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/executor/auth/AuthWhileServersRestartDUnitTest.java
##########
@@ -50,6 +50,7 @@
@ClassRule
public static ExecutorServiceRule executor = new ExecutorServiceRule();
+ private static MemberVM server1;
Review comment:
Thanks. I was using it but that changed... It's gone now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] ringles commented on a change in pull request #7171: GEODE-9870: Avoid Radish MOVED error during flushAll in AuthWhileServersRestartDUnitTest
Posted by GitBox <gi...@apache.org>.
ringles commented on a change in pull request #7171:
URL: https://github.com/apache/geode/pull/7171#discussion_r764373856
##########
File path: geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/executor/auth/AuthWhileServersRestartDUnitTest.java
##########
@@ -50,6 +50,7 @@
@ClassRule
public static ExecutorServiceRule executor = new ExecutorServiceRule();
+ private static MemberVM server1;
Review comment:
Sorry, where is this variable used? I see it being set, but I don't see where the value gets used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal merged pull request #7171: GEODE-9870: Avoid Radish MOVED error during flushAll in AuthWhileServersRestartDUnitTest
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal merged pull request #7171:
URL: https://github.com/apache/geode/pull/7171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org