You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/14 14:20:08 UTC

[GitHub] [flink] SteNicholas opened a new pull request #14652: [FLINK-20953][canal][json] Option 'canal-json.database.include' and 'canal-json.table.include' support regular expression

SteNicholas opened a new pull request #14652:
URL: https://github.com/apache/flink/pull/14652


   ## What is the purpose of the change
   
   *Currently Canal format option 'canal-json.database.include' and 'canal-json.table.include' don't support regular expression to match. It's necessary to use regular expression to match the field 'database' and 'table' of Canal binlog record.*
   
   ## Brief change log
   
     - *`CanalJsonDeserializationSchema` matches the field 'database' and 'table' of Canal binlog message using regular expression for Canal format option 'canal-json.database.include' and 'canal-json.table.include'.*
   
   ## Verifying this change
   
     - *`CanalJsonSerDeSchemaTest` modifies the `testFilteringTables` test case to use regular expression for option 'canal-json.database.include' and 'canal-json.table.include' to verify the regular matching of the field 'database' and 'table' of Canal binlog record.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14652: [FLINK-20953][canal][json] Option 'canal-json.database.include' and 'canal-json.table.include' support regular expression

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14652:
URL: https://github.com/apache/flink/pull/14652#issuecomment-760296852


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12069",
       "triggerID" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "15d8fb2352242415cf503ac44a0025d63933de3e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12084",
       "triggerID" : "15d8fb2352242415cf503ac44a0025d63933de3e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "72601d907bc02eb3b74499a36f15f713406d911c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12088",
       "triggerID" : "72601d907bc02eb3b74499a36f15f713406d911c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "307e51f7f0aec480cd035bee12764f8ec10be2d7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "307e51f7f0aec480cd035bee12764f8ec10be2d7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 72601d907bc02eb3b74499a36f15f713406d911c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12088) 
   * 307e51f7f0aec480cd035bee12764f8ec10be2d7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14652: [FLINK-20953][canal][json] Option 'canal-json.database.include' and 'canal-json.table.include' support regular expression

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14652:
URL: https://github.com/apache/flink/pull/14652#issuecomment-760296852


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12069",
       "triggerID" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "15d8fb2352242415cf503ac44a0025d63933de3e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12084",
       "triggerID" : "15d8fb2352242415cf503ac44a0025d63933de3e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "72601d907bc02eb3b74499a36f15f713406d911c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12088",
       "triggerID" : "72601d907bc02eb3b74499a36f15f713406d911c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "307e51f7f0aec480cd035bee12764f8ec10be2d7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "307e51f7f0aec480cd035bee12764f8ec10be2d7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f3d72bd76a56f59b9c5cde33d4722f5f67ef815d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f3d72bd76a56f59b9c5cde33d4722f5f67ef815d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 72601d907bc02eb3b74499a36f15f713406d911c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12088) 
   * 307e51f7f0aec480cd035bee12764f8ec10be2d7 UNKNOWN
   * f3d72bd76a56f59b9c5cde33d4722f5f67ef815d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14652: [FLINK-20953][canal][json] Option 'canal-json.database.include' and 'canal-json.table.include' support regular expression

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14652:
URL: https://github.com/apache/flink/pull/14652#issuecomment-760296852


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12069",
       "triggerID" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "15d8fb2352242415cf503ac44a0025d63933de3e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12084",
       "triggerID" : "15d8fb2352242415cf503ac44a0025d63933de3e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "72601d907bc02eb3b74499a36f15f713406d911c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12088",
       "triggerID" : "72601d907bc02eb3b74499a36f15f713406d911c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 72601d907bc02eb3b74499a36f15f713406d911c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12088) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14652: [FLINK-20953][canal][json] Option 'canal-json.database.include' and 'canal-json.table.include' support regular expression

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14652:
URL: https://github.com/apache/flink/pull/14652#issuecomment-760296852


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12069",
       "triggerID" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 09fd94b57b23a20ddd835ce48ffe7932a276d3b7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12069) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14652: [FLINK-20953][canal][json] Option 'canal-json.database.include' and 'canal-json.table.include' support regular expression

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14652:
URL: https://github.com/apache/flink/pull/14652#issuecomment-760227077


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit f3d72bd76a56f59b9c5cde33d4722f5f67ef815d (Fri May 28 07:08:59 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14652: [FLINK-20953][canal][json] Option 'canal-json.database.include' and 'canal-json.table.include' support regular expression

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14652:
URL: https://github.com/apache/flink/pull/14652#issuecomment-760227077


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 09fd94b57b23a20ddd835ce48ffe7932a276d3b7 (Thu Jan 14 14:21:48 UTC 2021)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on a change in pull request #14652: [FLINK-20953][canal][json] Option 'canal-json.database.include' and 'canal-json.table.include' support regular expression

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14652:
URL: https://github.com/apache/flink/pull/14652#discussion_r557431574



##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/canal/CanalJsonDeserializationSchema.java
##########
@@ -197,12 +198,12 @@ public void deserialize(@Nullable byte[] message, Collector<RowData> out) throws
         try {
             final JsonNode root = jsonDeserializer.deserializeToJsonNode(message);
             if (database != null) {
-                if (!database.equals(root.get(ReadableMetadata.DATABASE.key).asText())) {
+                if (!Pattern.matches(database, root.get(ReadableMetadata.DATABASE.key).asText())) {

Review comment:
       We should reuse the pattern. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14652: [FLINK-20953][canal][json] Option 'canal-json.database.include' and 'canal-json.table.include' support regular expression

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14652:
URL: https://github.com/apache/flink/pull/14652#issuecomment-760296852


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12069",
       "triggerID" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "15d8fb2352242415cf503ac44a0025d63933de3e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12084",
       "triggerID" : "15d8fb2352242415cf503ac44a0025d63933de3e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "72601d907bc02eb3b74499a36f15f713406d911c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12088",
       "triggerID" : "72601d907bc02eb3b74499a36f15f713406d911c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "307e51f7f0aec480cd035bee12764f8ec10be2d7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "307e51f7f0aec480cd035bee12764f8ec10be2d7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f3d72bd76a56f59b9c5cde33d4722f5f67ef815d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12103",
       "triggerID" : "f3d72bd76a56f59b9c5cde33d4722f5f67ef815d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 307e51f7f0aec480cd035bee12764f8ec10be2d7 UNKNOWN
   * f3d72bd76a56f59b9c5cde33d4722f5f67ef815d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12103) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] SteNicholas commented on pull request #14652: [FLINK-20953][canal][json] Option 'canal-json.database.include' and 'canal-json.table.include' support regular expression

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14652:
URL: https://github.com/apache/flink/pull/14652#issuecomment-760586892


   @wuchong, I have reused the pattern for the specific database and table. Please review again for this minor change. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14652: [FLINK-20953][canal][json] Option 'canal-json.database.include' and 'canal-json.table.include' support regular expression

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14652:
URL: https://github.com/apache/flink/pull/14652#issuecomment-760296852


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 09fd94b57b23a20ddd835ce48ffe7932a276d3b7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14652: [FLINK-20953][canal][json] Option 'canal-json.database.include' and 'canal-json.table.include' support regular expression

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14652:
URL: https://github.com/apache/flink/pull/14652#issuecomment-760296852


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12069",
       "triggerID" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "15d8fb2352242415cf503ac44a0025d63933de3e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12084",
       "triggerID" : "15d8fb2352242415cf503ac44a0025d63933de3e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "72601d907bc02eb3b74499a36f15f713406d911c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "72601d907bc02eb3b74499a36f15f713406d911c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 15d8fb2352242415cf503ac44a0025d63933de3e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12084) 
   * 72601d907bc02eb3b74499a36f15f713406d911c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on a change in pull request #14652: [FLINK-20953][canal][json] Option 'canal-json.database.include' and 'canal-json.table.include' support regular expression

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14652:
URL: https://github.com/apache/flink/pull/14652#discussion_r557955645



##########
File path: docs/dev/table/connectors/formats/canal.md
##########
@@ -292,14 +292,14 @@ Format Options
       <td>optional</td>
       <td style="word-wrap: break-word;">(none)</td>
       <td>String</td>
-      <td>Only read changelog rows which match the specific database (by comparing the "database" meta field in the Canal record).</td>
+      <td>Only read changelog rows which match the specific database (by regular matching the "database" meta field in the Canal record).</td>

Review comment:
       What do you think about improving the description to the following?
   
   ```
   An optional regular expression to only read the speicifc databases changelog rows by regular matching the "database" meta field in the Canal record. The pattern string is compatible with Java's <a href="https://docs.oracle.com/javase/8/docs/api/java/util/regex/Pattern.html">Pattern</a>.
   ```
   
   Would be great if you can update the description in `org.apache.flink.formats.json.canal.CanalJsonOptions#DATABASE_INCLUDE`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14652: [FLINK-20953][canal][json] Option 'canal-json.database.include' and 'canal-json.table.include' support regular expression

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14652:
URL: https://github.com/apache/flink/pull/14652#issuecomment-760296852


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12069",
       "triggerID" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 09fd94b57b23a20ddd835ce48ffe7932a276d3b7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12069) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong merged pull request #14652: [FLINK-20953][canal][json] Option 'canal-json.database.include' and 'canal-json.table.include' support regular expression

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14652:
URL: https://github.com/apache/flink/pull/14652


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14652: [FLINK-20953][canal][json] Option 'canal-json.database.include' and 'canal-json.table.include' support regular expression

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14652:
URL: https://github.com/apache/flink/pull/14652#issuecomment-760296852


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12069",
       "triggerID" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "15d8fb2352242415cf503ac44a0025d63933de3e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12084",
       "triggerID" : "15d8fb2352242415cf503ac44a0025d63933de3e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "72601d907bc02eb3b74499a36f15f713406d911c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12088",
       "triggerID" : "72601d907bc02eb3b74499a36f15f713406d911c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "307e51f7f0aec480cd035bee12764f8ec10be2d7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "307e51f7f0aec480cd035bee12764f8ec10be2d7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f3d72bd76a56f59b9c5cde33d4722f5f67ef815d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12103",
       "triggerID" : "f3d72bd76a56f59b9c5cde33d4722f5f67ef815d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 72601d907bc02eb3b74499a36f15f713406d911c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12088) 
   * 307e51f7f0aec480cd035bee12764f8ec10be2d7 UNKNOWN
   * f3d72bd76a56f59b9c5cde33d4722f5f67ef815d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12103) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14652: [FLINK-20953][canal][json] Option 'canal-json.database.include' and 'canal-json.table.include' support regular expression

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14652:
URL: https://github.com/apache/flink/pull/14652#issuecomment-760296852


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12069",
       "triggerID" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "15d8fb2352242415cf503ac44a0025d63933de3e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12084",
       "triggerID" : "15d8fb2352242415cf503ac44a0025d63933de3e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 15d8fb2352242415cf503ac44a0025d63933de3e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12084) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14652: [FLINK-20953][canal][json] Option 'canal-json.database.include' and 'canal-json.table.include' support regular expression

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14652:
URL: https://github.com/apache/flink/pull/14652#issuecomment-760296852


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12069",
       "triggerID" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "15d8fb2352242415cf503ac44a0025d63933de3e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12084",
       "triggerID" : "15d8fb2352242415cf503ac44a0025d63933de3e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "72601d907bc02eb3b74499a36f15f713406d911c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12088",
       "triggerID" : "72601d907bc02eb3b74499a36f15f713406d911c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 15d8fb2352242415cf503ac44a0025d63933de3e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12084) 
   * 72601d907bc02eb3b74499a36f15f713406d911c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12088) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14652: [FLINK-20953][canal][json] Option 'canal-json.database.include' and 'canal-json.table.include' support regular expression

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14652:
URL: https://github.com/apache/flink/pull/14652#issuecomment-760296852


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12069",
       "triggerID" : "09fd94b57b23a20ddd835ce48ffe7932a276d3b7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "15d8fb2352242415cf503ac44a0025d63933de3e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "15d8fb2352242415cf503ac44a0025d63933de3e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 09fd94b57b23a20ddd835ce48ffe7932a276d3b7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12069) 
   * 15d8fb2352242415cf503ac44a0025d63933de3e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org