You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Scott Chen (Created) (JIRA)" <ji...@apache.org> on 2012/01/14 23:48:40 UTC

[jira] [Created] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
-------------------------------------------------------------------------------------------

                 Key: HBASE-5201
                 URL: https://issues.apache.org/jira/browse/HBASE-5201
             Project: HBase
          Issue Type: Improvement
          Components: regionserver
            Reporter: Scott Chen
            Assignee: Scott Chen


TThreadedSelectorServer is good for RPC-heavy situation because IO are not limit to on CPU. See
https://issues.apache.org/jira/browse/Thrift-1167
I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).

There are lots of repeat codes in ThriftServer and HRegionThriftServer.
These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5201) Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189008#comment-13189008 ] 

Hudson commented on HBASE-5201:
-------------------------------

Integrated in HBase-TRUNK #2639 (See [https://builds.apache.org/job/HBase-TRUNK/2639/])
    HBASE-5201 Add new files
HBASE-5201 Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer (Scott Chen)

tedyu : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/HThreadedSelectorServerArgs.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java

tedyu : 
Files : 
* /hbase/trunk/pom.xml
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java

                
> Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201-v4.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Posted by "Scott Chen (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Chen updated HBASE-5201:
------------------------------

    Status: Patch Available  (was: In Progress)
    
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201-v4.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5201) Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer

Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186600#comment-13186600 ] 

Zhihong Yu commented on HBASE-5201:
-----------------------------------

@Scott:
There're several new config parameters introduced by your patch. When you have time, please document them in Release Notes section.

Thanks
                
> Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201-v4.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Posted by "Scott Chen (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186551#comment-13186551 ] 

Scott Chen commented on HBASE-5201:
-----------------------------------

@Ted: Thanks. I will do "Submit Patch".
                
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5201) Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer

Posted by "Scott Chen (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Chen updated HBASE-5201:
------------------------------

    Release Note: 
New config parameters:

"hbase.thrift.selector.threads"  Number of selector threads for reading and writing socket
"hbase.thrift.worker.threads"  Number of threads for processing the thrift calls
"hbase.thrift.stop.timeout.seconds"  Time to wait for server to stop gracefully
"hbase.thrift.accept.queue.size.per.selector"  Maximum number of accepted elements per selector
"hbase.thrift.accept.policy" The strategy for handling new accepted connections

  was:
New config parameters:

"hbase.thrift.selector.threads"  Number of selector threads for reading and writing socket
"hbase.thrift.worker.threads"  Number of threads for processing the thrift calls
"hbase.thrift.stop.timeout.seconds"  Time to wait for server to stop gracefully
"hbase.thrift.accept.queue.size.per.selector"  Maximum number of accepted elements per selector

    
> Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201-v4.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Posted by "Scott Chen (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186384#comment-13186384 ] 

Scott Chen commented on HBASE-5201:
-----------------------------------

Zhihong: Here is the phabricator link:
https://reviews.facebook.net/D1257
                
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Posted by "Scott Chen (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186460#comment-13186460 ] 

Scott Chen commented on HBASE-5201:
-----------------------------------

Thanks, Dhruba!
                
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Posted by "Scott Chen (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186371#comment-13186371 ] 

Scott Chen commented on HBASE-5201:
-----------------------------------

Cool. I will use 0.8.0 instead. That is better.
                
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Posted by "Scott Chen (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Chen updated HBASE-5201:
------------------------------

    Attachment: HBASE-5201-v3.txt

Some minor renaming in HBASE-5201-v3.txt
                
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Posted by "dhruba borthakur (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186416#comment-13186416 ] 

dhruba borthakur commented on HBASE-5201:
-----------------------------------------

scot; once u check out a workspace, pl run mvn -Darc initialize
this will create configurations in such a way that a "arc diff" will upload the diff to the right place.
                
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5201) Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer

Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Yu updated HBASE-5201:
------------------------------

    Release Note: 
New config parameters:

"hbase.thrift.selector.threads"  Number of selector threads for reading and writing socket
"hbase.thrift.worker.threads"  Number of threads for processing the thrift calls
"hbase.thrift.stop.timeout.seconds"  Time to wait for server to stop gracefully
"hbase.thrift.accept.queue.size.per.selector"  Maximum number of accepted elements per selector

Integrated to TRUNK.

Thanks for the patch Scott
                
> Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201-v4.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186577#comment-13186577 ] 

Zhihong Yu commented on HBASE-5201:
-----------------------------------

Patch v4 looks good. 
Will integrate on Tuesday. 

Thanks Scott for working over the weekend. 
                
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201-v4.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Posted by "Scott Chen (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Chen updated HBASE-5201:
------------------------------

    Attachment: HBASE-5201-v4.txt
    
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201-v4.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5201) Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer

Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Yu updated HBASE-5201:
------------------------------

    Hadoop Flags: Reviewed
         Summary: Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer  (was: Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer)
    
> Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201-v4.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5201) Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer

Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Yu updated HBASE-5201:
------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)
    
> Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201-v4.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186391#comment-13186391 ] 

Zhihong Yu commented on HBASE-5201:
-----------------------------------

When patch v4 comes out, please submit to Hadoop QA for test suite run.
                
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5201) Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer

Posted by "Scott Chen (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188102#comment-13188102 ] 

Scott Chen commented on HBASE-5201:
-----------------------------------

Thanks for the help Zhihong.
I will add the documentation soon.
                
> Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201-v4.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186375#comment-13186375 ] 

Zhihong Yu commented on HBASE-5201:
-----------------------------------

Patch v2 is still big. 
Can you publish it on review board ?
                
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186370#comment-13186370 ] 

Zhihong Yu commented on HBASE-5201:
-----------------------------------

I tried the following change on pom.xml and trunk compiles:
{code}
@@ -887,7 +887,7 @@
     <protobuf.version>2.4.0a</protobuf.version>
     <slf4j.version>1.5.8</slf4j.version><!-- newer version available -->
     <stax-api.version>1.0.1</stax-api.version>
-    <thrift.version>0.7.0</thrift.version>
+    <thrift.version>0.8.0</thrift.version>
     <zookeeper.version>3.4.2</zookeeper.version>
     <hadoop-snappy.version>0.0.1-SNAPSHOT</hadoop-snappy.version>
{code}
We should reuse classes from libthrift-0.8.0.jar:
{code}
  2977 Sat Nov 26 17:05:38 PST 2011 org/apache/thrift/server/AbstractNonblockingServer.class
 18666 Sat Nov 26 14:00:40 PST 2011 org/apache/thrift/server/AbstractNonblockingServer.java
{code}
Please incorporate the change in pom.xml and submit a new patch.

Thanks
                
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Posted by "Scott Chen (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186377#comment-13186377 ] 

Scott Chen commented on HBASE-5201:
-----------------------------------

Yeah. I am trying to do that. I am n00b to this.
Got some error saying cannot find .arc_jira_lib.
Do you happend to know how to solve this problem?

{code}
$arc diff
Usage Exception: Failed to load library "arclib" at location ".arc_jira_lib". Please check the "phutil_libraries" setting in your .arcconfig file. Refer to page http://phabricator.com/docs/arcanist/article/Setting_Up_.arcconfig.html for more info.
{code}
                
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Posted by "Scott Chen (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Chen updated HBASE-5201:
------------------------------

    Attachment: HBASE-5201.txt
    
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>         Attachments: HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limit to on CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Work started] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Posted by "Scott Chen (Work started) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on HBASE-5201 started by Scott Chen.

> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186574#comment-13186574 ] 

Hadoop QA commented on HBASE-5201:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12510635/HBASE-5201-v4.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated -145 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 82 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.mapreduce.TestImportTsv
                  org.apache.hadoop.hbase.mapred.TestTableMapReduce
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
                  org.apache.hadoop.hbase.master.TestSplitLogManager

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/764//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/764//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/764//console

This message is automatically generated.
                
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201-v4.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Posted by "Scott Chen (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Chen updated HBASE-5201:
------------------------------

    Attachment: HBASE-5201-v2.txt

Reuse classes in thrift-0.8.0.
                
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186520#comment-13186520 ] 

Ted Yu commented on HBASE-5201:
-------------------------------

@Scott:
I think you need to mark your work complete before seeing the 'Submit Patch' button.
After you click 'Submit Patch', future attachments would be picked up by Hadoop QA.
                
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5201) Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer

Posted by "Scott Chen (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188445#comment-13188445 ] 

Scott Chen commented on HBASE-5201:
-----------------------------------

Added one more config to the release note.
                
> Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201-v4.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Yu updated HBASE-5201:
------------------------------

      Description: 
TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
https://issues.apache.org/jira/browse/Thrift-1167
I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).

There are lots of repeat codes in ThriftServer and HRegionThriftServer.
These codes are now moved to a Runnable called ThriftServerRunner.

  was:
TThreadedSelectorServer is good for RPC-heavy situation because IO are not limit to on CPU. See
https://issues.apache.org/jira/browse/Thrift-1167
I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).

There are lots of repeat codes in ThriftServer and HRegionThriftServer.
These codes are now moved to a Runnable called ThriftServerRunner.

    Fix Version/s: 0.94.0
    
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer

Posted by "Scott Chen (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186363#comment-13186363 ] 

Scott Chen commented on HBASE-5201:
-----------------------------------

TThreadedSelectorServer is available in thrift-0.8.0.
I am not sure about the policy of upgrading thrift in this project.
So I just ported the source codes from thrift trunk.

                
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5201) Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188385#comment-13188385 ] 

Hudson commented on HBASE-5201:
-------------------------------

Integrated in HBase-TRUNK-security #81 (See [https://builds.apache.org/job/HBase-TRUNK-security/81/])
    HBASE-5201 Add new files
HBASE-5201 Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer (Scott Chen)

tedyu : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/HThreadedSelectorServerArgs.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java

tedyu : 
Files : 
* /hbase/trunk/pom.xml
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java

                
> Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5201
>                 URL: https://issues.apache.org/jira/browse/HBASE-5201
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201-v4.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira