You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/08 21:20:19 UTC
[GitHub] [skywalking-eyes] HungryJoe opened a new pull request #77: Added .pre-commit-hooks.yaml
HungryJoe opened a new pull request #77:
URL: https://github.com/apache/skywalking-eyes/pull/77
This addition allows users of the [pre-commit](https://pre-commit.com/) Git hook management tool to use Skywalking Eyes' `license-eyes header fix` command to automate fixing their license headers at regular points in the development lifecycle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] HungryJoe commented on pull request #77: Added .pre-commit-hooks.yaml
Posted by GitBox <gi...@apache.org>.
HungryJoe commented on pull request #77:
URL: https://github.com/apache/skywalking-eyes/pull/77#issuecomment-941575636
Adding a new Skywalking Eyes command that installs `license-eye header fix` as a Git hook seems like a perfectly workable solution to me. However, I'm not familiar with Go, or this code-base, so I would be of little use in implementing it. That being said, if someone else wants to make another PR for it, I'd be grateful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] HungryJoe closed pull request #77: Added .pre-commit-hooks.yaml
Posted by GitBox <gi...@apache.org>.
HungryJoe closed pull request #77:
URL: https://github.com/apache/skywalking-eyes/pull/77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 edited a comment on pull request #77: Added .pre-commit-hooks.yaml
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on pull request #77:
URL: https://github.com/apache/skywalking-eyes/pull/77#issuecomment-939236082
[pre-commit](https://pre-commit.com/) requires third-party dependency to be installed in developers machine, which I don't think is a good idea, can we just use the native pre-commit hook provided by git? @HungryJoe , also, this file only takes effects in this repo, I'd rather we provide a new command like `skywalking-eyes header git-hook` to automatically create the needed files into the git codebase for any project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] HungryJoe closed pull request #77: Added .pre-commit-hooks.yaml
Posted by GitBox <gi...@apache.org>.
HungryJoe closed pull request #77:
URL: https://github.com/apache/skywalking-eyes/pull/77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 commented on pull request #77: Added .pre-commit-hooks.yaml
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #77:
URL: https://github.com/apache/skywalking-eyes/pull/77#issuecomment-939236082
[pre-commit](https://pre-commit.com/) requires third-party dependency to be installed in developers machine, which I don't think is a good idea, can we just use the native pre-commit hook provided by git? @HungryJoe , also, this file only takes effects in this repo, I'd rather we provide a new command like `skywalking-eyes header git-hook` to automatically create the needed files into the git codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] HungryJoe commented on pull request #77: Added .pre-commit-hooks.yaml
Posted by GitBox <gi...@apache.org>.
HungryJoe commented on pull request #77:
URL: https://github.com/apache/skywalking-eyes/pull/77#issuecomment-941575636
Adding a new Skywalking Eyes command that installs `license-eye header fix` as a Git hook seems like a perfectly workable solution to me. However, I'm not familiar with Go, or this code-base, so I would be of little use in implementing it. That being said, if someone else wants to make another PR for it, I'd be grateful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] HungryJoe edited a comment on pull request #77: Added .pre-commit-hooks.yaml
Posted by GitBox <gi...@apache.org>.
HungryJoe edited a comment on pull request #77:
URL: https://github.com/apache/skywalking-eyes/pull/77#issuecomment-941575636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] HungryJoe edited a comment on pull request #77: Added .pre-commit-hooks.yaml
Posted by GitBox <gi...@apache.org>.
HungryJoe edited a comment on pull request #77:
URL: https://github.com/apache/skywalking-eyes/pull/77#issuecomment-941575636
I understand your desire @kezhenxu94 to stay away from unnecessary third-party dependencies, and adding a new Skywalking Eyes command that installs `license-eye header fix` as a Git hook seems like a perfectly workable solution to me. However, I'm not familiar with Go, or this code-base, so I would be of little use in implementing it. That being said, if someone else wants to make another PR for it, I'd be grateful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 commented on pull request #77: Added .pre-commit-hooks.yaml
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #77:
URL: https://github.com/apache/skywalking-eyes/pull/77#issuecomment-941048472
@HungryJoe any update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] wu-sheng commented on pull request #77: Added .pre-commit-hooks.yaml
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #77:
URL: https://github.com/apache/skywalking-eyes/pull/77#issuecomment-939164926
Please add document about how to use this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] HungryJoe edited a comment on pull request #77: Added .pre-commit-hooks.yaml
Posted by GitBox <gi...@apache.org>.
HungryJoe edited a comment on pull request #77:
URL: https://github.com/apache/skywalking-eyes/pull/77#issuecomment-941575636
Adding a new Skywalking Eyes command that installs `license-eye header fix` as a Git hook seems like a perfectly workable solution to me, and I understand your desire @kezhenxu94 to stay away from unnecessary third-party dependencies. However, I'm not familiar with Go, or this code-base, so I would be of little use in implementing it. That being said, if someone else wants to make another PR for it, I'd be grateful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org