You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/13 15:15:12 UTC

[GitHub] [flink] GJL commented on a change in pull request #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest

GJL commented on a change in pull request #10814: [FLINK-15434][Tests]Fix unstable tests in JobMasterTest
URL: https://github.com/apache/flink/pull/10814#discussion_r365847555
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterTest.java
 ##########
 @@ -708,7 +708,8 @@ public void testRestoringFromSavepoint() throws Exception {
 			configuration,
 			jobGraph,
 			haServices,
-			new TestingJobManagerSharedServicesBuilder().build());
+			new TestingJobManagerSharedServicesBuilder().build(),
+			heartbeatServices);
 
 Review comment:
   I think strictly speaking the heartbeat timeout doesn't matter here because we are not starting the JobMaster (only invoking the constructor).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services