You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2026/06/22 22:54:38 UTC
[PR] refactor: share Spark 4.1+ shim sources to remove duplication [datafusion-comet]
andygrove opened a new pull request, #4710:
URL: https://github.com/apache/datafusion-comet/pull/4710
## Which issue does this PR close?
N/A
## Rationale for this change
The per-minor shim folders `spark-4.1` and `spark-4.2` each carried byte-identical copies of four files, so every change had to be made twice and could drift.
## What changes are included in this PR?
- Add a new source root `spark/src/main/spark-4.1+` shared by the Spark 4.1 and 4.2 profiles via a new `shims.minorPlusVerSrc` Maven property.
- Move the four shared shims (`ShimPrepareExecutedPlan`, `CometInternalRowShim`, `ShimCometUnionExec`, `CometExprShim`) into it. The 4.1 and 4.2 copies of `CometExprShim` were identical apart from comment wording, now made version-neutral.
- The property defaults to an empty placeholder (`spark-none`), so Spark 4.0 and the 3.x profiles are unaffected.
## How are these changes tested?
`test-compile` passes for the `spark-4.0`, `spark-4.1`, `spark-4.2`, and `spark-3.5` profiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: share Spark 4.1+ shim sources to remove duplication [datafusion-comet]
Posted by "mbutrovich (via GitHub)" <gi...@apache.org>.
mbutrovich merged PR #4710:
URL: https://github.com/apache/datafusion-comet/pull/4710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org