You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "dataroaring (via GitHub)" <gi...@apache.org> on 2024/06/07 03:54:15 UTC

[PR] [fix](thirdparty) patch libevent to enable keepalive on tcp [doris]

dataroaring opened a new pull request, #36026:
URL: https://github.com/apache/doris/pull/36026

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](thirdparty) patch libevent to enable keepalive on tcp [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #36026:
URL: https://github.com/apache/doris/pull/36026


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](thirdparty) patch libevent to enable keepalive on tcp [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36026:
URL: https://github.com/apache/doris/pull/36026#issuecomment-2156097425

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 172882 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 7527535c83b002772aec43b6fccae205daab8e43, data reload: false
   
   query1	942	364	366	364
   query2	6427	2445	2506	2445
   query3	6638	204	205	204
   query4	19278	17316	17450	17316
   query5	3587	473	441	441
   query6	241	159	156	156
   query7	4586	287	291	287
   query8	319	302	294	294
   query9	8480	2399	2373	2373
   query10	557	299	297	297
   query11	10506	10040	10037	10037
   query12	115	83	81	81
   query13	1632	369	359	359
   query14	9311	7035	7553	7035
   query15	228	183	194	183
   query16	7724	259	255	255
   query17	1777	535	519	519
   query18	1943	266	273	266
   query19	203	153	147	147
   query20	87	83	80	80
   query21	205	127	122	122
   query22	4416	4095	3915	3915
   query23	33709	33315	33783	33315
   query24	10649	2805	2839	2805
   query25	594	374	353	353
   query26	707	162	155	155
   query27	2296	318	314	314
   query28	6052	2102	2083	2083
   query29	890	613	605	605
   query30	250	154	153	153
   query31	967	766	759	759
   query32	89	55	54	54
   query33	658	280	270	270
   query34	883	480	475	475
   query35	738	639	661	639
   query36	1104	956	999	956
   query37	142	77	72	72
   query38	2910	2822	2802	2802
   query39	898	855	833	833
   query40	220	128	127	127
   query41	52	55	50	50
   query42	106	102	108	102
   query43	641	557	548	548
   query44	1091	713	718	713
   query45	195	160	166	160
   query46	1077	714	713	713
   query47	1803	1742	1737	1737
   query48	354	307	299	299
   query49	841	395	421	395
   query50	753	374	382	374
   query51	6794	6760	6632	6632
   query52	104	88	96	88
   query53	367	306	287	287
   query54	882	443	451	443
   query55	74	73	74	73
   query56	290	271	292	271
   query57	1105	1060	1055	1055
   query58	254	285	264	264
   query59	3583	3257	3409	3257
   query60	302	283	295	283
   query61	111	106	105	105
   query62	611	443	450	443
   query63	320	281	289	281
   query64	8564	2302	1808	1808
   query65	3187	3129	3108	3108
   query66	756	342	338	338
   query67	15391	15006	14776	14776
   query68	4530	530	540	530
   query69	578	401	337	337
   query70	1171	1144	1074	1074
   query71	424	273	276	273
   query72	8424	5796	5342	5342
   query73	736	319	318	318
   query74	5920	5375	5477	5375
   query75	3382	2646	2653	2646
   query76	2357	955	888	888
   query77	505	301	295	295
   query78	10638	10027	9798	9798
   query79	2955	507	515	507
   query80	2116	475	465	465
   query81	563	224	237	224
   query82	743	105	99	99
   query83	322	170	159	159
   query84	275	90	82	82
   query85	2039	277	260	260
   query86	497	319	310	310
   query87	3269	3079	3089	3079
   query88	3875	2301	2316	2301
   query89	489	374	388	374
   query90	1861	185	188	185
   query91	128	95	96	95
   query92	62	49	49	49
   query93	4615	505	501	501
   query94	1283	180	182	180
   query95	402	300	304	300
   query96	596	262	258	258
   query97	3173	2991	3010	2991
   query98	211	202	192	192
   query99	1185	862	846	846
   Total cold run time: 271890 ms
   Total hot run time: 172882 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](thirdparty) patch libevent to enable keepalive on tcp [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36026:
URL: https://github.com/apache/doris/pull/36026#issuecomment-2156094177

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 39217 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 7527535c83b002772aec43b6fccae205daab8e43, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17599	4301	4212	4212
   q2	2019	200	196	196
   q3	10443	1116	1047	1047
   q4	10203	750	759	750
   q5	7458	2659	2583	2583
   q6	222	134	133	133
   q7	962	610	590	590
   q8	9210	2047	2024	2024
   q9	8880	6493	6471	6471
   q10	8957	3750	3671	3671
   q11	458	232	236	232
   q12	450	221	214	214
   q13	17772	2964	2935	2935
   q14	257	207	230	207
   q15	510	467	474	467
   q16	499	365	373	365
   q17	1006	650	601	601
   q18	7950	7372	7297	7297
   q19	6092	1378	1397	1378
   q20	658	320	315	315
   q21	4786	3202	3231	3202
   q22	385	327	334	327
   Total cold run time: 116776 ms
   Total hot run time: 39217 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4361	4182	4293	4182
   q2	377	264	260	260
   q3	2931	2722	2889	2722
   q4	1946	1662	1723	1662
   q5	5514	5566	5501	5501
   q6	218	131	131	131
   q7	2143	1839	1880	1839
   q8	3245	3397	3348	3348
   q9	8616	8602	8677	8602
   q10	4054	3778	3866	3778
   q11	594	484	467	467
   q12	762	585	624	585
   q13	17206	3153	3186	3153
   q14	308	294	263	263
   q15	525	474	489	474
   q16	501	444	456	444
   q17	1774	1504	1502	1502
   q18	8115	7828	7836	7828
   q19	1792	1598	1653	1598
   q20	2068	1877	1878	1877
   q21	6754	4931	4741	4741
   q22	636	539	556	539
   Total cold run time: 74440 ms
   Total hot run time: 55496 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](thirdparty) patch libevent to enable keepalive on tcp [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #36026:
URL: https://github.com/apache/doris/pull/36026#issuecomment-2156082781

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](thirdparty) patch libevent to enable keepalive on tcp [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36026:
URL: https://github.com/apache/doris/pull/36026#issuecomment-2153834733

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](thirdparty) patch libevent to enable keepalive on tcp [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36026:
URL: https://github.com/apache/doris/pull/36026#issuecomment-2156089865

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](thirdparty) patch libevent to enable keepalive on tcp [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36026:
URL: https://github.com/apache/doris/pull/36026#issuecomment-2156089873

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](thirdparty) patch libevent to enable keepalive on tcp [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36026:
URL: https://github.com/apache/doris/pull/36026#issuecomment-2156099053

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 29.9 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 7527535c83b002772aec43b6fccae205daab8e43, data reload: false
   
   query1	0.04	0.03	0.03
   query2	0.08	0.03	0.04
   query3	0.23	0.04	0.05
   query4	1.69	0.07	0.07
   query5	0.50	0.48	0.49
   query6	1.14	0.73	0.73
   query7	0.02	0.02	0.02
   query8	0.05	0.04	0.05
   query9	0.54	0.48	0.49
   query10	0.54	0.56	0.55
   query11	0.16	0.11	0.11
   query12	0.14	0.12	0.12
   query13	0.58	0.59	0.60
   query14	0.77	0.77	0.78
   query15	0.81	0.81	0.81
   query16	0.36	0.36	0.36
   query17	1.03	0.96	1.02
   query18	0.22	0.24	0.25
   query19	1.77	1.79	1.67
   query20	0.02	0.01	0.01
   query21	15.47	0.64	0.63
   query22	4.74	7.59	1.39
   query23	18.28	1.46	1.34
   query24	2.11	0.25	0.21
   query25	0.15	0.09	0.08
   query26	0.27	0.18	0.17
   query27	0.07	0.08	0.08
   query28	13.20	1.01	0.98
   query29	12.61	3.27	3.27
   query30	0.26	0.06	0.05
   query31	2.88	0.38	0.38
   query32	3.30	0.46	0.48
   query33	2.88	2.85	2.86
   query34	17.12	4.41	4.45
   query35	4.48	4.44	4.43
   query36	0.66	0.46	0.46
   query37	0.18	0.15	0.15
   query38	0.15	0.15	0.14
   query39	0.04	0.04	0.03
   query40	0.18	0.14	0.14
   query41	0.09	0.05	0.05
   query42	0.06	0.05	0.05
   query43	0.04	0.04	0.04
   Total cold run time: 109.91 s
   Total hot run time: 29.9 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](thirdparty) patch libevent to enable keepalive on tcp [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36026:
URL: https://github.com/apache/doris/pull/36026#issuecomment-2156091834

   TeamCity be ut coverage result:
    Function Coverage: 36.44% (8976/24630) 
    Line Coverage: 27.98% (73359/262195)
    Region Coverage: 27.38% (38014/138858)
    Branch Coverage: 24.00% (19306/80446)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/7527535c83b002772aec43b6fccae205daab8e43_7527535c83b002772aec43b6fccae205daab8e43/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org