You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@spamassassin.apache.org on 2020/01/27 17:19:45 UTC
[Bug 7790] New: Error in pyzor_options option parsing
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7790
Bug ID: 7790
Summary: Error in pyzor_options option parsing
Product: Spamassassin
Version: 3.4.3
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: Plugins
Assignee: dev@spamassassin.apache.org
Reporter: azotov@geolink-group.com
Target Milestone: Undefined
For pyzor_options option only characters in the range [0-9A-Za-z ,._/-] are
allowed for security reasons. But valid pyzor option can include '=' character
(--homedir=HOMEDIR, --log-file=LOGFILE, etc). Please, add '=' to the list of
allowed characters for pyzor_options.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7790] Error in pyzor_options option parsing
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7790
RW <rw...@googlemail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rwmaillists@googlemail.com
--- Comment #1 from RW <rw...@googlemail.com> ---
I don't know whether there was a good reason to omit '=', but it isn't
actually essential, you can use
--homedir HOMEDIR --log-file LOGFILE
It is confusing though.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7790] Error in pyzor_options option parsing
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7790
Henrik Krohns <ap...@hege.li> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |apache@hege.li
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from Henrik Krohns <ap...@hege.li> ---
Added = as allowed character.
Sending spamassassin-3.4/lib/Mail/SpamAssassin/Plugin/Pyzor.pm
Sending trunk/lib/Mail/SpamAssassin/Plugin/Pyzor.pm
Transmitting file data ..done
Committing transaction...
Committed revision 1876350.
PS. spamassassin --lint already warns about any invalid configs.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7790] Error in pyzor_options option parsing
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7790
azotov@geolink-group.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |minor
CC| |azotov@geolink-group.com
--- Comment #2 from azotov@geolink-group.com ---
I have tried pyzor 1.0 with "--homedir HOMEDIR" options format and it worked.
So the issue importance can be lowed to "minor".
But I still think that it would be useful to allow '=' in pyzor_options or to
mention "--homedir HOMEDIR" format in spamassassin documentation. Running
"pyzor --help" lists only "--homedir=HOMEDIR" options format so it is not
evident that it is possible to use ' ' instead of '='.
P.S. It may be also useful to add a warning message if pyzor_options value
contains forbidden characters and add modify "internal error, python traceback
seen in response\n" warning message in Pyzor.pm by adding actual python
traceback to it.
I am using spamassassin as a part of mimedefang and was very surprised to see
an error message from mimedefang-multiplexor about python traceback as both
spamassassin and mimedefang are written in perl, not python :). It was rather
difficult to find out that actual reason of these messages in my case was the
following: spamassassin silently ignored my custom pyzor_options due to '='
characters and run pyzor without any options and pyzor tried to create homedir
in default (i.e. wrong) location and failed with python traceback due to lack
of permissions to do that.
--
You are receiving this mail because:
You are the assignee for the bug.