You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by gvramana <gi...@git.apache.org> on 2017/12/07 10:18:36 UTC

[GitHub] carbondata pull request #1623: [CARBONDATA-1866] refactored CarbonLateDecode...

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1623#discussion_r155480115
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonIUDRule.scala ---
    @@ -0,0 +1,58 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.optimizer
    +
    +import org.apache.spark.sql.ProjectForUpdate
    +import org.apache.spark.sql.catalyst.expressions.{NamedExpression, PredicateHelper}
    +import org.apache.spark.sql.catalyst.plans.logical.{LogicalPlan, Project}
    +import org.apache.spark.sql.catalyst.rules.Rule
    +import org.apache.spark.sql.execution.command.mutation.CarbonProjectForUpdateCommand
    +
    +/**
    + * Rule specific for IUD operations
    + */
    +class CarbonIUDRule extends Rule[LogicalPlan] with PredicateHelper {
    +  override def apply(plan: LogicalPlan): LogicalPlan = {
    +    if (CarbonDecodeRuleHelper.checkIfRuleNeedToBeApplied(plan)) {
    --- End diff --
    
    This check is not required, as IUD node once replaced will not present


---