You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "zymap (via GitHub)" <gi...@apache.org> on 2023/02/21 03:34:11 UTC

[GitHub] [bookkeeper] zymap opened a new pull request, #3790: Fix CI is not failed when test have errors

zymap opened a new pull request, #3790:
URL: https://github.com/apache/bookkeeper/pull/3790

   ---
   
   ### Motivation
   
   We added the test coverage to report the tests status. But when we use the code-coverage profile, it will ignore test failure because we set `<testFailureIgnore>true</testFailureIgnore>`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] zymap commented on pull request #3790: Fix CI is not failed when test have errors

Posted by "zymap (via GitHub)" <gi...@apache.org>.
zymap commented on PR #3790:
URL: https://github.com/apache/bookkeeper/pull/3790#issuecomment-1437980241

   I am trying to fix the test https://github.com/zymap/bookkeeper/pull/20
   
   The interesting thing is, the tests get passed on my local


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] codecov-commenter commented on pull request #3790: Fix CI is not failed when test have errors

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3790:
URL: https://github.com/apache/bookkeeper/pull/3790#issuecomment-1437846512

   # [Codecov](https://codecov.io/gh/apache/bookkeeper/pull/3790?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3790](https://codecov.io/gh/apache/bookkeeper/pull/3790?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a7f06b8) into [master](https://codecov.io/gh/apache/bookkeeper/commit/13ccc4caf8ad80e84279e88edae0e71b8a555e09?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (13ccc4c) will **decrease** coverage by `19.63%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #3790       +/-   ##
   =============================================
   - Coverage     68.16%   48.53%   -19.63%     
   + Complexity     6719     4746     -1973     
   =============================================
     Files           473      473               
     Lines         40952    40952               
     Branches       5236     5236               
   =============================================
   - Hits          27913    19876     -8037     
   - Misses        10778    19095     +8317     
   + Partials       2261     1981      -280     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | bookie | `?` | |
   | client | `44.27% <ø> (-0.04%)` | :arrow_down: |
   | remaining | `29.67% <ø> (-0.02%)` | :arrow_down: |
   | replication | `?` | |
   | tls | `20.98% <ø> (-0.13%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/bookkeeper/pull/3790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...org/apache/bookkeeper/bookie/ReadOnlyFileInfo.java](https://codecov.io/gh/apache/bookkeeper/pull/3790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL1JlYWRPbmx5RmlsZUluZm8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...org/apache/bookkeeper/bookie/datainteg/Events.java](https://codecov.io/gh/apache/bookkeeper/pull/3790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL2RhdGFpbnRlZy9FdmVudHMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rg/apache/bookkeeper/metastore/MetastoreTable.java](https://codecov.io/gh/apache/bookkeeper/pull/3790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YXN0b3JlL01ldGFzdG9yZVRhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../apache/bookkeeper/bookie/storage/EntryLogger.java](https://codecov.io/gh/apache/bookkeeper/pull/3790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL3N0b3JhZ2UvRW50cnlMb2dnZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../bookkeeper/metastore/MetastoreScannableTable.java](https://codecov.io/gh/apache/bookkeeper/pull/3790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YXN0b3JlL01ldGFzdG9yZVNjYW5uYWJsZVRhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...bookkeeper/server/http/service/MetricsService.java](https://codecov.io/gh/apache/bookkeeper/pull/3790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2h0dHAvc2VydmljZS9NZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...eeper/bookie/storage/directentrylogger/Events.java](https://codecov.io/gh/apache/bookkeeper/pull/3790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL3N0b3JhZ2UvZGlyZWN0ZW50cnlsb2dnZXIvRXZlbnRzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...eper/server/http/service/ConfigurationService.java](https://codecov.io/gh/apache/bookkeeper/pull/3790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2h0dHAvc2VydmljZS9Db25maWd1cmF0aW9uU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...per/meta/LongHierarchicalLedgerManagerFactory.java](https://codecov.io/gh/apache/bookkeeper/pull/3790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YS9Mb25nSGllcmFyY2hpY2FsTGVkZ2VyTWFuYWdlckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ookeeper/ExponentialBackOffWithDeadlinePolicy.java](https://codecov.io/gh/apache/bookkeeper/pull/3790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvem9va2VlcGVyL0V4cG9uZW50aWFsQmFja09mZldpdGhEZWFkbGluZVBvbGljeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [233 more](https://codecov.io/gh/apache/bookkeeper/pull/3790?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] merlimat merged pull request #3790: Fix CI is not failed when test have errors

Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #3790:
URL: https://github.com/apache/bookkeeper/pull/3790


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org