You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by yiming187 <gi...@git.apache.org> on 2017/02/08 04:18:32 UTC

[GitHub] zeppelin pull request #1986: [ZEPPELIN-2078] bug fix in get project name in ...

GitHub user yiming187 opened a pull request:

    https://github.com/apache/zeppelin/pull/1986

    [ZEPPELIN-2078] bug fix in get project name in Kylin interpreter

    ### What is this PR for?
    https://github.com/apache/zeppelin/blob/master/kylin/src/main/java/org/apache/zeppelin/kylin/KylinInterpreter.java line 103, the getProject's input should be sql, not const string KYLIN_QUERY_PROJECT. Otherwise no project name could be retrieved. And also the SQL should exclude the project part.
    
    public HttpResponse prepareRequest(String sql) throws IOException {
    String kylinProject = getProject(KYLIN_QUERY_PROJECT);
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2078
    
    ### How should this be tested?
    Has unit test.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yiming187/zeppelin ZEPPELIN-2078

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1986.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1986
    
----
commit 681714a2d68dade9fb924f9413b4c31447bfa974
Author: Billy Liu <bi...@apache.org>
Date:   2017-02-08T04:12:54Z

    [ZEPPELIN-2078] bug fix in get project name in Kylin interpreter

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1986: [ZEPPELIN-2078] bug fix in get project name in ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1986


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1986: [ZEPPELIN-2078] bug fix in get project name in Kylin i...

Posted by yiming187 <gi...@git.apache.org>.

Github user yiming187 commented on the issue:

    https://github.com/apache/zeppelin/pull/1986
  
    Thanks, Moon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1986: [ZEPPELIN-2078] bug fix in get project name in Kylin i...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1986
  
    CI failure looks not related.
    LGTM and merge to master if no further discussions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---