[GitHub] [libcloud] c-w commented on a change in pull request #1400: Implemented chunked upload for Azure Blobs storage driver

[GitBox <gi...@apache.org>]

c-w commented on a change in pull request #1400: Implemented chunked upload for Azure Blobs storage driver
URL: https://github.com/apache/libcloud/pull/1400#discussion_r364517127
 
 

 ##########
 File path: libcloud/storage/base.py
 ##########
 @@ -639,13 +624,30 @@ def _upload_object(self, object_name, content_type, request_path,
         if not response.success():
             response.parse_error()
 
-        if upload_func:
-            upload_func(**upload_func_kwargs)
-
         return {'response': response,
                 'bytes_transferred': stream_length,
                 'data_hash': stream_hash}
 
+    def _determine_content_type(self, content_type, object_name,
+                                file_path=None):
+        if not content_type:
 
 Review comment:
   Cleaned up the function in 498ac88.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services