You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/07/17 16:20:30 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #7003: Docs: Add docs to `RepartitionExec` and architecture guide
alamb opened a new pull request, #7003:
URL: https://github.com/apache/arrow-datafusion/pull/7003
# Which issue does this PR close?
N/A
# Rationale for this change
While writing up https://github.com/apache/arrow-datafusion/issues/7001 I made some diagrams and descriptions about `Repartition` that I felt would add value as doc comments
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
Add docs to `RepartitionExec` and architecture guide
# Are these changes tested?
CI tests the doc comments
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
Docs
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #7003: Docs: Add docs to `RepartitionExec` and architecture guide
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #7003:
URL: https://github.com/apache/arrow-datafusion/pull/7003#discussion_r1265604749
##########
datafusion/core/src/physical_plan/repartition/mod.rs:
##########
@@ -239,8 +239,67 @@ impl BatchPartitioner {
}
}
-/// The repartition operator maps N input partitions to M output partitions based on a
-/// partitioning scheme. No guarantees are made about the order of the resulting partitions.
+/// Maps `N` input partitions to `M output partitions based on a
Review Comment:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] 2010YOUY01 commented on a diff in pull request #7003: Docs: Add docs to `RepartitionExec` and architecture guide
Posted by "2010YOUY01 (via GitHub)" <gi...@apache.org>.
2010YOUY01 commented on code in PR #7003:
URL: https://github.com/apache/arrow-datafusion/pull/7003#discussion_r1267053520
##########
datafusion/core/src/physical_plan/repartition/mod.rs:
##########
@@ -239,8 +239,67 @@ impl BatchPartitioner {
}
}
-/// The repartition operator maps N input partitions to M output partitions based on a
-/// partitioning scheme. No guarantees are made about the order of the resulting partitions.
+/// Maps `N` input partitions to `M output partitions based on a
Review Comment:
```suggestion
/// Maps `N` input partitions to `M` output partitions based on a
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #7003: Docs: Add docs to `RepartitionExec` and architecture guide
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #7003:
URL: https://github.com/apache/arrow-datafusion/pull/7003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org