You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/01/14 11:20:43 UTC
[GitHub] [kafka] cadonna commented on a change in pull request #9888: KAFKA-12194: use stateListener to catch each state change
cadonna commented on a change in pull request #9888:
URL: https://github.com/apache/kafka/pull/9888#discussion_r557319308
##########
File path: streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##########
@@ -61,15 +61,16 @@
@Rule
public TestName testName = new TestName();
+ private final List<KafkaStreams.State> stateToTransitions = new ArrayList<>();
Review comment:
I think `stateHistory` or `stateTransitionHistory` would be a more meaningful name for this variable.
##########
File path: streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##########
@@ -88,69 +89,96 @@ public void setup() {
mkEntry(StreamsConfig.DEFAULT_VALUE_SERDE_CLASS_CONFIG, Serdes.StringSerde.class)
)
);
+
+ createAndRunStream();
}
@After
public void teardown() throws IOException {
+ if (kafkaStreams != null) {
+ kafkaStreams.close();
+ }
purgeLocalStreamsState(properties);
}
+ private void addStreamStateChangeListener(final KafkaStreams kafkaStreams) {
+ // we store each new state in state transition so that we won't miss any state change
+ kafkaStreams.setStateListener(
+ (newState, oldState) -> stateToTransitions.add(newState)
+ );
+ }
+
+ private void waitForStateTransition(final KafkaStreams.State expected) throws InterruptedException {
+ waitForCondition(
+ () -> !stateToTransitions.isEmpty() && stateToTransitions.contains(expected),
+ DEFAULT_DURATION.toMillis(),
+ () -> String.format("Client did not change to the %s state in time. Observed new state transitions: %s",
+ expected, stateToTransitions)
+ );
+ }
+
+ private void createAndRunStream() throws InterruptedException {
+ kafkaStreams = new KafkaStreams(builder.build(), properties);
+ addStreamStateChangeListener(kafkaStreams);
+ kafkaStreams.start();
+ waitForStateTransition(KafkaStreams.State.RUNNING);
+ }
+
@Test
public void shouldAddStreamThread() throws Exception {
- try (final KafkaStreams kafkaStreams = new KafkaStreams(builder.build(), properties)) {
- StreamsTestUtils.startKafkaStreamsAndWaitForRunningState(kafkaStreams);
- final int oldThreadCount = kafkaStreams.localThreadsMetadata().size();
- assertThat(kafkaStreams.localThreadsMetadata().stream().map(t -> t.threadName().split("-StreamThread-")[1]).sorted().toArray(), equalTo(new String[] {"1", "2"}));
-
- final Optional<String> name = kafkaStreams.addStreamThread();
-
- assertThat(name, not(Optional.empty()));
- TestUtils.waitForCondition(
- () -> kafkaStreams.localThreadsMetadata().stream().sequential()
- .map(ThreadMetadata::threadName).anyMatch(t -> t.equals(name.orElse(""))),
- "Wait for the thread to be added"
- );
- assertThat(kafkaStreams.localThreadsMetadata().size(), equalTo(oldThreadCount + 1));
- assertThat(
- kafkaStreams
- .localThreadsMetadata()
- .stream()
- .map(t -> t.threadName().split("-StreamThread-")[1])
- .sorted().toArray(),
- equalTo(new String[] {"1", "2", "3"})
- );
- waitForApplicationState(Collections.singletonList(kafkaStreams), KafkaStreams.State.REBALANCING, DEFAULT_DURATION);
- waitForApplicationState(Collections.singletonList(kafkaStreams), KafkaStreams.State.RUNNING, DEFAULT_DURATION);
- }
+ final int oldThreadCount = kafkaStreams.localThreadsMetadata().size();
+ assertThat(kafkaStreams.localThreadsMetadata().stream().map(t -> t.threadName().split("-StreamThread-")[1]).sorted().toArray(), equalTo(new String[] {"1", "2"}));
+
+ stateToTransitions.clear();
+ final Optional<String> name = kafkaStreams.addStreamThread();
+
+ assertThat(name, not(Optional.empty()));
+ TestUtils.waitForCondition(
+ () -> kafkaStreams.localThreadsMetadata().stream().sequential()
+ .map(ThreadMetadata::threadName).anyMatch(t -> t.equals(name.orElse(""))),
+ "Wait for the thread to be added"
+ );
+ assertThat(kafkaStreams.localThreadsMetadata().size(), equalTo(oldThreadCount + 1));
+ assertThat(
+ kafkaStreams
+ .localThreadsMetadata()
+ .stream()
+ .map(t -> t.threadName().split("-StreamThread-")[1])
+ .sorted().toArray(),
+ equalTo(new String[] {"1", "2", "3"})
+ );
+
+ waitForStateTransition(KafkaStreams.State.REBALANCING);
+ waitForStateTransition(KafkaStreams.State.RUNNING);
Review comment:
I think it would be better to wait until the Kafka Streams client id in state `RUNNING` and then verify if the history of the states transitions after adding the stream thread is first `REBALANCING` and then `RUNNING`. Currently, the order is not verified as far as I can see.
##########
File path: streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##########
@@ -88,69 +89,96 @@ public void setup() {
mkEntry(StreamsConfig.DEFAULT_VALUE_SERDE_CLASS_CONFIG, Serdes.StringSerde.class)
)
);
+
+ createAndRunStream();
}
@After
public void teardown() throws IOException {
+ if (kafkaStreams != null) {
+ kafkaStreams.close();
+ }
purgeLocalStreamsState(properties);
}
+ private void addStreamStateChangeListener(final KafkaStreams kafkaStreams) {
+ // we store each new state in state transition so that we won't miss any state change
+ kafkaStreams.setStateListener(
+ (newState, oldState) -> stateToTransitions.add(newState)
+ );
+ }
+
+ private void waitForStateTransition(final KafkaStreams.State expected) throws InterruptedException {
+ waitForCondition(
+ () -> !stateToTransitions.isEmpty() && stateToTransitions.contains(expected),
+ DEFAULT_DURATION.toMillis(),
+ () -> String.format("Client did not change to the %s state in time. Observed new state transitions: %s",
+ expected, stateToTransitions)
+ );
+ }
+
+ private void createAndRunStream() throws InterruptedException {
+ kafkaStreams = new KafkaStreams(builder.build(), properties);
+ addStreamStateChangeListener(kafkaStreams);
+ kafkaStreams.start();
+ waitForStateTransition(KafkaStreams.State.RUNNING);
+ }
+
@Test
public void shouldAddStreamThread() throws Exception {
- try (final KafkaStreams kafkaStreams = new KafkaStreams(builder.build(), properties)) {
- StreamsTestUtils.startKafkaStreamsAndWaitForRunningState(kafkaStreams);
Review comment:
Why replacing the try-with-resources with an explicit `close()`? This did not make the test flaky, as far as I can see. Can't we add the Streams state listener as the first statement in the try-with-resources block?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org