You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rohit Yadav <bh...@apache.org> on 2014/12/05 19:32:17 UTC

Re: Review Request 22693: Added VirtualRouterElements, InternalLoadBalancerElements classes to base.py- Extended methods in DiskOffering, StoragePool and Physical Network classes to accept more parameters

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22693/#review64040
-----------------------------------------------------------


ping.

- Rohit Yadav


On June 17, 2014, 7:25 p.m., Chandan Purushothama wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22693/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 7:25 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Raja Pullela, sangeetha hariharan, sanjeev n, Santhosh Edukulla, sudha ponnaganti, and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Currently methods in DiskOffering, StoragePool and Physical Network restrict the programmer to use limited parameters. I made changes to the methods in those classes to accept more parameters that can be used during test script programming.
> 
> Added VirtualRouterElements, InternalLoadBalancerElements classes to base.py . The code will make the test script programming easier for programmers writing test scripts related to Zones.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/lib/base.py 8b89087 
> 
> Diff: https://reviews.apache.org/r/22693/diff/
> 
> 
> Testing
> -------
> 
> Test Suite was scripted and tested with the above mentioned additions to base.py.
> 
> 
> Thanks,
> 
> Chandan Purushothama
> 
>


Re: Review Request 22693: Added VirtualRouterElements, InternalLoadBalancerElements classes to base.py- Extended methods in DiskOffering, StoragePool and Physical Network classes to accept more parameters

Posted by Chandan Purushothama <Ch...@citrix.com>.

> On Dec. 5, 2014, 6:32 p.m., Rohit Yadav wrote:
> > ping.

Hello Rohit,

Sorry for my delayed action on this review request. I will get to this as soon as I am done with fixing issues in Automation test suites,

Thank you,
Chandan.


- Chandan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22693/#review64040
-----------------------------------------------------------


On June 17, 2014, 7:25 p.m., Chandan Purushothama wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22693/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 7:25 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Raja Pullela, sangeetha hariharan, sanjeev n, Santhosh Edukulla, sudha ponnaganti, and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Currently methods in DiskOffering, StoragePool and Physical Network restrict the programmer to use limited parameters. I made changes to the methods in those classes to accept more parameters that can be used during test script programming.
> 
> Added VirtualRouterElements, InternalLoadBalancerElements classes to base.py . The code will make the test script programming easier for programmers writing test scripts related to Zones.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/lib/base.py 8b89087 
> 
> Diff: https://reviews.apache.org/r/22693/diff/
> 
> 
> Testing
> -------
> 
> Test Suite was scripted and tested with the above mentioned additions to base.py.
> 
> 
> Thanks,
> 
> Chandan Purushothama
> 
>