You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eumiro (via GitHub)" <gi...@apache.org> on 2023/08/19 06:40:03 UTC
[GitHub] [airflow] eumiro opened a new pull request, #33520: Replace repr() with proper formatting
eumiro opened a new pull request, #33520:
URL: https://github.com/apache/airflow/pull/33520
Refactor: replace `repr()` with `!r` in f-strings and `%r` in log messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #33520: Replace repr() with proper formatting
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #33520:
URL: https://github.com/apache/airflow/pull/33520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #33520: Replace repr() with proper formatting
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #33520:
URL: https://github.com/apache/airflow/pull/33520#discussion_r1299295559
##########
airflow/jobs/backfill_job_runner.py:
##########
@@ -1036,8 +1036,8 @@ def query(result, items):
reset_tis = helpers.reduce_in_chunks(query, tis_to_reset, [], self.job.max_tis_per_query)
- task_instance_str = "\n\t".join(repr(x) for x in reset_tis)
+ task_instance_str = "\n".join(f"\t{x!r}" for x in reset_tis)
session.flush()
- self.log.info("Reset the following %s TaskInstances:\n\t%s", len(reset_tis), task_instance_str)
+ self.log.info("Reset the following %s TaskInstances:\n%s", len(reset_tis), task_instance_str)
Review Comment:
This seems unrelated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #33520: Replace repr() with proper formatting
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #33520:
URL: https://github.com/apache/airflow/pull/33520#discussion_r1299295559
##########
airflow/jobs/backfill_job_runner.py:
##########
@@ -1036,8 +1036,8 @@ def query(result, items):
reset_tis = helpers.reduce_in_chunks(query, tis_to_reset, [], self.job.max_tis_per_query)
- task_instance_str = "\n\t".join(repr(x) for x in reset_tis)
+ task_instance_str = "\n".join(f"\t{x!r}" for x in reset_tis)
session.flush()
- self.log.info("Reset the following %s TaskInstances:\n\t%s", len(reset_tis), task_instance_str)
+ self.log.info("Reset the following %s TaskInstances:\n%s", len(reset_tis), task_instance_str)
Review Comment:
This seems unrelated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org