[GitHub] [incubator-liminal] assapin commented on a change in pull request #74: Extensibility

[GitBox <gi...@apache.org>]

assapin commented on a change in pull request #74:
URL: https://github.com/apache/incubator-liminal/pull/74#discussion_r773848755



##########
File path: liminal/settings.py
##########
@@ -0,0 +1,44 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import os
+import sys
+
+from liminal.core.environment import get_liminal_home
+
+LIMINAL_HOME = get_liminal_home()
+
+
+def make_plugin_dirs():
+    plugins = os.path.join(LIMINAL_HOME, 'liminal/plugins')
+
+    os.makedirs(plugins, exist_ok=True)
+
+    os.makedirs(os.path.join(plugins, 'executors'), exist_ok=True)

Review comment:
       consts used in multiple places in teh code. not too bad but cleaner with consts

##########
File path: scripts/liminal
##########
@@ -141,7 +143,9 @@ def deploy_liminal_apps(path, clean):
     liminal_home = environment.get_liminal_home()
     os.makedirs(liminal_home, exist_ok=True)
     os.makedirs(environment.get_dags_dir(), exist_ok=True)
+
     deploy_liminal_core_internal(liminal_home, clean)
+    deploy_plugins(liminal_home)

Review comment:
       where is the implementation of this method? weirdly I couldn't find it?

##########
File path: liminal/settings.py
##########
@@ -0,0 +1,44 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import os
+import sys
+
+from liminal.core.environment import get_liminal_home
+
+LIMINAL_HOME = get_liminal_home()
+
+
+def make_plugin_dirs():
+    plugins = os.path.join(LIMINAL_HOME, 'liminal/plugins')

Review comment:
       would be good to extract 'plugins', 'tasks' and all the string consts to be consts 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@liminal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org