You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/05/08 18:35:37 UTC
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] codingfred opened a new pull request #10: [NETBEANSINFRA-189]: Fix regression introduced by [NETBEANSINFRA-188]
codingfred opened a new pull request #10:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/10
The optimization - implemented in #8 - introduced a serious regression
by truncating the whole jar file instead of modifying a single entry in the jar file.
This PR fixes this by applying another approach. Using the in Java 7
introduced Files API, one can create a virtual filesystem of a zip file
and read or write single entries.
In my tests the now modfied jar files are no longer truncated
and the whole module suite can be compiled and executed successfully.
The intended speedup retains.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] ebarboni merged pull request #10: [NETBEANSINFRA-189]: Fix regression introduced by [NETBEANSINFRA-188]
Posted by GitBox <gi...@apache.org>.
ebarboni merged pull request #10:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/10
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] matthiasblaesing commented on pull request #10: [NETBEANSINFRA-189]: Fix regression introduced by [NETBEANSINFRA-188]
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #10:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/10#issuecomment-644910096
The list of ICLA signees is available publicly:
Committers: https://whimsy.apache.org/public/icla-info.json
Non-Committers: https://whimsy.apache.org/public/icla-info_noid.json
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] neilcsmith-net commented on pull request #10: [NETBEANSINFRA-189]: Fix regression introduced by [NETBEANSINFRA-188]
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #10:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/10#issuecomment-644790101
@ebarboni shouldn't need an ICLA for something this simple anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] ebarboni commented on pull request #10: [NETBEANSINFRA-189]: Fix regression introduced by [NETBEANSINFRA-188]
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #10:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/10#issuecomment-644799887
Yep but seems important to author.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] codingfred commented on pull request #10: [NETBEANSINFRA-189]: Fix regression introduced by [NETBEANSINFRA-188]
Posted by GitBox <gi...@apache.org>.
codingfred commented on pull request #10:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/10#issuecomment-625958388
Currently I'm printing out and signing the Apache ICLA, so that no non-technical reasons hinder the fix of my scew up!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] ebarboni commented on pull request #10: [NETBEANSINFRA-189]: Fix regression introduced by [NETBEANSINFRA-188]
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #10:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/10#issuecomment-644731112
Hi, I'm not sure the ICLA was recieved did you mention NetBeans project so we are notified ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] ebarboni commented on pull request #10: [NETBEANSINFRA-189]: Fix regression introduced by [NETBEANSINFRA-188]
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #10:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/10#issuecomment-645997617
@neilcsmith-net a bit for the joke, a 50 lines changes on nbm-maven-plugin is "important" compared to the same change in netbeans repo :D.
But I misunderstand @codingfred intention of willing to have ICLA. By the way ICLA is recieved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists