[GitHub] [superset] m-ajay commented on pull request #17410: feat(dashboard): Add divider component in native filters

[GitBox <gi...@apache.org>]

m-ajay commented on pull request #17410:
URL: https://github.com/apache/superset/pull/17410#issuecomment-973191323


   @geido Thanks for the comments.
   For comment 3, do you have any mockup? I tried to add some spacing in the modal, but, due to limited space, it did not look good.
   About comment 4 - I'm not sure if we need a tool tip. I feel like user should be responsible for adding the content in a way that it doesn't break the filter bar. Even if we are adding a tooltip, we will have to truncate the content in an arbitrary length. I'm not sure if we should do that.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org