You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/25 08:02:53 UTC

[GitHub] [skywalking] toffentoffen opened a new pull request, #9843: Do not log grpc envoy receiver client-side streaming cancellation as errors

toffentoffen opened a new pull request, #9843:
URL: https://github.com/apache/skywalking/pull/9843

   <!--
       ⚠️ Please make sure to read this template first, pull requests that don't accord with this template
       maybe closed without notice.
       Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
       Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
   -->
   
   <!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
   ### Fix <bug description or the bug issue number or bug issue link>
   - [ ] Add a unit test to verify that the fix works.
   - [ ] Explain briefly why the bug exists and how to fix it.
        ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
   
   <!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
   ### Improve the performance of <class or module or ...>
   - [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
   - [ ] The benchmark result.
   ```text
   <Paste the benchmark results here>
   ```
   - [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
        ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
   
   <!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
   ### <Feature description>
   - [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
   - [ ] Update the documentation to include this new feature.
   - [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
   - [ ] If it's UI related, attach the screenshots below.
        ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
   
   - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #9840.
   - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] sonatype-lift[bot] commented on pull request #9843: Do not log grpc envoy receiver client-side streaming cancellation as errors

Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on PR #9843:
URL: https://github.com/apache/skywalking/pull/9843#issuecomment-1290195389

   :warning: **6 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/skywalking/01GG72MW9BMYF2FTD8HPWHPQFG?tab=technical-debt&utm_source=github.com&utm_campaign=lift-comment&utm_content=apache\%20skywalking) for more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9843: Do not log grpc envoy receiver client-side streaming cancellation as errors

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9843:
URL: https://github.com/apache/skywalking/pull/9843#discussion_r1004549649


##########
docs/en/changes/changes.md:
##########
@@ -69,6 +69,8 @@
 * [**Breaking Change**] Support new records query protocol, rename the column named `service_id` to `entity_id` for support difference entity.
   Please re-create `top_n_database_statement` index/table.
 * Remove improper self-obs metrics in JvmMetricsHandler(for Kafka channel).
+* Client-side grpc stream envoy metrics receiver is not logged as an error when client cancels the stream. Client 
+  cancels the stream when the pod is terminated.

Review Comment:
   ```suggestion
   * gRPC stream canceling code is not logged as an error when the client cancels the stream. The client 
     cancels the stream when the pod is terminated.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #9843: Do not log grpc envoy receiver client-side streaming cancellation as errors

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9843:
URL: https://github.com/apache/skywalking/pull/9843#issuecomment-1290156777

   I think there are many other gRPC handlers that should be fixed as well. Could you fix them in this PR once?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #9843: Do not log grpc envoy receiver client-side streaming cancellation as errors

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9843:
URL: https://github.com/apache/skywalking/pull/9843#issuecomment-1291266904

   @kezhenxu94 I think commit log is forgotten to update accordingly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 merged pull request #9843: Do not log grpc envoy receiver client-side streaming cancellation as errors

Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged PR #9843:
URL: https://github.com/apache/skywalking/pull/9843


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] toffentoffen commented on pull request #9843: Do not log grpc envoy receiver client-side streaming cancellation as errors

Posted by GitBox <gi...@apache.org>.
toffentoffen commented on PR #9843:
URL: https://github.com/apache/skywalking/pull/9843#issuecomment-1290549430

   > I think there are many other gRPC handlers that should be fixed as well. Could you fix them in this PR once?
   
   Sure @wu-sheng Will fix them as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org