[jira] [Resolved] (THRIFT-2466) Improper error handling for SSL/TLS connections that don't complete a handshake

["Roger Meier (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier resolved THRIFT-2466.
---------------------------------

    Resolution: Fixed
      Assignee: Roger Meier

Thanks Benoit!
committed
;-r

> Improper error handling for SSL/TLS connections that don't complete a handshake
> -------------------------------------------------------------------------------
>
>                 Key: THRIFT-2466
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2466
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Library
>    Affects Versions: 0.9.1
>            Reporter: Benoit Sigoure
>            Assignee: Roger Meier
>         Attachments: THRIFT-2466-Silently-ignore-clients-that-couldn-t-be-created.patch
>
>
> The code in {{TSSLServerSocket.accept()}} silently drops all {{SSLError}} and returns {{None}} instead, but none of the {{TServer}} implementations handle this case properly, which cause them to pass {{None}} around a bunch, which eventually cause weird {{AttributeError}} exceptions.
> This bug is easy to reproduce: just open a socket to a Python Thrift server that uses SSL/TLS and close the connection right away.



--
This message was sent by Atlassian JIRA
(v6.2#6252)