You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by John McNamee <jp...@terpmail.umd.edu> on 2014/02/27 15:53:05 UTC
Re: Review Request 18438: ACCUMULO-1395
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18438/
-----------------------------------------------------------
(Updated Feb. 27, 2014, 2:52 p.m.)
Review request for accumulo.
Changes
-------
Implemented suggested changes.
Added additional configuration option.
This patch is now offered as a solution to ACCUMULO-1395 rather than ACCUMULO-780.
Updated review request to reflect this change.
Summary (updated)
-----------------
ACCUMULO-1395
Bugs: ACCUMULO-1395
https://issues.apache.org/jira/browse/ACCUMULO-1395
Repository: accumulo
Description (updated)
-------
Generate example configuration
Diffs (updated)
-----
assemble/pom.xml 5a1d8e3
assemble/src/main/assemblies/component.xml fa53d5e
bin/bootstrap_config.sh be472d3
conf/accumulo.policy.example 2964f06
conf/examples/1GB/native-standalone/accumulo-env.sh 9e9b6a6
conf/examples/1GB/native-standalone/accumulo-metrics.xml 60f9f8d
conf/examples/1GB/native-standalone/accumulo-site.xml b68059c
conf/examples/1GB/native-standalone/auditLog.xml 9b7987e
conf/examples/1GB/native-standalone/gc 63fb8bb
conf/examples/1GB/native-standalone/generic_logger.xml 4d2af90
conf/examples/1GB/native-standalone/log4j.properties a4bcb2e
conf/examples/1GB/native-standalone/masters 63fb8bb
conf/examples/1GB/native-standalone/monitor 63fb8bb
conf/examples/1GB/native-standalone/monitor_logger.xml 3a63bf4
conf/examples/1GB/native-standalone/slaves 63fb8bb
conf/examples/1GB/native-standalone/tracers 63fb8bb
conf/examples/1GB/standalone/accumulo-env.sh 8b904ac
conf/examples/1GB/standalone/accumulo-metrics.xml 60f9f8d
conf/examples/1GB/standalone/accumulo-site.xml 1bca857
conf/examples/1GB/standalone/auditLog.xml 9b7987e
conf/examples/1GB/standalone/gc 63fb8bb
conf/examples/1GB/standalone/generic_logger.xml 4d2af90
conf/examples/1GB/standalone/log4j.properties a4bcb2e
conf/examples/1GB/standalone/masters 63fb8bb
conf/examples/1GB/standalone/monitor 63fb8bb
conf/examples/1GB/standalone/monitor_logger.xml 3a63bf4
conf/examples/1GB/standalone/slaves 63fb8bb
conf/examples/1GB/standalone/tracers 63fb8bb
conf/examples/2GB/native-standalone/accumulo-env.sh 5f6d2cb
conf/examples/2GB/native-standalone/accumulo-metrics.xml 60f9f8d
conf/examples/2GB/native-standalone/accumulo-site.xml 9eaa5ff
conf/examples/2GB/native-standalone/auditLog.xml 9b7987e
conf/examples/2GB/native-standalone/gc 63fb8bb
conf/examples/2GB/native-standalone/generic_logger.xml 4d2af90
conf/examples/2GB/native-standalone/log4j.properties a4bcb2e
conf/examples/2GB/native-standalone/masters 63fb8bb
conf/examples/2GB/native-standalone/monitor 63fb8bb
conf/examples/2GB/native-standalone/monitor_logger.xml 3a63bf4
conf/examples/2GB/native-standalone/slaves 63fb8bb
conf/examples/2GB/native-standalone/tracers 63fb8bb
conf/examples/2GB/standalone/accumulo-env.sh feba48c
conf/examples/2GB/standalone/accumulo-metrics.xml 60f9f8d
conf/examples/2GB/standalone/accumulo-site.xml c9e0309
conf/examples/2GB/standalone/auditLog.xml 9b7987e
conf/examples/2GB/standalone/gc 63fb8bb
conf/examples/2GB/standalone/generic_logger.xml 4d2af90
conf/examples/2GB/standalone/log4j.properties a4bcb2e
conf/examples/2GB/standalone/masters 63fb8bb
conf/examples/2GB/standalone/monitor 63fb8bb
conf/examples/2GB/standalone/monitor_logger.xml 3a63bf4
conf/examples/2GB/standalone/slaves 63fb8bb
conf/examples/2GB/standalone/tracers 63fb8bb
conf/examples/3GB/native-standalone/accumulo-env.sh be72992
conf/examples/3GB/native-standalone/accumulo-metrics.xml 60f9f8d
conf/examples/3GB/native-standalone/accumulo-site.xml 9b82ed3
conf/examples/3GB/native-standalone/auditLog.xml 9b7987e
conf/examples/3GB/native-standalone/gc 63fb8bb
conf/examples/3GB/native-standalone/generic_logger.xml 4d2af90
conf/examples/3GB/native-standalone/log4j.properties a4bcb2e
conf/examples/3GB/native-standalone/masters 63fb8bb
conf/examples/3GB/native-standalone/monitor 63fb8bb
conf/examples/3GB/native-standalone/monitor_logger.xml 3a63bf4
conf/examples/3GB/native-standalone/slaves 63fb8bb
conf/examples/3GB/native-standalone/tracers 63fb8bb
conf/examples/3GB/standalone/accumulo-env.sh 6e5fb3a
conf/examples/3GB/standalone/accumulo-metrics.xml 60f9f8d
conf/examples/3GB/standalone/accumulo-site.xml a127cbd
conf/examples/3GB/standalone/auditLog.xml 9b7987e
conf/examples/3GB/standalone/gc 63fb8bb
conf/examples/3GB/standalone/generic_logger.xml 4d2af90
conf/examples/3GB/standalone/log4j.properties a4bcb2e
conf/examples/3GB/standalone/masters 63fb8bb
conf/examples/3GB/standalone/monitor 63fb8bb
conf/examples/3GB/standalone/monitor_logger.xml 3a63bf4
conf/examples/3GB/standalone/slaves 63fb8bb
conf/examples/3GB/standalone/tracers 63fb8bb
conf/examples/512MB/native-standalone/accumulo-env.sh e02b524
conf/examples/512MB/native-standalone/accumulo-metrics.xml 60f9f8d
conf/examples/512MB/native-standalone/accumulo-site.xml 0e8bdb2
conf/examples/512MB/native-standalone/auditLog.xml 9b7987e
conf/examples/512MB/native-standalone/gc 63fb8bb
conf/examples/512MB/native-standalone/generic_logger.xml 4d2af90
conf/examples/512MB/native-standalone/log4j.properties a4bcb2e
conf/examples/512MB/native-standalone/masters 63fb8bb
conf/examples/512MB/native-standalone/monitor 63fb8bb
conf/examples/512MB/native-standalone/monitor_logger.xml 3a63bf4
conf/examples/512MB/native-standalone/slaves 63fb8bb
conf/examples/512MB/native-standalone/tracers 63fb8bb
conf/examples/512MB/standalone/accumulo-env.sh 457e1d3
conf/examples/512MB/standalone/accumulo-metrics.xml 60f9f8d
conf/examples/512MB/standalone/accumulo-site.xml 1a30ce7
conf/examples/512MB/standalone/auditLog.xml 9b7987e
conf/examples/512MB/standalone/gc 63fb8bb
conf/examples/512MB/standalone/generic_logger.xml 4d2af90
conf/examples/512MB/standalone/log4j.properties a4bcb2e
conf/examples/512MB/standalone/masters 63fb8bb
conf/examples/512MB/standalone/monitor 63fb8bb
conf/examples/512MB/standalone/monitor_logger.xml 3a63bf4
conf/examples/512MB/standalone/slaves 63fb8bb
conf/examples/512MB/standalone/tracers 63fb8bb
conf/examples/crypto/accumulo-site.xml a7e5c54
conf/examples/crypto/readme.txt c638b6e
conf/examples/vfs-classloader/accumulo-site.xml ea95ea2
conf/templates/accumulo-env.sh PRE-CREATION
conf/templates/accumulo-metrics.xml PRE-CREATION
conf/templates/accumulo-site.xml PRE-CREATION
conf/templates/accumulo.policy.example PRE-CREATION
conf/templates/gc PRE-CREATION
conf/templates/generic_logger.xml PRE-CREATION
conf/templates/log4j.properties PRE-CREATION
conf/templates/masters PRE-CREATION
conf/templates/monitor PRE-CREATION
conf/templates/monitor_logger.xml PRE-CREATION
conf/templates/slaves PRE-CREATION
conf/templates/tracers PRE-CREATION
Diff: https://reviews.apache.org/r/18438/diff/
Testing
-------
Thanks,
John McNamee
Re: Review Request 18438: ACCUMULO-1395
Posted by Mike Drob <md...@mdrob.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18438/#review35634
-----------------------------------------------------------
As a side note, John, you should feel empowered to close the review issues that Josh and I have opened once you feel they have been addressed.
- Mike Drob
On Feb. 27, 2014, 2:52 p.m., John McNamee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18438/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2014, 2:52 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1395
> https://issues.apache.org/jira/browse/ACCUMULO-1395
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Generate example configuration
>
>
> Diffs
> -----
>
> assemble/pom.xml 5a1d8e3
> assemble/src/main/assemblies/component.xml fa53d5e
> bin/bootstrap_config.sh be472d3
> conf/accumulo.policy.example 2964f06
> conf/examples/1GB/native-standalone/accumulo-env.sh 9e9b6a6
> conf/examples/1GB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/1GB/native-standalone/accumulo-site.xml b68059c
> conf/examples/1GB/native-standalone/auditLog.xml 9b7987e
> conf/examples/1GB/native-standalone/gc 63fb8bb
> conf/examples/1GB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/1GB/native-standalone/log4j.properties a4bcb2e
> conf/examples/1GB/native-standalone/masters 63fb8bb
> conf/examples/1GB/native-standalone/monitor 63fb8bb
> conf/examples/1GB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/1GB/native-standalone/slaves 63fb8bb
> conf/examples/1GB/native-standalone/tracers 63fb8bb
> conf/examples/1GB/standalone/accumulo-env.sh 8b904ac
> conf/examples/1GB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/1GB/standalone/accumulo-site.xml 1bca857
> conf/examples/1GB/standalone/auditLog.xml 9b7987e
> conf/examples/1GB/standalone/gc 63fb8bb
> conf/examples/1GB/standalone/generic_logger.xml 4d2af90
> conf/examples/1GB/standalone/log4j.properties a4bcb2e
> conf/examples/1GB/standalone/masters 63fb8bb
> conf/examples/1GB/standalone/monitor 63fb8bb
> conf/examples/1GB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/1GB/standalone/slaves 63fb8bb
> conf/examples/1GB/standalone/tracers 63fb8bb
> conf/examples/2GB/native-standalone/accumulo-env.sh 5f6d2cb
> conf/examples/2GB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/2GB/native-standalone/accumulo-site.xml 9eaa5ff
> conf/examples/2GB/native-standalone/auditLog.xml 9b7987e
> conf/examples/2GB/native-standalone/gc 63fb8bb
> conf/examples/2GB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/2GB/native-standalone/log4j.properties a4bcb2e
> conf/examples/2GB/native-standalone/masters 63fb8bb
> conf/examples/2GB/native-standalone/monitor 63fb8bb
> conf/examples/2GB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/2GB/native-standalone/slaves 63fb8bb
> conf/examples/2GB/native-standalone/tracers 63fb8bb
> conf/examples/2GB/standalone/accumulo-env.sh feba48c
> conf/examples/2GB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/2GB/standalone/accumulo-site.xml c9e0309
> conf/examples/2GB/standalone/auditLog.xml 9b7987e
> conf/examples/2GB/standalone/gc 63fb8bb
> conf/examples/2GB/standalone/generic_logger.xml 4d2af90
> conf/examples/2GB/standalone/log4j.properties a4bcb2e
> conf/examples/2GB/standalone/masters 63fb8bb
> conf/examples/2GB/standalone/monitor 63fb8bb
> conf/examples/2GB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/2GB/standalone/slaves 63fb8bb
> conf/examples/2GB/standalone/tracers 63fb8bb
> conf/examples/3GB/native-standalone/accumulo-env.sh be72992
> conf/examples/3GB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/3GB/native-standalone/accumulo-site.xml 9b82ed3
> conf/examples/3GB/native-standalone/auditLog.xml 9b7987e
> conf/examples/3GB/native-standalone/gc 63fb8bb
> conf/examples/3GB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/3GB/native-standalone/log4j.properties a4bcb2e
> conf/examples/3GB/native-standalone/masters 63fb8bb
> conf/examples/3GB/native-standalone/monitor 63fb8bb
> conf/examples/3GB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/3GB/native-standalone/slaves 63fb8bb
> conf/examples/3GB/native-standalone/tracers 63fb8bb
> conf/examples/3GB/standalone/accumulo-env.sh 6e5fb3a
> conf/examples/3GB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/3GB/standalone/accumulo-site.xml a127cbd
> conf/examples/3GB/standalone/auditLog.xml 9b7987e
> conf/examples/3GB/standalone/gc 63fb8bb
> conf/examples/3GB/standalone/generic_logger.xml 4d2af90
> conf/examples/3GB/standalone/log4j.properties a4bcb2e
> conf/examples/3GB/standalone/masters 63fb8bb
> conf/examples/3GB/standalone/monitor 63fb8bb
> conf/examples/3GB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/3GB/standalone/slaves 63fb8bb
> conf/examples/3GB/standalone/tracers 63fb8bb
> conf/examples/512MB/native-standalone/accumulo-env.sh e02b524
> conf/examples/512MB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/512MB/native-standalone/accumulo-site.xml 0e8bdb2
> conf/examples/512MB/native-standalone/auditLog.xml 9b7987e
> conf/examples/512MB/native-standalone/gc 63fb8bb
> conf/examples/512MB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/512MB/native-standalone/log4j.properties a4bcb2e
> conf/examples/512MB/native-standalone/masters 63fb8bb
> conf/examples/512MB/native-standalone/monitor 63fb8bb
> conf/examples/512MB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/512MB/native-standalone/slaves 63fb8bb
> conf/examples/512MB/native-standalone/tracers 63fb8bb
> conf/examples/512MB/standalone/accumulo-env.sh 457e1d3
> conf/examples/512MB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/512MB/standalone/accumulo-site.xml 1a30ce7
> conf/examples/512MB/standalone/auditLog.xml 9b7987e
> conf/examples/512MB/standalone/gc 63fb8bb
> conf/examples/512MB/standalone/generic_logger.xml 4d2af90
> conf/examples/512MB/standalone/log4j.properties a4bcb2e
> conf/examples/512MB/standalone/masters 63fb8bb
> conf/examples/512MB/standalone/monitor 63fb8bb
> conf/examples/512MB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/512MB/standalone/slaves 63fb8bb
> conf/examples/512MB/standalone/tracers 63fb8bb
> conf/examples/crypto/accumulo-site.xml a7e5c54
> conf/examples/crypto/readme.txt c638b6e
> conf/examples/vfs-classloader/accumulo-site.xml ea95ea2
> conf/templates/accumulo-env.sh PRE-CREATION
> conf/templates/accumulo-metrics.xml PRE-CREATION
> conf/templates/accumulo-site.xml PRE-CREATION
> conf/templates/accumulo.policy.example PRE-CREATION
> conf/templates/gc PRE-CREATION
> conf/templates/generic_logger.xml PRE-CREATION
> conf/templates/log4j.properties PRE-CREATION
> conf/templates/masters PRE-CREATION
> conf/templates/monitor PRE-CREATION
> conf/templates/monitor_logger.xml PRE-CREATION
> conf/templates/slaves PRE-CREATION
> conf/templates/tracers PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18438/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> John McNamee
>
>
Re: Review Request 18438: ACCUMULO-1395
Posted by John McNamee <jp...@terpmail.umd.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18438/
-----------------------------------------------------------
(Updated March 6, 2014, 8:38 p.m.)
Review request for accumulo.
Changes
-------
Applied some formatting changes.
Implemented some of the suggestions
Attempted to automatically set the LD_LIBRARY_PATH for linux users. Not sure if I should attempt to do so for mac os x users as well
Bugs: ACCUMULO-1395
https://issues.apache.org/jira/browse/ACCUMULO-1395
Repository: accumulo
Description
-------
Generate example configuration
Diffs (updated)
-----
assemble/pom.xml 5a1d8e3
assemble/src/main/assemblies/component.xml fa53d5e
bin/bootstrap_config.sh be472d3
conf/accumulo.policy.example 2964f06
conf/examples/1GB/native-standalone/accumulo-env.sh 9e9b6a6
conf/examples/1GB/native-standalone/accumulo-metrics.xml 60f9f8d
conf/examples/1GB/native-standalone/accumulo-site.xml b68059c
conf/examples/1GB/native-standalone/auditLog.xml 9b7987e
conf/examples/1GB/native-standalone/gc 63fb8bb
conf/examples/1GB/native-standalone/generic_logger.xml 4d2af90
conf/examples/1GB/native-standalone/log4j.properties a4bcb2e
conf/examples/1GB/native-standalone/masters 63fb8bb
conf/examples/1GB/native-standalone/monitor 63fb8bb
conf/examples/1GB/native-standalone/monitor_logger.xml 3a63bf4
conf/examples/1GB/native-standalone/slaves 63fb8bb
conf/examples/1GB/native-standalone/tracers 63fb8bb
conf/examples/1GB/standalone/accumulo-env.sh 8b904ac
conf/examples/1GB/standalone/accumulo-metrics.xml 60f9f8d
conf/examples/1GB/standalone/accumulo-site.xml 1bca857
conf/examples/1GB/standalone/auditLog.xml 9b7987e
conf/examples/1GB/standalone/gc 63fb8bb
conf/examples/1GB/standalone/generic_logger.xml 4d2af90
conf/examples/1GB/standalone/log4j.properties a4bcb2e
conf/examples/1GB/standalone/masters 63fb8bb
conf/examples/1GB/standalone/monitor 63fb8bb
conf/examples/1GB/standalone/monitor_logger.xml 3a63bf4
conf/examples/1GB/standalone/slaves 63fb8bb
conf/examples/1GB/standalone/tracers 63fb8bb
conf/examples/2GB/native-standalone/accumulo-env.sh 5f6d2cb
conf/examples/2GB/native-standalone/accumulo-metrics.xml 60f9f8d
conf/examples/2GB/native-standalone/accumulo-site.xml 9eaa5ff
conf/examples/2GB/native-standalone/auditLog.xml 9b7987e
conf/examples/2GB/native-standalone/gc 63fb8bb
conf/examples/2GB/native-standalone/generic_logger.xml 4d2af90
conf/examples/2GB/native-standalone/log4j.properties a4bcb2e
conf/examples/2GB/native-standalone/masters 63fb8bb
conf/examples/2GB/native-standalone/monitor 63fb8bb
conf/examples/2GB/native-standalone/monitor_logger.xml 3a63bf4
conf/examples/2GB/native-standalone/slaves 63fb8bb
conf/examples/2GB/native-standalone/tracers 63fb8bb
conf/examples/2GB/standalone/accumulo-env.sh feba48c
conf/examples/2GB/standalone/accumulo-metrics.xml 60f9f8d
conf/examples/2GB/standalone/accumulo-site.xml c9e0309
conf/examples/2GB/standalone/auditLog.xml 9b7987e
conf/examples/2GB/standalone/gc 63fb8bb
conf/examples/2GB/standalone/generic_logger.xml 4d2af90
conf/examples/2GB/standalone/log4j.properties a4bcb2e
conf/examples/2GB/standalone/masters 63fb8bb
conf/examples/2GB/standalone/monitor 63fb8bb
conf/examples/2GB/standalone/monitor_logger.xml 3a63bf4
conf/examples/2GB/standalone/slaves 63fb8bb
conf/examples/2GB/standalone/tracers 63fb8bb
conf/examples/3GB/native-standalone/accumulo-env.sh be72992
conf/examples/3GB/native-standalone/accumulo-metrics.xml 60f9f8d
conf/examples/3GB/native-standalone/accumulo-site.xml 9b82ed3
conf/examples/3GB/native-standalone/auditLog.xml 9b7987e
conf/examples/3GB/native-standalone/gc 63fb8bb
conf/examples/3GB/native-standalone/generic_logger.xml 4d2af90
conf/examples/3GB/native-standalone/log4j.properties a4bcb2e
conf/examples/3GB/native-standalone/masters 63fb8bb
conf/examples/3GB/native-standalone/monitor 63fb8bb
conf/examples/3GB/native-standalone/monitor_logger.xml 3a63bf4
conf/examples/3GB/native-standalone/slaves 63fb8bb
conf/examples/3GB/native-standalone/tracers 63fb8bb
conf/examples/3GB/standalone/accumulo-env.sh 6e5fb3a
conf/examples/3GB/standalone/accumulo-metrics.xml 60f9f8d
conf/examples/3GB/standalone/accumulo-site.xml a127cbd
conf/examples/3GB/standalone/auditLog.xml 9b7987e
conf/examples/3GB/standalone/gc 63fb8bb
conf/examples/3GB/standalone/generic_logger.xml 4d2af90
conf/examples/3GB/standalone/log4j.properties a4bcb2e
conf/examples/3GB/standalone/masters 63fb8bb
conf/examples/3GB/standalone/monitor 63fb8bb
conf/examples/3GB/standalone/monitor_logger.xml 3a63bf4
conf/examples/3GB/standalone/slaves 63fb8bb
conf/examples/3GB/standalone/tracers 63fb8bb
conf/examples/512MB/native-standalone/accumulo-env.sh e02b524
conf/examples/512MB/native-standalone/accumulo-metrics.xml 60f9f8d
conf/examples/512MB/native-standalone/accumulo-site.xml 0e8bdb2
conf/examples/512MB/native-standalone/auditLog.xml 9b7987e
conf/examples/512MB/native-standalone/gc 63fb8bb
conf/examples/512MB/native-standalone/generic_logger.xml 4d2af90
conf/examples/512MB/native-standalone/log4j.properties a4bcb2e
conf/examples/512MB/native-standalone/masters 63fb8bb
conf/examples/512MB/native-standalone/monitor 63fb8bb
conf/examples/512MB/native-standalone/monitor_logger.xml 3a63bf4
conf/examples/512MB/native-standalone/slaves 63fb8bb
conf/examples/512MB/native-standalone/tracers 63fb8bb
conf/examples/512MB/standalone/accumulo-env.sh 457e1d3
conf/examples/512MB/standalone/accumulo-metrics.xml 60f9f8d
conf/examples/512MB/standalone/accumulo-site.xml 1a30ce7
conf/examples/512MB/standalone/auditLog.xml 9b7987e
conf/examples/512MB/standalone/gc 63fb8bb
conf/examples/512MB/standalone/generic_logger.xml 4d2af90
conf/examples/512MB/standalone/log4j.properties a4bcb2e
conf/examples/512MB/standalone/masters 63fb8bb
conf/examples/512MB/standalone/monitor 63fb8bb
conf/examples/512MB/standalone/monitor_logger.xml 3a63bf4
conf/examples/512MB/standalone/slaves 63fb8bb
conf/examples/512MB/standalone/tracers 63fb8bb
conf/examples/crypto/accumulo-site.xml a7e5c54
conf/examples/crypto/readme.txt c638b6e
conf/examples/vfs-classloader/accumulo-site.xml ea95ea2
conf/templates/accumulo-env.sh PRE-CREATION
conf/templates/accumulo-metrics.xml PRE-CREATION
conf/templates/accumulo-site.xml PRE-CREATION
conf/templates/accumulo.policy.example PRE-CREATION
conf/templates/gc PRE-CREATION
conf/templates/generic_logger.xml PRE-CREATION
conf/templates/log4j.properties PRE-CREATION
conf/templates/masters PRE-CREATION
conf/templates/monitor PRE-CREATION
conf/templates/monitor_logger.xml PRE-CREATION
conf/templates/slaves PRE-CREATION
conf/templates/tracers PRE-CREATION
Diff: https://reviews.apache.org/r/18438/diff/
Testing
-------
Thanks,
John McNamee
Re: Review Request 18438: ACCUMULO-1395
Posted by John McNamee <jp...@terpmail.umd.edu>.
> On Feb. 28, 2014, 8:54 p.m., Bill Havanki wrote:
> > bin/bootstrap_config.sh, line 282
> > <https://reviews.apache.org/r/18438/diff/2/?file=505961#file505961line282>
> >
> > sed -i can do substitutions inline, although I've found the syntax differs between Linux and Mac OS X. Maybe something to consider.
I am not sure there is a single sed -i -e command that will work on both Linux and Mac OS X. If you know of one I would be happy to implement it but I figured this way would be safer.
> On Feb. 28, 2014, 8:54 p.m., Bill Havanki wrote:
> > bin/bootstrap_config.sh, line 92
> > <https://reviews.apache.org/r/18438/diff/2/?file=505961#file505961line92>
> >
> > I would expect -h to quit the script, regardless of the rest of the options.
Good catch I have addressed this in my latest patch.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18438/#review35837
-----------------------------------------------------------
On March 6, 2014, 8:38 p.m., John McNamee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18438/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 8:38 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1395
> https://issues.apache.org/jira/browse/ACCUMULO-1395
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Generate example configuration
>
>
> Diffs
> -----
>
> assemble/pom.xml 5a1d8e3
> assemble/src/main/assemblies/component.xml fa53d5e
> bin/bootstrap_config.sh be472d3
> conf/accumulo.policy.example 2964f06
> conf/examples/1GB/native-standalone/accumulo-env.sh 9e9b6a6
> conf/examples/1GB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/1GB/native-standalone/accumulo-site.xml b68059c
> conf/examples/1GB/native-standalone/auditLog.xml 9b7987e
> conf/examples/1GB/native-standalone/gc 63fb8bb
> conf/examples/1GB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/1GB/native-standalone/log4j.properties a4bcb2e
> conf/examples/1GB/native-standalone/masters 63fb8bb
> conf/examples/1GB/native-standalone/monitor 63fb8bb
> conf/examples/1GB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/1GB/native-standalone/slaves 63fb8bb
> conf/examples/1GB/native-standalone/tracers 63fb8bb
> conf/examples/1GB/standalone/accumulo-env.sh 8b904ac
> conf/examples/1GB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/1GB/standalone/accumulo-site.xml 1bca857
> conf/examples/1GB/standalone/auditLog.xml 9b7987e
> conf/examples/1GB/standalone/gc 63fb8bb
> conf/examples/1GB/standalone/generic_logger.xml 4d2af90
> conf/examples/1GB/standalone/log4j.properties a4bcb2e
> conf/examples/1GB/standalone/masters 63fb8bb
> conf/examples/1GB/standalone/monitor 63fb8bb
> conf/examples/1GB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/1GB/standalone/slaves 63fb8bb
> conf/examples/1GB/standalone/tracers 63fb8bb
> conf/examples/2GB/native-standalone/accumulo-env.sh 5f6d2cb
> conf/examples/2GB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/2GB/native-standalone/accumulo-site.xml 9eaa5ff
> conf/examples/2GB/native-standalone/auditLog.xml 9b7987e
> conf/examples/2GB/native-standalone/gc 63fb8bb
> conf/examples/2GB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/2GB/native-standalone/log4j.properties a4bcb2e
> conf/examples/2GB/native-standalone/masters 63fb8bb
> conf/examples/2GB/native-standalone/monitor 63fb8bb
> conf/examples/2GB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/2GB/native-standalone/slaves 63fb8bb
> conf/examples/2GB/native-standalone/tracers 63fb8bb
> conf/examples/2GB/standalone/accumulo-env.sh feba48c
> conf/examples/2GB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/2GB/standalone/accumulo-site.xml c9e0309
> conf/examples/2GB/standalone/auditLog.xml 9b7987e
> conf/examples/2GB/standalone/gc 63fb8bb
> conf/examples/2GB/standalone/generic_logger.xml 4d2af90
> conf/examples/2GB/standalone/log4j.properties a4bcb2e
> conf/examples/2GB/standalone/masters 63fb8bb
> conf/examples/2GB/standalone/monitor 63fb8bb
> conf/examples/2GB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/2GB/standalone/slaves 63fb8bb
> conf/examples/2GB/standalone/tracers 63fb8bb
> conf/examples/3GB/native-standalone/accumulo-env.sh be72992
> conf/examples/3GB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/3GB/native-standalone/accumulo-site.xml 9b82ed3
> conf/examples/3GB/native-standalone/auditLog.xml 9b7987e
> conf/examples/3GB/native-standalone/gc 63fb8bb
> conf/examples/3GB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/3GB/native-standalone/log4j.properties a4bcb2e
> conf/examples/3GB/native-standalone/masters 63fb8bb
> conf/examples/3GB/native-standalone/monitor 63fb8bb
> conf/examples/3GB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/3GB/native-standalone/slaves 63fb8bb
> conf/examples/3GB/native-standalone/tracers 63fb8bb
> conf/examples/3GB/standalone/accumulo-env.sh 6e5fb3a
> conf/examples/3GB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/3GB/standalone/accumulo-site.xml a127cbd
> conf/examples/3GB/standalone/auditLog.xml 9b7987e
> conf/examples/3GB/standalone/gc 63fb8bb
> conf/examples/3GB/standalone/generic_logger.xml 4d2af90
> conf/examples/3GB/standalone/log4j.properties a4bcb2e
> conf/examples/3GB/standalone/masters 63fb8bb
> conf/examples/3GB/standalone/monitor 63fb8bb
> conf/examples/3GB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/3GB/standalone/slaves 63fb8bb
> conf/examples/3GB/standalone/tracers 63fb8bb
> conf/examples/512MB/native-standalone/accumulo-env.sh e02b524
> conf/examples/512MB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/512MB/native-standalone/accumulo-site.xml 0e8bdb2
> conf/examples/512MB/native-standalone/auditLog.xml 9b7987e
> conf/examples/512MB/native-standalone/gc 63fb8bb
> conf/examples/512MB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/512MB/native-standalone/log4j.properties a4bcb2e
> conf/examples/512MB/native-standalone/masters 63fb8bb
> conf/examples/512MB/native-standalone/monitor 63fb8bb
> conf/examples/512MB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/512MB/native-standalone/slaves 63fb8bb
> conf/examples/512MB/native-standalone/tracers 63fb8bb
> conf/examples/512MB/standalone/accumulo-env.sh 457e1d3
> conf/examples/512MB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/512MB/standalone/accumulo-site.xml 1a30ce7
> conf/examples/512MB/standalone/auditLog.xml 9b7987e
> conf/examples/512MB/standalone/gc 63fb8bb
> conf/examples/512MB/standalone/generic_logger.xml 4d2af90
> conf/examples/512MB/standalone/log4j.properties a4bcb2e
> conf/examples/512MB/standalone/masters 63fb8bb
> conf/examples/512MB/standalone/monitor 63fb8bb
> conf/examples/512MB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/512MB/standalone/slaves 63fb8bb
> conf/examples/512MB/standalone/tracers 63fb8bb
> conf/examples/crypto/accumulo-site.xml a7e5c54
> conf/examples/crypto/readme.txt c638b6e
> conf/examples/vfs-classloader/accumulo-site.xml ea95ea2
> conf/templates/accumulo-env.sh PRE-CREATION
> conf/templates/accumulo-metrics.xml PRE-CREATION
> conf/templates/accumulo-site.xml PRE-CREATION
> conf/templates/accumulo.policy.example PRE-CREATION
> conf/templates/gc PRE-CREATION
> conf/templates/generic_logger.xml PRE-CREATION
> conf/templates/log4j.properties PRE-CREATION
> conf/templates/masters PRE-CREATION
> conf/templates/monitor PRE-CREATION
> conf/templates/monitor_logger.xml PRE-CREATION
> conf/templates/slaves PRE-CREATION
> conf/templates/tracers PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18438/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> John McNamee
>
>
Re: Review Request 18438: ACCUMULO-1395
Posted by Bill Havanki <bh...@clouderagovt.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18438/#review35837
-----------------------------------------------------------
bin/bootstrap_config.sh
<https://reviews.apache.org/r/18438/#comment66607>
To parallel the other option descriptions, this could be just "Supported Apache Hadoop version: '1' '2'". In any event, "Specifie" isn't a word :)
bin/bootstrap_config.sh
<https://reviews.apache.org/r/18438/#comment66608>
I would expect -h to quit the script, regardless of the rest of the options.
bin/bootstrap_config.sh
<https://reviews.apache.org/r/18438/#comment66612>
sed -i can do substitutions inline, although I've found the syntax differs between Linux and Mac OS X. Maybe something to consider.
- Bill Havanki
On Feb. 27, 2014, 9:52 a.m., John McNamee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18438/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2014, 9:52 a.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1395
> https://issues.apache.org/jira/browse/ACCUMULO-1395
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Generate example configuration
>
>
> Diffs
> -----
>
> assemble/pom.xml 5a1d8e3
> assemble/src/main/assemblies/component.xml fa53d5e
> bin/bootstrap_config.sh be472d3
> conf/accumulo.policy.example 2964f06
> conf/examples/1GB/native-standalone/accumulo-env.sh 9e9b6a6
> conf/examples/1GB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/1GB/native-standalone/accumulo-site.xml b68059c
> conf/examples/1GB/native-standalone/auditLog.xml 9b7987e
> conf/examples/1GB/native-standalone/gc 63fb8bb
> conf/examples/1GB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/1GB/native-standalone/log4j.properties a4bcb2e
> conf/examples/1GB/native-standalone/masters 63fb8bb
> conf/examples/1GB/native-standalone/monitor 63fb8bb
> conf/examples/1GB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/1GB/native-standalone/slaves 63fb8bb
> conf/examples/1GB/native-standalone/tracers 63fb8bb
> conf/examples/1GB/standalone/accumulo-env.sh 8b904ac
> conf/examples/1GB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/1GB/standalone/accumulo-site.xml 1bca857
> conf/examples/1GB/standalone/auditLog.xml 9b7987e
> conf/examples/1GB/standalone/gc 63fb8bb
> conf/examples/1GB/standalone/generic_logger.xml 4d2af90
> conf/examples/1GB/standalone/log4j.properties a4bcb2e
> conf/examples/1GB/standalone/masters 63fb8bb
> conf/examples/1GB/standalone/monitor 63fb8bb
> conf/examples/1GB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/1GB/standalone/slaves 63fb8bb
> conf/examples/1GB/standalone/tracers 63fb8bb
> conf/examples/2GB/native-standalone/accumulo-env.sh 5f6d2cb
> conf/examples/2GB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/2GB/native-standalone/accumulo-site.xml 9eaa5ff
> conf/examples/2GB/native-standalone/auditLog.xml 9b7987e
> conf/examples/2GB/native-standalone/gc 63fb8bb
> conf/examples/2GB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/2GB/native-standalone/log4j.properties a4bcb2e
> conf/examples/2GB/native-standalone/masters 63fb8bb
> conf/examples/2GB/native-standalone/monitor 63fb8bb
> conf/examples/2GB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/2GB/native-standalone/slaves 63fb8bb
> conf/examples/2GB/native-standalone/tracers 63fb8bb
> conf/examples/2GB/standalone/accumulo-env.sh feba48c
> conf/examples/2GB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/2GB/standalone/accumulo-site.xml c9e0309
> conf/examples/2GB/standalone/auditLog.xml 9b7987e
> conf/examples/2GB/standalone/gc 63fb8bb
> conf/examples/2GB/standalone/generic_logger.xml 4d2af90
> conf/examples/2GB/standalone/log4j.properties a4bcb2e
> conf/examples/2GB/standalone/masters 63fb8bb
> conf/examples/2GB/standalone/monitor 63fb8bb
> conf/examples/2GB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/2GB/standalone/slaves 63fb8bb
> conf/examples/2GB/standalone/tracers 63fb8bb
> conf/examples/3GB/native-standalone/accumulo-env.sh be72992
> conf/examples/3GB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/3GB/native-standalone/accumulo-site.xml 9b82ed3
> conf/examples/3GB/native-standalone/auditLog.xml 9b7987e
> conf/examples/3GB/native-standalone/gc 63fb8bb
> conf/examples/3GB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/3GB/native-standalone/log4j.properties a4bcb2e
> conf/examples/3GB/native-standalone/masters 63fb8bb
> conf/examples/3GB/native-standalone/monitor 63fb8bb
> conf/examples/3GB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/3GB/native-standalone/slaves 63fb8bb
> conf/examples/3GB/native-standalone/tracers 63fb8bb
> conf/examples/3GB/standalone/accumulo-env.sh 6e5fb3a
> conf/examples/3GB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/3GB/standalone/accumulo-site.xml a127cbd
> conf/examples/3GB/standalone/auditLog.xml 9b7987e
> conf/examples/3GB/standalone/gc 63fb8bb
> conf/examples/3GB/standalone/generic_logger.xml 4d2af90
> conf/examples/3GB/standalone/log4j.properties a4bcb2e
> conf/examples/3GB/standalone/masters 63fb8bb
> conf/examples/3GB/standalone/monitor 63fb8bb
> conf/examples/3GB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/3GB/standalone/slaves 63fb8bb
> conf/examples/3GB/standalone/tracers 63fb8bb
> conf/examples/512MB/native-standalone/accumulo-env.sh e02b524
> conf/examples/512MB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/512MB/native-standalone/accumulo-site.xml 0e8bdb2
> conf/examples/512MB/native-standalone/auditLog.xml 9b7987e
> conf/examples/512MB/native-standalone/gc 63fb8bb
> conf/examples/512MB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/512MB/native-standalone/log4j.properties a4bcb2e
> conf/examples/512MB/native-standalone/masters 63fb8bb
> conf/examples/512MB/native-standalone/monitor 63fb8bb
> conf/examples/512MB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/512MB/native-standalone/slaves 63fb8bb
> conf/examples/512MB/native-standalone/tracers 63fb8bb
> conf/examples/512MB/standalone/accumulo-env.sh 457e1d3
> conf/examples/512MB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/512MB/standalone/accumulo-site.xml 1a30ce7
> conf/examples/512MB/standalone/auditLog.xml 9b7987e
> conf/examples/512MB/standalone/gc 63fb8bb
> conf/examples/512MB/standalone/generic_logger.xml 4d2af90
> conf/examples/512MB/standalone/log4j.properties a4bcb2e
> conf/examples/512MB/standalone/masters 63fb8bb
> conf/examples/512MB/standalone/monitor 63fb8bb
> conf/examples/512MB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/512MB/standalone/slaves 63fb8bb
> conf/examples/512MB/standalone/tracers 63fb8bb
> conf/examples/crypto/accumulo-site.xml a7e5c54
> conf/examples/crypto/readme.txt c638b6e
> conf/examples/vfs-classloader/accumulo-site.xml ea95ea2
> conf/templates/accumulo-env.sh PRE-CREATION
> conf/templates/accumulo-metrics.xml PRE-CREATION
> conf/templates/accumulo-site.xml PRE-CREATION
> conf/templates/accumulo.policy.example PRE-CREATION
> conf/templates/gc PRE-CREATION
> conf/templates/generic_logger.xml PRE-CREATION
> conf/templates/log4j.properties PRE-CREATION
> conf/templates/masters PRE-CREATION
> conf/templates/monitor PRE-CREATION
> conf/templates/monitor_logger.xml PRE-CREATION
> conf/templates/slaves PRE-CREATION
> conf/templates/tracers PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18438/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> John McNamee
>
>
Re: Review Request 18438: ACCUMULO-1395
Posted by John McNamee <jp...@terpmail.umd.edu>.
> On Feb. 28, 2014, 1:37 p.m., Mike Drob wrote:
> > bin/bootstrap_config.sh, line 188
> > <https://reviews.apache.org/r/18438/diff/1/?file=502514#file502514line188>
> >
> > if the user selected an out-of-range option, then DIRNAME will be empty. That's an easier check to perform.
This check is there incase the user used the command line argument -s to set the SIZE variable (bypassing the select statement) and tried to set an unsupported size.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18438/#review35778
-----------------------------------------------------------
On Feb. 27, 2014, 2:52 p.m., John McNamee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18438/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2014, 2:52 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1395
> https://issues.apache.org/jira/browse/ACCUMULO-1395
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Generate example configuration
>
>
> Diffs
> -----
>
> assemble/pom.xml 5a1d8e3
> assemble/src/main/assemblies/component.xml fa53d5e
> bin/bootstrap_config.sh be472d3
> conf/accumulo.policy.example 2964f06
> conf/examples/1GB/native-standalone/accumulo-env.sh 9e9b6a6
> conf/examples/1GB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/1GB/native-standalone/accumulo-site.xml b68059c
> conf/examples/1GB/native-standalone/auditLog.xml 9b7987e
> conf/examples/1GB/native-standalone/gc 63fb8bb
> conf/examples/1GB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/1GB/native-standalone/log4j.properties a4bcb2e
> conf/examples/1GB/native-standalone/masters 63fb8bb
> conf/examples/1GB/native-standalone/monitor 63fb8bb
> conf/examples/1GB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/1GB/native-standalone/slaves 63fb8bb
> conf/examples/1GB/native-standalone/tracers 63fb8bb
> conf/examples/1GB/standalone/accumulo-env.sh 8b904ac
> conf/examples/1GB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/1GB/standalone/accumulo-site.xml 1bca857
> conf/examples/1GB/standalone/auditLog.xml 9b7987e
> conf/examples/1GB/standalone/gc 63fb8bb
> conf/examples/1GB/standalone/generic_logger.xml 4d2af90
> conf/examples/1GB/standalone/log4j.properties a4bcb2e
> conf/examples/1GB/standalone/masters 63fb8bb
> conf/examples/1GB/standalone/monitor 63fb8bb
> conf/examples/1GB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/1GB/standalone/slaves 63fb8bb
> conf/examples/1GB/standalone/tracers 63fb8bb
> conf/examples/2GB/native-standalone/accumulo-env.sh 5f6d2cb
> conf/examples/2GB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/2GB/native-standalone/accumulo-site.xml 9eaa5ff
> conf/examples/2GB/native-standalone/auditLog.xml 9b7987e
> conf/examples/2GB/native-standalone/gc 63fb8bb
> conf/examples/2GB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/2GB/native-standalone/log4j.properties a4bcb2e
> conf/examples/2GB/native-standalone/masters 63fb8bb
> conf/examples/2GB/native-standalone/monitor 63fb8bb
> conf/examples/2GB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/2GB/native-standalone/slaves 63fb8bb
> conf/examples/2GB/native-standalone/tracers 63fb8bb
> conf/examples/2GB/standalone/accumulo-env.sh feba48c
> conf/examples/2GB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/2GB/standalone/accumulo-site.xml c9e0309
> conf/examples/2GB/standalone/auditLog.xml 9b7987e
> conf/examples/2GB/standalone/gc 63fb8bb
> conf/examples/2GB/standalone/generic_logger.xml 4d2af90
> conf/examples/2GB/standalone/log4j.properties a4bcb2e
> conf/examples/2GB/standalone/masters 63fb8bb
> conf/examples/2GB/standalone/monitor 63fb8bb
> conf/examples/2GB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/2GB/standalone/slaves 63fb8bb
> conf/examples/2GB/standalone/tracers 63fb8bb
> conf/examples/3GB/native-standalone/accumulo-env.sh be72992
> conf/examples/3GB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/3GB/native-standalone/accumulo-site.xml 9b82ed3
> conf/examples/3GB/native-standalone/auditLog.xml 9b7987e
> conf/examples/3GB/native-standalone/gc 63fb8bb
> conf/examples/3GB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/3GB/native-standalone/log4j.properties a4bcb2e
> conf/examples/3GB/native-standalone/masters 63fb8bb
> conf/examples/3GB/native-standalone/monitor 63fb8bb
> conf/examples/3GB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/3GB/native-standalone/slaves 63fb8bb
> conf/examples/3GB/native-standalone/tracers 63fb8bb
> conf/examples/3GB/standalone/accumulo-env.sh 6e5fb3a
> conf/examples/3GB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/3GB/standalone/accumulo-site.xml a127cbd
> conf/examples/3GB/standalone/auditLog.xml 9b7987e
> conf/examples/3GB/standalone/gc 63fb8bb
> conf/examples/3GB/standalone/generic_logger.xml 4d2af90
> conf/examples/3GB/standalone/log4j.properties a4bcb2e
> conf/examples/3GB/standalone/masters 63fb8bb
> conf/examples/3GB/standalone/monitor 63fb8bb
> conf/examples/3GB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/3GB/standalone/slaves 63fb8bb
> conf/examples/3GB/standalone/tracers 63fb8bb
> conf/examples/512MB/native-standalone/accumulo-env.sh e02b524
> conf/examples/512MB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/512MB/native-standalone/accumulo-site.xml 0e8bdb2
> conf/examples/512MB/native-standalone/auditLog.xml 9b7987e
> conf/examples/512MB/native-standalone/gc 63fb8bb
> conf/examples/512MB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/512MB/native-standalone/log4j.properties a4bcb2e
> conf/examples/512MB/native-standalone/masters 63fb8bb
> conf/examples/512MB/native-standalone/monitor 63fb8bb
> conf/examples/512MB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/512MB/native-standalone/slaves 63fb8bb
> conf/examples/512MB/native-standalone/tracers 63fb8bb
> conf/examples/512MB/standalone/accumulo-env.sh 457e1d3
> conf/examples/512MB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/512MB/standalone/accumulo-site.xml 1a30ce7
> conf/examples/512MB/standalone/auditLog.xml 9b7987e
> conf/examples/512MB/standalone/gc 63fb8bb
> conf/examples/512MB/standalone/generic_logger.xml 4d2af90
> conf/examples/512MB/standalone/log4j.properties a4bcb2e
> conf/examples/512MB/standalone/masters 63fb8bb
> conf/examples/512MB/standalone/monitor 63fb8bb
> conf/examples/512MB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/512MB/standalone/slaves 63fb8bb
> conf/examples/512MB/standalone/tracers 63fb8bb
> conf/examples/crypto/accumulo-site.xml a7e5c54
> conf/examples/crypto/readme.txt c638b6e
> conf/examples/vfs-classloader/accumulo-site.xml ea95ea2
> conf/templates/accumulo-env.sh PRE-CREATION
> conf/templates/accumulo-metrics.xml PRE-CREATION
> conf/templates/accumulo-site.xml PRE-CREATION
> conf/templates/accumulo.policy.example PRE-CREATION
> conf/templates/gc PRE-CREATION
> conf/templates/generic_logger.xml PRE-CREATION
> conf/templates/log4j.properties PRE-CREATION
> conf/templates/masters PRE-CREATION
> conf/templates/monitor PRE-CREATION
> conf/templates/monitor_logger.xml PRE-CREATION
> conf/templates/slaves PRE-CREATION
> conf/templates/tracers PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18438/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> John McNamee
>
>
Re: Review Request 18438: ACCUMULO-1395
Posted by Christopher Tubbs <ct...@apache.org>.
> On Feb. 28, 2014, 8:37 a.m., Mike Drob wrote:
> > bin/bootstrap_config.sh, line 48
> > <https://reviews.apache.org/r/18438/diff/1/?file=502514#file502514line48>
> >
> > Should also respect the ACCUMULO_CONF_DIR environment variable that other processes can use.
Mike, I don't think this is valid. This CONF_DIR is unrelated to the bin/accumulo ACCUMULO_CONF_DIR. This is a variable that is used internally, for the output location. This script *creates* the accumulo-env.sh script that contains the ACCUMULO_CONF_DIR variable for bin/accumulo, so it cannot depend on it. It could interpret it from the user's environment, but I think that's making too many assumptions. This script has the option to specify an alternate output directory, but uses $ACCUMULO_HOME/conf by default. Its similarity to the ACCUMULO_CONF_DIR is coincidental. It's just an internal variable name for the default output location for this script.
- Christopher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18438/#review35778
-----------------------------------------------------------
On Feb. 27, 2014, 9:52 a.m., John McNamee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18438/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2014, 9:52 a.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1395
> https://issues.apache.org/jira/browse/ACCUMULO-1395
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Generate example configuration
>
>
> Diffs
> -----
>
> assemble/pom.xml 5a1d8e3
> assemble/src/main/assemblies/component.xml fa53d5e
> bin/bootstrap_config.sh be472d3
> conf/accumulo.policy.example 2964f06
> conf/examples/1GB/native-standalone/accumulo-env.sh 9e9b6a6
> conf/examples/1GB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/1GB/native-standalone/accumulo-site.xml b68059c
> conf/examples/1GB/native-standalone/auditLog.xml 9b7987e
> conf/examples/1GB/native-standalone/gc 63fb8bb
> conf/examples/1GB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/1GB/native-standalone/log4j.properties a4bcb2e
> conf/examples/1GB/native-standalone/masters 63fb8bb
> conf/examples/1GB/native-standalone/monitor 63fb8bb
> conf/examples/1GB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/1GB/native-standalone/slaves 63fb8bb
> conf/examples/1GB/native-standalone/tracers 63fb8bb
> conf/examples/1GB/standalone/accumulo-env.sh 8b904ac
> conf/examples/1GB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/1GB/standalone/accumulo-site.xml 1bca857
> conf/examples/1GB/standalone/auditLog.xml 9b7987e
> conf/examples/1GB/standalone/gc 63fb8bb
> conf/examples/1GB/standalone/generic_logger.xml 4d2af90
> conf/examples/1GB/standalone/log4j.properties a4bcb2e
> conf/examples/1GB/standalone/masters 63fb8bb
> conf/examples/1GB/standalone/monitor 63fb8bb
> conf/examples/1GB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/1GB/standalone/slaves 63fb8bb
> conf/examples/1GB/standalone/tracers 63fb8bb
> conf/examples/2GB/native-standalone/accumulo-env.sh 5f6d2cb
> conf/examples/2GB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/2GB/native-standalone/accumulo-site.xml 9eaa5ff
> conf/examples/2GB/native-standalone/auditLog.xml 9b7987e
> conf/examples/2GB/native-standalone/gc 63fb8bb
> conf/examples/2GB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/2GB/native-standalone/log4j.properties a4bcb2e
> conf/examples/2GB/native-standalone/masters 63fb8bb
> conf/examples/2GB/native-standalone/monitor 63fb8bb
> conf/examples/2GB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/2GB/native-standalone/slaves 63fb8bb
> conf/examples/2GB/native-standalone/tracers 63fb8bb
> conf/examples/2GB/standalone/accumulo-env.sh feba48c
> conf/examples/2GB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/2GB/standalone/accumulo-site.xml c9e0309
> conf/examples/2GB/standalone/auditLog.xml 9b7987e
> conf/examples/2GB/standalone/gc 63fb8bb
> conf/examples/2GB/standalone/generic_logger.xml 4d2af90
> conf/examples/2GB/standalone/log4j.properties a4bcb2e
> conf/examples/2GB/standalone/masters 63fb8bb
> conf/examples/2GB/standalone/monitor 63fb8bb
> conf/examples/2GB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/2GB/standalone/slaves 63fb8bb
> conf/examples/2GB/standalone/tracers 63fb8bb
> conf/examples/3GB/native-standalone/accumulo-env.sh be72992
> conf/examples/3GB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/3GB/native-standalone/accumulo-site.xml 9b82ed3
> conf/examples/3GB/native-standalone/auditLog.xml 9b7987e
> conf/examples/3GB/native-standalone/gc 63fb8bb
> conf/examples/3GB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/3GB/native-standalone/log4j.properties a4bcb2e
> conf/examples/3GB/native-standalone/masters 63fb8bb
> conf/examples/3GB/native-standalone/monitor 63fb8bb
> conf/examples/3GB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/3GB/native-standalone/slaves 63fb8bb
> conf/examples/3GB/native-standalone/tracers 63fb8bb
> conf/examples/3GB/standalone/accumulo-env.sh 6e5fb3a
> conf/examples/3GB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/3GB/standalone/accumulo-site.xml a127cbd
> conf/examples/3GB/standalone/auditLog.xml 9b7987e
> conf/examples/3GB/standalone/gc 63fb8bb
> conf/examples/3GB/standalone/generic_logger.xml 4d2af90
> conf/examples/3GB/standalone/log4j.properties a4bcb2e
> conf/examples/3GB/standalone/masters 63fb8bb
> conf/examples/3GB/standalone/monitor 63fb8bb
> conf/examples/3GB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/3GB/standalone/slaves 63fb8bb
> conf/examples/3GB/standalone/tracers 63fb8bb
> conf/examples/512MB/native-standalone/accumulo-env.sh e02b524
> conf/examples/512MB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/512MB/native-standalone/accumulo-site.xml 0e8bdb2
> conf/examples/512MB/native-standalone/auditLog.xml 9b7987e
> conf/examples/512MB/native-standalone/gc 63fb8bb
> conf/examples/512MB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/512MB/native-standalone/log4j.properties a4bcb2e
> conf/examples/512MB/native-standalone/masters 63fb8bb
> conf/examples/512MB/native-standalone/monitor 63fb8bb
> conf/examples/512MB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/512MB/native-standalone/slaves 63fb8bb
> conf/examples/512MB/native-standalone/tracers 63fb8bb
> conf/examples/512MB/standalone/accumulo-env.sh 457e1d3
> conf/examples/512MB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/512MB/standalone/accumulo-site.xml 1a30ce7
> conf/examples/512MB/standalone/auditLog.xml 9b7987e
> conf/examples/512MB/standalone/gc 63fb8bb
> conf/examples/512MB/standalone/generic_logger.xml 4d2af90
> conf/examples/512MB/standalone/log4j.properties a4bcb2e
> conf/examples/512MB/standalone/masters 63fb8bb
> conf/examples/512MB/standalone/monitor 63fb8bb
> conf/examples/512MB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/512MB/standalone/slaves 63fb8bb
> conf/examples/512MB/standalone/tracers 63fb8bb
> conf/examples/crypto/accumulo-site.xml a7e5c54
> conf/examples/crypto/readme.txt c638b6e
> conf/examples/vfs-classloader/accumulo-site.xml ea95ea2
> conf/templates/accumulo-env.sh PRE-CREATION
> conf/templates/accumulo-metrics.xml PRE-CREATION
> conf/templates/accumulo-site.xml PRE-CREATION
> conf/templates/accumulo.policy.example PRE-CREATION
> conf/templates/gc PRE-CREATION
> conf/templates/generic_logger.xml PRE-CREATION
> conf/templates/log4j.properties PRE-CREATION
> conf/templates/masters PRE-CREATION
> conf/templates/monitor PRE-CREATION
> conf/templates/monitor_logger.xml PRE-CREATION
> conf/templates/slaves PRE-CREATION
> conf/templates/tracers PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18438/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> John McNamee
>
>
Re: Review Request 18438: ACCUMULO-1395
Posted by Mike Drob <md...@mdrob.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18438/#review35778
-----------------------------------------------------------
bin/bootstrap_config.sh
<https://reviews.apache.org/r/18438/#comment66523>
Should also respect the ACCUMULO_CONF_DIR environment variable that other processes can use.
bin/bootstrap_config.sh
<https://reviews.apache.org/r/18438/#comment66521>
It looks like if the user enters anything except '2' then it will default to OVERRIDE. I'd rather see an explicit check for that option and only break if we got one of the valid options that we expected.
bin/bootstrap_config.sh
<https://reviews.apache.org/r/18438/#comment66522>
if the user selected an out-of-range option, then DIRNAME will be empty. That's an easier check to perform.
- Mike Drob
On Feb. 27, 2014, 2:52 p.m., John McNamee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18438/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2014, 2:52 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1395
> https://issues.apache.org/jira/browse/ACCUMULO-1395
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Generate example configuration
>
>
> Diffs
> -----
>
> assemble/pom.xml 5a1d8e3
> assemble/src/main/assemblies/component.xml fa53d5e
> bin/bootstrap_config.sh be472d3
> conf/accumulo.policy.example 2964f06
> conf/examples/1GB/native-standalone/accumulo-env.sh 9e9b6a6
> conf/examples/1GB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/1GB/native-standalone/accumulo-site.xml b68059c
> conf/examples/1GB/native-standalone/auditLog.xml 9b7987e
> conf/examples/1GB/native-standalone/gc 63fb8bb
> conf/examples/1GB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/1GB/native-standalone/log4j.properties a4bcb2e
> conf/examples/1GB/native-standalone/masters 63fb8bb
> conf/examples/1GB/native-standalone/monitor 63fb8bb
> conf/examples/1GB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/1GB/native-standalone/slaves 63fb8bb
> conf/examples/1GB/native-standalone/tracers 63fb8bb
> conf/examples/1GB/standalone/accumulo-env.sh 8b904ac
> conf/examples/1GB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/1GB/standalone/accumulo-site.xml 1bca857
> conf/examples/1GB/standalone/auditLog.xml 9b7987e
> conf/examples/1GB/standalone/gc 63fb8bb
> conf/examples/1GB/standalone/generic_logger.xml 4d2af90
> conf/examples/1GB/standalone/log4j.properties a4bcb2e
> conf/examples/1GB/standalone/masters 63fb8bb
> conf/examples/1GB/standalone/monitor 63fb8bb
> conf/examples/1GB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/1GB/standalone/slaves 63fb8bb
> conf/examples/1GB/standalone/tracers 63fb8bb
> conf/examples/2GB/native-standalone/accumulo-env.sh 5f6d2cb
> conf/examples/2GB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/2GB/native-standalone/accumulo-site.xml 9eaa5ff
> conf/examples/2GB/native-standalone/auditLog.xml 9b7987e
> conf/examples/2GB/native-standalone/gc 63fb8bb
> conf/examples/2GB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/2GB/native-standalone/log4j.properties a4bcb2e
> conf/examples/2GB/native-standalone/masters 63fb8bb
> conf/examples/2GB/native-standalone/monitor 63fb8bb
> conf/examples/2GB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/2GB/native-standalone/slaves 63fb8bb
> conf/examples/2GB/native-standalone/tracers 63fb8bb
> conf/examples/2GB/standalone/accumulo-env.sh feba48c
> conf/examples/2GB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/2GB/standalone/accumulo-site.xml c9e0309
> conf/examples/2GB/standalone/auditLog.xml 9b7987e
> conf/examples/2GB/standalone/gc 63fb8bb
> conf/examples/2GB/standalone/generic_logger.xml 4d2af90
> conf/examples/2GB/standalone/log4j.properties a4bcb2e
> conf/examples/2GB/standalone/masters 63fb8bb
> conf/examples/2GB/standalone/monitor 63fb8bb
> conf/examples/2GB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/2GB/standalone/slaves 63fb8bb
> conf/examples/2GB/standalone/tracers 63fb8bb
> conf/examples/3GB/native-standalone/accumulo-env.sh be72992
> conf/examples/3GB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/3GB/native-standalone/accumulo-site.xml 9b82ed3
> conf/examples/3GB/native-standalone/auditLog.xml 9b7987e
> conf/examples/3GB/native-standalone/gc 63fb8bb
> conf/examples/3GB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/3GB/native-standalone/log4j.properties a4bcb2e
> conf/examples/3GB/native-standalone/masters 63fb8bb
> conf/examples/3GB/native-standalone/monitor 63fb8bb
> conf/examples/3GB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/3GB/native-standalone/slaves 63fb8bb
> conf/examples/3GB/native-standalone/tracers 63fb8bb
> conf/examples/3GB/standalone/accumulo-env.sh 6e5fb3a
> conf/examples/3GB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/3GB/standalone/accumulo-site.xml a127cbd
> conf/examples/3GB/standalone/auditLog.xml 9b7987e
> conf/examples/3GB/standalone/gc 63fb8bb
> conf/examples/3GB/standalone/generic_logger.xml 4d2af90
> conf/examples/3GB/standalone/log4j.properties a4bcb2e
> conf/examples/3GB/standalone/masters 63fb8bb
> conf/examples/3GB/standalone/monitor 63fb8bb
> conf/examples/3GB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/3GB/standalone/slaves 63fb8bb
> conf/examples/3GB/standalone/tracers 63fb8bb
> conf/examples/512MB/native-standalone/accumulo-env.sh e02b524
> conf/examples/512MB/native-standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/512MB/native-standalone/accumulo-site.xml 0e8bdb2
> conf/examples/512MB/native-standalone/auditLog.xml 9b7987e
> conf/examples/512MB/native-standalone/gc 63fb8bb
> conf/examples/512MB/native-standalone/generic_logger.xml 4d2af90
> conf/examples/512MB/native-standalone/log4j.properties a4bcb2e
> conf/examples/512MB/native-standalone/masters 63fb8bb
> conf/examples/512MB/native-standalone/monitor 63fb8bb
> conf/examples/512MB/native-standalone/monitor_logger.xml 3a63bf4
> conf/examples/512MB/native-standalone/slaves 63fb8bb
> conf/examples/512MB/native-standalone/tracers 63fb8bb
> conf/examples/512MB/standalone/accumulo-env.sh 457e1d3
> conf/examples/512MB/standalone/accumulo-metrics.xml 60f9f8d
> conf/examples/512MB/standalone/accumulo-site.xml 1a30ce7
> conf/examples/512MB/standalone/auditLog.xml 9b7987e
> conf/examples/512MB/standalone/gc 63fb8bb
> conf/examples/512MB/standalone/generic_logger.xml 4d2af90
> conf/examples/512MB/standalone/log4j.properties a4bcb2e
> conf/examples/512MB/standalone/masters 63fb8bb
> conf/examples/512MB/standalone/monitor 63fb8bb
> conf/examples/512MB/standalone/monitor_logger.xml 3a63bf4
> conf/examples/512MB/standalone/slaves 63fb8bb
> conf/examples/512MB/standalone/tracers 63fb8bb
> conf/examples/crypto/accumulo-site.xml a7e5c54
> conf/examples/crypto/readme.txt c638b6e
> conf/examples/vfs-classloader/accumulo-site.xml ea95ea2
> conf/templates/accumulo-env.sh PRE-CREATION
> conf/templates/accumulo-metrics.xml PRE-CREATION
> conf/templates/accumulo-site.xml PRE-CREATION
> conf/templates/accumulo.policy.example PRE-CREATION
> conf/templates/gc PRE-CREATION
> conf/templates/generic_logger.xml PRE-CREATION
> conf/templates/log4j.properties PRE-CREATION
> conf/templates/masters PRE-CREATION
> conf/templates/monitor PRE-CREATION
> conf/templates/monitor_logger.xml PRE-CREATION
> conf/templates/slaves PRE-CREATION
> conf/templates/tracers PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18438/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> John McNamee
>
>