You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by Thomas Bennett <lm...@gmail.com> on 2014/06/06 15:16:59 UTC
Review Request 22302: Exception when creating a zipfile of a hierarchical
product
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22302/
-----------------------------------------------------------
Review request for oodt and Chris Mattmann.
Bugs: oodt-703
https://issues.apache.org/jira/browse/oodt-703
Repository: oodt
Description
-------
Skip a data store reference if it is a directory
Unit test will zip a test hierarchical product
Diffs
-----
trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/data/DataUtils.java 1600844
trunk/webapp/fmprod/src/test/java/org/apache/oodt/cas/product/data/TestDataUtils.java PRE-CREATION
trunk/webapp/fmprod/src/testdata/data/test-file-1.txt PRE-CREATION
trunk/webapp/fmprod/src/testdata/data/test-file-2.txt PRE-CREATION
trunk/webapp/fmprod/src/testdata/data/test-file-3.txt PRE-CREATION
Diff: https://reviews.apache.org/r/22302/diff/
Testing
-------
Unit test passes
Thanks,
Thomas Bennett
Re: Review Request 22302: Exception when creating a zipfile of a
hierarchical product
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22302/#review44904
-----------------------------------------------------------
Ship it!
Ship It!
- Chris Mattmann
On June 6, 2014, 1:16 p.m., Thomas Bennett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22302/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 1:16 p.m.)
>
>
> Review request for oodt and Chris Mattmann.
>
>
> Bugs: oodt-703
> https://issues.apache.org/jira/browse/oodt-703
>
>
> Repository: oodt
>
>
> Description
> -------
>
> Skip a data store reference if it is a directory
>
> Unit test will zip a test hierarchical product
>
>
> Diffs
> -----
>
> trunk/webapp/fmprod/src/main/java/org/apache/oodt/cas/product/data/DataUtils.java 1600844
> trunk/webapp/fmprod/src/test/java/org/apache/oodt/cas/product/data/TestDataUtils.java PRE-CREATION
> trunk/webapp/fmprod/src/testdata/data/test-file-1.txt PRE-CREATION
> trunk/webapp/fmprod/src/testdata/data/test-file-2.txt PRE-CREATION
> trunk/webapp/fmprod/src/testdata/data/test-file-3.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22302/diff/
>
>
> Testing
> -------
>
> Unit test passes
>
>
> Thanks,
>
> Thomas Bennett
>
>