You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/05/08 23:22:20 UTC
Review Request 59074: Updated all tests that use
Containerizer::launch(...).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59074/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-7304 and MESOS-7449
https://issues.apache.org/jira/browse/MESOS-7304
https://issues.apache.org/jira/browse/MESOS-7449
Repository: mesos
Description
-------
This sweeps through the unit tests and translates all existing
tests that use the two variants of Containerizer::launch(...)
(i.e. nested and non-nested) and translates the arguments to the
new interface. The fetcher interface changes are also addressed
in this sweep.
Diffs
-----
src/tests/api_tests.cpp faf3242f9c86d866c4bb5e457fcfe47c1063cc09
src/tests/check_tests.cpp ec0d5ee78a94991c68f38174d09b41e8f2e4be35
src/tests/command_executor_tests.cpp da4b653303d436309f6cb190ad6b600b8d934678
src/tests/container_logger_tests.cpp 28436b6b67c1251d877064751e695c6696725a23
src/tests/containerizer/cgroups_isolator_tests.cpp 4e1d027bde7f0ab51e778bfd3bac8797fc7f7f1b
src/tests/containerizer/cni_isolator_tests.cpp 565e58ae75e918453e4386f5e35a5a844a8b15f8
src/tests/containerizer/composing_containerizer_tests.cpp d7fd6216080f2f437503b898bff6b1046317933e
src/tests/containerizer/cpu_isolator_tests.cpp 3c6f7481de2d6d1f6abf9850bd33cea44931480a
src/tests/containerizer/docker_volume_isolator_tests.cpp b47a6b5081a63ac474ac4634701b1a572eb58137
src/tests/containerizer/isolator_tests.cpp 355e15ff69ca6bdd94821f6566fd09a280d03b47
src/tests/containerizer/linux_filesystem_isolator_tests.cpp 70a0dce0f0166fcb3c15a03a89151152954abbac
src/tests/containerizer/memory_isolator_tests.cpp 0df4aa892b531eb305eb3012862ad25527344ab6
src/tests/containerizer/memory_pressure_tests.cpp c4ad779906ee31d07fdd8a6fc0e51e1edd1cbe85
src/tests/containerizer/port_mapping_tests.cpp a528382e8b4831b9c7e8dcc877a5e242909f0cd5
src/tests/containerizer/volume_image_isolator_tests.cpp ad1884459e87ece767e1019adcf702a2f2ff8f1c
src/tests/containerizer/xfs_quota_tests.cpp 7beb60b059910a0d4451b1ace895a35dc974a043
src/tests/disk_quota_tests.cpp f758bee07c448afe09dc380e99c4a81e2dd9f650
src/tests/fetcher_cache_tests.cpp 3bd63ed0a66493829a82c542ad05ebe0f7828d1a
src/tests/fetcher_tests.cpp 27ea7244c713934ef5a721ec133804a006dcb26e
src/tests/health_check_tests.cpp 6c1b9a0ead6edb34c20cf4973fffcff913c5d7ad
src/tests/hook_tests.cpp 02d8f800c3eb9b1e617a14c78c2ef1e45d1c72bb
src/tests/master_tests.cpp ceee2f4a5d38e0f4200f444769e058d2173de821
src/tests/slave_recovery_tests.cpp 52e78b6b6280a159233b402ce2849448204d4f11
src/tests/slave_tests.cpp 8c97dc6d088708d301dc3ccf90d413fd785b782f
Diff: https://reviews.apache.org/r/59074/diff/1/
Testing
-------
make check
Currently fails a few of the fetcher tests, which might need tweaking (these tests assume the fetcher caches things in the current directory):
```
[ FAILED ] FetcherTest.RelativeFilePath
[ FAILED ] FetcherCacheTest.SimpleEviction
[ FAILED ] FetcherCacheTest.FallbackFromEviction
[ FAILED ] FetcherCacheTest.RemoveLRUCacheEntries
```
Thanks,
Joseph Wu
Re: Review Request 59074: Updated all tests that use
Containerizer::launch(...).
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59074/#review175976
-----------------------------------------------------------
Bad patch!
Reviews applied: [59074, 59164, 59073, 58910, 58909, 58908, 58907, 58906, 58905, 58904, 58903, 58902, 59420, 58899, 59419, 58900]
Failed command: python support/apply-reviews.py -n -r 58900
Error:
2017-05-24 19:34:01 URL:https://reviews.apache.org/r/58900/diff/raw/ [15290/15290] -> "58900.patch" [1]
error: patch failed: src/slave/main.cpp:444
error: src/slave/main.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/18169/console
- Mesos Reviewbot
On May 24, 2017, 10:34 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59074/
> -----------------------------------------------------------
>
> (Updated May 24, 2017, 10:34 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-7304 and MESOS-7449
> https://issues.apache.org/jira/browse/MESOS-7304
> https://issues.apache.org/jira/browse/MESOS-7449
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This sweeps through the unit tests and translates all existing
> tests that use the two variants of Containerizer::launch(...)
> (i.e. nested and non-nested) and translates the arguments to the
> new interface. Some of the fetcher interface changes are also
> addressed in this sweep.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp faf3242f9c86d866c4bb5e457fcfe47c1063cc09
> src/tests/check_tests.cpp 68aa29a182504ec85ccae165745246cf727562a1
> src/tests/command_executor_tests.cpp da4b653303d436309f6cb190ad6b600b8d934678
> src/tests/container_logger_tests.cpp 28436b6b67c1251d877064751e695c6696725a23
> src/tests/containerizer/cgroups_isolator_tests.cpp 4e1d027bde7f0ab51e778bfd3bac8797fc7f7f1b
> src/tests/containerizer/cni_isolator_tests.cpp 565e58ae75e918453e4386f5e35a5a844a8b15f8
> src/tests/containerizer/composing_containerizer_tests.cpp d7fd6216080f2f437503b898bff6b1046317933e
> src/tests/containerizer/cpu_isolator_tests.cpp 3c6f7481de2d6d1f6abf9850bd33cea44931480a
> src/tests/containerizer/docker_volume_isolator_tests.cpp b47a6b5081a63ac474ac4634701b1a572eb58137
> src/tests/containerizer/environment_secret_isolator_tests.cpp 619004016832a4cb740c64b1df4121dd62e2cb53
> src/tests/containerizer/isolator_tests.cpp 355e15ff69ca6bdd94821f6566fd09a280d03b47
> src/tests/containerizer/linux_filesystem_isolator_tests.cpp 70a0dce0f0166fcb3c15a03a89151152954abbac
> src/tests/containerizer/memory_isolator_tests.cpp 0df4aa892b531eb305eb3012862ad25527344ab6
> src/tests/containerizer/memory_pressure_tests.cpp c4ad779906ee31d07fdd8a6fc0e51e1edd1cbe85
> src/tests/containerizer/port_mapping_tests.cpp d062f2f6bcf7b44dbcde951cdca23b0a2cd42115
> src/tests/containerizer/volume_image_isolator_tests.cpp ad1884459e87ece767e1019adcf702a2f2ff8f1c
> src/tests/containerizer/volume_secret_isolator_tests.cpp 073c3924366ff6db1c81bb0c59fa63b1e7047c06
> src/tests/containerizer/xfs_quota_tests.cpp b33fe8beb0e4eb5a8675ecc9c46675ce081da660
> src/tests/disk_quota_tests.cpp 9fe2c8639727c61a26907d07fa744d102610f99b
> src/tests/health_check_tests.cpp d45dd8032f3c623de1dfd8c542cfe8200fa16b78
> src/tests/hook_tests.cpp 02d8f800c3eb9b1e617a14c78c2ef1e45d1c72bb
> src/tests/master_tests.cpp 1dfe5fd7c33c3c479175aa522fef1956f11f265c
> src/tests/slave_recovery_tests.cpp 0aa87f534fbc655e3f1aa2ab7f56a1b6be7a8755
> src/tests/slave_tests.cpp d124d594fb4f20db3f5dacbc7482d97161cca2df
>
>
> Diff: https://reviews.apache.org/r/59074/diff/4/
>
>
> Testing
> -------
>
> make check
>
> Currently fails a few of the fetcher tests, which might need tweaking (these tests assume the fetcher caches things in the current directory):
> ```
> [ FAILED ] FetcherTest.RelativeFilePath
> [ FAILED ] FetcherCacheTest.SimpleEviction
> [ FAILED ] FetcherCacheTest.FallbackFromEviction
> [ FAILED ] FetcherCacheTest.RemoveLRUCacheEntries
> ```
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 59074: Updated all tests that use
Containerizer::launch(...).
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59074/
-----------------------------------------------------------
(Updated May 24, 2017, 3:34 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
Rebased and added some more new tests (secrets and XFS isolator).
Bugs: MESOS-7304 and MESOS-7449
https://issues.apache.org/jira/browse/MESOS-7304
https://issues.apache.org/jira/browse/MESOS-7449
Repository: mesos
Description
-------
This sweeps through the unit tests and translates all existing
tests that use the two variants of Containerizer::launch(...)
(i.e. nested and non-nested) and translates the arguments to the
new interface. Some of the fetcher interface changes are also
addressed in this sweep.
Diffs (updated)
-----
src/tests/api_tests.cpp faf3242f9c86d866c4bb5e457fcfe47c1063cc09
src/tests/check_tests.cpp 68aa29a182504ec85ccae165745246cf727562a1
src/tests/command_executor_tests.cpp da4b653303d436309f6cb190ad6b600b8d934678
src/tests/container_logger_tests.cpp 28436b6b67c1251d877064751e695c6696725a23
src/tests/containerizer/cgroups_isolator_tests.cpp 4e1d027bde7f0ab51e778bfd3bac8797fc7f7f1b
src/tests/containerizer/cni_isolator_tests.cpp 565e58ae75e918453e4386f5e35a5a844a8b15f8
src/tests/containerizer/composing_containerizer_tests.cpp d7fd6216080f2f437503b898bff6b1046317933e
src/tests/containerizer/cpu_isolator_tests.cpp 3c6f7481de2d6d1f6abf9850bd33cea44931480a
src/tests/containerizer/docker_volume_isolator_tests.cpp b47a6b5081a63ac474ac4634701b1a572eb58137
src/tests/containerizer/environment_secret_isolator_tests.cpp 619004016832a4cb740c64b1df4121dd62e2cb53
src/tests/containerizer/isolator_tests.cpp 355e15ff69ca6bdd94821f6566fd09a280d03b47
src/tests/containerizer/linux_filesystem_isolator_tests.cpp 70a0dce0f0166fcb3c15a03a89151152954abbac
src/tests/containerizer/memory_isolator_tests.cpp 0df4aa892b531eb305eb3012862ad25527344ab6
src/tests/containerizer/memory_pressure_tests.cpp c4ad779906ee31d07fdd8a6fc0e51e1edd1cbe85
src/tests/containerizer/port_mapping_tests.cpp d062f2f6bcf7b44dbcde951cdca23b0a2cd42115
src/tests/containerizer/volume_image_isolator_tests.cpp ad1884459e87ece767e1019adcf702a2f2ff8f1c
src/tests/containerizer/volume_secret_isolator_tests.cpp 073c3924366ff6db1c81bb0c59fa63b1e7047c06
src/tests/containerizer/xfs_quota_tests.cpp b33fe8beb0e4eb5a8675ecc9c46675ce081da660
src/tests/disk_quota_tests.cpp 9fe2c8639727c61a26907d07fa744d102610f99b
src/tests/health_check_tests.cpp d45dd8032f3c623de1dfd8c542cfe8200fa16b78
src/tests/hook_tests.cpp 02d8f800c3eb9b1e617a14c78c2ef1e45d1c72bb
src/tests/master_tests.cpp 1dfe5fd7c33c3c479175aa522fef1956f11f265c
src/tests/slave_recovery_tests.cpp 0aa87f534fbc655e3f1aa2ab7f56a1b6be7a8755
src/tests/slave_tests.cpp d124d594fb4f20db3f5dacbc7482d97161cca2df
Diff: https://reviews.apache.org/r/59074/diff/4/
Changes: https://reviews.apache.org/r/59074/diff/3-4/
Testing
-------
make check
Currently fails a few of the fetcher tests, which might need tweaking (these tests assume the fetcher caches things in the current directory):
```
[ FAILED ] FetcherTest.RelativeFilePath
[ FAILED ] FetcherCacheTest.SimpleEviction
[ FAILED ] FetcherCacheTest.FallbackFromEviction
[ FAILED ] FetcherCacheTest.RemoveLRUCacheEntries
```
Thanks,
Joseph Wu
Re: Review Request 59074: Updated all tests that use
Containerizer::launch(...).
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59074/#review174666
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/hook_tests.cpp
Lines 303 (patched)
<https://reviews.apache.org/r/59074/#comment247869>
Why you need this?
- Jie Yu
On May 11, 2017, 12:27 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59074/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 12:27 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-7304 and MESOS-7449
> https://issues.apache.org/jira/browse/MESOS-7304
> https://issues.apache.org/jira/browse/MESOS-7449
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This sweeps through the unit tests and translates all existing
> tests that use the two variants of Containerizer::launch(...)
> (i.e. nested and non-nested) and translates the arguments to the
> new interface. Some of the fetcher interface changes are also
> addressed in this sweep.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp faf3242f9c86d866c4bb5e457fcfe47c1063cc09
> src/tests/check_tests.cpp ec0d5ee78a94991c68f38174d09b41e8f2e4be35
> src/tests/command_executor_tests.cpp da4b653303d436309f6cb190ad6b600b8d934678
> src/tests/container_logger_tests.cpp 28436b6b67c1251d877064751e695c6696725a23
> src/tests/containerizer/cgroups_isolator_tests.cpp 4e1d027bde7f0ab51e778bfd3bac8797fc7f7f1b
> src/tests/containerizer/cni_isolator_tests.cpp 565e58ae75e918453e4386f5e35a5a844a8b15f8
> src/tests/containerizer/composing_containerizer_tests.cpp d7fd6216080f2f437503b898bff6b1046317933e
> src/tests/containerizer/cpu_isolator_tests.cpp 3c6f7481de2d6d1f6abf9850bd33cea44931480a
> src/tests/containerizer/docker_volume_isolator_tests.cpp b47a6b5081a63ac474ac4634701b1a572eb58137
> src/tests/containerizer/isolator_tests.cpp 355e15ff69ca6bdd94821f6566fd09a280d03b47
> src/tests/containerizer/linux_filesystem_isolator_tests.cpp 70a0dce0f0166fcb3c15a03a89151152954abbac
> src/tests/containerizer/memory_isolator_tests.cpp 0df4aa892b531eb305eb3012862ad25527344ab6
> src/tests/containerizer/memory_pressure_tests.cpp c4ad779906ee31d07fdd8a6fc0e51e1edd1cbe85
> src/tests/containerizer/port_mapping_tests.cpp a528382e8b4831b9c7e8dcc877a5e242909f0cd5
> src/tests/containerizer/volume_image_isolator_tests.cpp ad1884459e87ece767e1019adcf702a2f2ff8f1c
> src/tests/containerizer/xfs_quota_tests.cpp 7beb60b059910a0d4451b1ace895a35dc974a043
> src/tests/disk_quota_tests.cpp f758bee07c448afe09dc380e99c4a81e2dd9f650
> src/tests/health_check_tests.cpp 6c1b9a0ead6edb34c20cf4973fffcff913c5d7ad
> src/tests/hook_tests.cpp 02d8f800c3eb9b1e617a14c78c2ef1e45d1c72bb
> src/tests/master_tests.cpp ceee2f4a5d38e0f4200f444769e058d2173de821
> src/tests/slave_recovery_tests.cpp 52e78b6b6280a159233b402ce2849448204d4f11
> src/tests/slave_tests.cpp 8c97dc6d088708d301dc3ccf90d413fd785b782f
>
>
> Diff: https://reviews.apache.org/r/59074/diff/2/
>
>
> Testing
> -------
>
> make check
>
> Currently fails a few of the fetcher tests, which might need tweaking (these tests assume the fetcher caches things in the current directory):
> ```
> [ FAILED ] FetcherTest.RelativeFilePath
> [ FAILED ] FetcherCacheTest.SimpleEviction
> [ FAILED ] FetcherCacheTest.FallbackFromEviction
> [ FAILED ] FetcherCacheTest.RemoveLRUCacheEntries
> ```
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 59074: Updated all tests that use
Containerizer::launch(...).
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59074/
-----------------------------------------------------------
(Updated May 10, 2017, 5:27 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Pulled out fetcher test changes, as those have some functional changes that should be called out.
Bugs: MESOS-7304 and MESOS-7449
https://issues.apache.org/jira/browse/MESOS-7304
https://issues.apache.org/jira/browse/MESOS-7449
Repository: mesos
Description (updated)
-------
This sweeps through the unit tests and translates all existing
tests that use the two variants of Containerizer::launch(...)
(i.e. nested and non-nested) and translates the arguments to the
new interface. Some of the fetcher interface changes are also
addressed in this sweep.
Diffs (updated)
-----
src/tests/api_tests.cpp faf3242f9c86d866c4bb5e457fcfe47c1063cc09
src/tests/check_tests.cpp ec0d5ee78a94991c68f38174d09b41e8f2e4be35
src/tests/command_executor_tests.cpp da4b653303d436309f6cb190ad6b600b8d934678
src/tests/container_logger_tests.cpp 28436b6b67c1251d877064751e695c6696725a23
src/tests/containerizer/cgroups_isolator_tests.cpp 4e1d027bde7f0ab51e778bfd3bac8797fc7f7f1b
src/tests/containerizer/cni_isolator_tests.cpp 565e58ae75e918453e4386f5e35a5a844a8b15f8
src/tests/containerizer/composing_containerizer_tests.cpp d7fd6216080f2f437503b898bff6b1046317933e
src/tests/containerizer/cpu_isolator_tests.cpp 3c6f7481de2d6d1f6abf9850bd33cea44931480a
src/tests/containerizer/docker_volume_isolator_tests.cpp b47a6b5081a63ac474ac4634701b1a572eb58137
src/tests/containerizer/isolator_tests.cpp 355e15ff69ca6bdd94821f6566fd09a280d03b47
src/tests/containerizer/linux_filesystem_isolator_tests.cpp 70a0dce0f0166fcb3c15a03a89151152954abbac
src/tests/containerizer/memory_isolator_tests.cpp 0df4aa892b531eb305eb3012862ad25527344ab6
src/tests/containerizer/memory_pressure_tests.cpp c4ad779906ee31d07fdd8a6fc0e51e1edd1cbe85
src/tests/containerizer/port_mapping_tests.cpp a528382e8b4831b9c7e8dcc877a5e242909f0cd5
src/tests/containerizer/volume_image_isolator_tests.cpp ad1884459e87ece767e1019adcf702a2f2ff8f1c
src/tests/containerizer/xfs_quota_tests.cpp 7beb60b059910a0d4451b1ace895a35dc974a043
src/tests/disk_quota_tests.cpp f758bee07c448afe09dc380e99c4a81e2dd9f650
src/tests/health_check_tests.cpp 6c1b9a0ead6edb34c20cf4973fffcff913c5d7ad
src/tests/hook_tests.cpp 02d8f800c3eb9b1e617a14c78c2ef1e45d1c72bb
src/tests/master_tests.cpp ceee2f4a5d38e0f4200f444769e058d2173de821
src/tests/slave_recovery_tests.cpp 52e78b6b6280a159233b402ce2849448204d4f11
src/tests/slave_tests.cpp 8c97dc6d088708d301dc3ccf90d413fd785b782f
Diff: https://reviews.apache.org/r/59074/diff/2/
Changes: https://reviews.apache.org/r/59074/diff/1-2/
Testing
-------
make check
Currently fails a few of the fetcher tests, which might need tweaking (these tests assume the fetcher caches things in the current directory):
```
[ FAILED ] FetcherTest.RelativeFilePath
[ FAILED ] FetcherCacheTest.SimpleEviction
[ FAILED ] FetcherCacheTest.FallbackFromEviction
[ FAILED ] FetcherCacheTest.RemoveLRUCacheEntries
```
Thanks,
Joseph Wu