[jira] [Commented] (LUCENE-10561) Reduce member visibility of ArabicStemmer, ArabicNormalizer, and PersianNormalizer

["Robert Muir (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17533306#comment-17533306 ] 

Robert Muir commented on LUCENE-10561:
--------------------------------------

you can just make the entire classes package private. there are probably a ton of stemmer classes in the same situation. only the tokenstream(factory) need be public.

> Reduce member visibility of ArabicStemmer, ArabicNormalizer, and PersianNormalizer
> ----------------------------------------------------------------------------------
>
>                 Key: LUCENE-10561
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10561
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Tomoko Uchida
>            Priority: Minor
>
> This is a spin-off of [LUCENE-10312].
> Constants and methods in those classes are exposed to the outside packages; we should be able to limit the visibility to {{private}} or, at least to {{package private}}.
> This change breaks backward compatibility so should be applied to the main branch (10.0) only, and a MIGRATE entry may be needed.
> Also, they seem unchanged since 2008, we could refactor them to embrace newer Java APIs as we did in [https://github.com/apache/lucene/pull/540]. 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org