You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/05/04 16:16:18 UTC

[GitHub] [geode] onichols-pivotal commented on a change in pull request #6427: GEODE-8191: update flaky test

onichols-pivotal commented on a change in pull request #6427:
URL: https://github.com/apache/geode/pull/6427#discussion_r625919458



##########
File path: geode-core/src/distributedTest/java/org/apache/geode/management/MemberMXBeanDistributedTest.java
##########
@@ -90,27 +90,26 @@ public void testBucketCount() {
       assertThat(sumOfBuckets).isEqualTo(1000);
     });
 
-    for (int i = 1; i < 4; i++) {
-      final String tempRegioName = regionName + i;
+    final int i = 1;
+    final String tempRegioName = regionName + i;
 
-      gfsh.executeAndAssertThat("create region"
-          + " --name=" + tempRegioName
-          + " --type=PARTITION_PERSISTENT"
-          + " --total-num-buckets=1000"
-          + " --colocated-with=" + regionName).statusIsSuccess();
+    gfsh.executeAndAssertThat("create region"
+        + " --name=" + tempRegioName
+        + " --type=PARTITION_PERSISTENT"
+        + " --total-num-buckets=1000"
+        + " --colocated-with=" + regionName).statusIsSuccess();
 
-      server1.invoke(() -> createBuckets(tempRegioName));
-      server2.invoke(() -> createBuckets(tempRegioName));
-      server3.invoke(() -> createBuckets(tempRegioName));
-      server4.invoke(() -> createBuckets(tempRegioName));
-    }
+    server1.invoke(() -> createBuckets(tempRegioName));
+    server2.invoke(() -> createBuckets(tempRegioName));
+    server3.invoke(() -> createBuckets(tempRegioName));
+    server4.invoke(() -> createBuckets(tempRegioName));
 
     await().untilAsserted(() -> {
       final int sumOfBuckets = server1.invoke(() -> getBucketsInitialized()) +
           server2.invoke(() -> getBucketsInitialized()) +
           server3.invoke(() -> getBucketsInitialized()) +
           server4.invoke(() -> getBucketsInitialized());
-      assertThat(sumOfBuckets).isEqualTo(4000);
+      assertThat(sumOfBuckets).isEqualTo(2000);

Review comment:
       I can answer the first half of that...the latest [mass test run](https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-mass-test-run/jobs/create-mass-test-run-report/builds/13#L60659893:162) identified this test as 1% flaky.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org