You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Bruno Peeters (JIRA)" <ji...@apache.org> on 2009/02/02 16:09:59 UTC
[jira] Created: (JSPWIKI-481) Wrong redirect from Search page
Wrong redirect from Search page
-------------------------------
Key: JSPWIKI-481
URL: https://issues.apache.org/jira/browse/JSPWIKI-481
Project: JSPWiki
Issue Type: Bug
Affects Versions: 2.8.1
Reporter: Bruno Peeters
Priority: Minor
If a user decides to go to UserPrefernces page from the search page, a wrong redirect parameter is put in the URL : http://xxx/UserPreferences.jsp?redirect=Search
After saving the preferences, the user is taken to a page "Search" resulting in an error message "This page does not exist. Why don't you go and create it? "
This is probably linked to a previously reported issue : https://issues.apache.org/jira/browse/JSPWIKI-383
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-481) Wrong redirect from Search page
Posted by "Dirk Frederickx (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dirk Frederickx updated JSPWIKI-481:
------------------------------------
Comment: was deleted
(was:
Fixed scroll issues with css overflow on Safari and IE. Hopefully also fixes the FF issues, which I couldn't reproduce.
Plse confirm on FF.
dirk)
> Wrong redirect from Search page
> -------------------------------
>
> Key: JSPWIKI-481
> URL: https://issues.apache.org/jira/browse/JSPWIKI-481
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Priority: Minor
> Fix For: 2.8.3, 3.0
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> If a user decides to go to UserPrefernces page from the search page, a wrong redirect parameter is put in the URL : http://xxx/UserPreferences.jsp?redirect=Search
> After saving the preferences, the user is taken to a page "Search" resulting in an error message "This page does not exist. Why don't you go and create it? "
> This is probably linked to a previously reported issue : https://issues.apache.org/jira/browse/JSPWIKI-383
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-481) Wrong redirect from Search page
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Janne Jalkanen updated JSPWIKI-481:
-----------------------------------
Fix Version/s: (was: 2.8.2)
2.8.3
Bumping to 2.8.3.
> Wrong redirect from Search page
> -------------------------------
>
> Key: JSPWIKI-481
> URL: https://issues.apache.org/jira/browse/JSPWIKI-481
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Priority: Minor
> Fix For: 2.8.3, 3.0
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> If a user decides to go to UserPrefernces page from the search page, a wrong redirect parameter is put in the URL : http://xxx/UserPreferences.jsp?redirect=Search
> After saving the preferences, the user is taken to a page "Search" resulting in an error message "This page does not exist. Why don't you go and create it? "
> This is probably linked to a previously reported issue : https://issues.apache.org/jira/browse/JSPWIKI-383
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-481) Wrong redirect from Search page
Posted by "Dirk Frederickx (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693456#action_12693456 ]
Dirk Frederickx commented on JSPWIKI-481:
-----------------------------------------
The reason the redirect doesn't work is because there is no "Special Page Reference" in the jspwiki.properties for the search page.
Strange enough, there is a special reference for "FindPage".
I changed the jspwiki.properties like this:
Old:
{noformat}
jspwiki.specialPage.CreateGroup = NewGroup.jsp
jspwiki.specialPage.FindPage = Search.jsp
jspwiki.specialPage.Login = Login.jsp
jspwiki.specialPage.NewGroup = NewGroup.jsp
jspwiki.specialPage.UserPreferences = UserPreferences.jsp
{noformat}
New:
{noformat}
jspwiki.specialPage.CreateGroup = NewGroup.jsp
#jspwiki.specialPage.FindPage = Search.jsp
jspwiki.specialPage.Search = Search.jsp
jspwiki.specialPage.Login = Login.jsp
jspwiki.specialPage.NewGroup = NewGroup.jsp
jspwiki.specialPage.UserPreferences = UserPreferences.jsp
jspwiki.specialPage.Workflow = Workflow.jsp
{noformat}
This resolves also [JSPWIKI-383].
Of course, with this change, *real* pages named "Workflow" or "Search" would be redirected wrongly.
WDYT ?
dirk
> Wrong redirect from Search page
> -------------------------------
>
> Key: JSPWIKI-481
> URL: https://issues.apache.org/jira/browse/JSPWIKI-481
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Priority: Minor
> Fix For: 2.8.3, 3.0
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> If a user decides to go to UserPrefernces page from the search page, a wrong redirect parameter is put in the URL : http://xxx/UserPreferences.jsp?redirect=Search
> After saving the preferences, the user is taken to a page "Search" resulting in an error message "This page does not exist. Why don't you go and create it? "
> This is probably linked to a previously reported issue : https://issues.apache.org/jira/browse/JSPWIKI-383
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-481) Wrong redirect from Search page
Posted by "Dirk Frederickx (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dirk Frederickx updated JSPWIKI-481:
------------------------------------
Affects Version/s: 3.0
> Wrong redirect from Search page
> -------------------------------
>
> Key: JSPWIKI-481
> URL: https://issues.apache.org/jira/browse/JSPWIKI-481
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1, 3.0
> Reporter: Bruno Peeters
> Priority: Minor
> Fix For: 2.8.3
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> If a user decides to go to UserPrefernces page from the search page, a wrong redirect parameter is put in the URL : http://xxx/UserPreferences.jsp?redirect=Search
> After saving the preferences, the user is taken to a page "Search" resulting in an error message "This page does not exist. Why don't you go and create it? "
> This is probably linked to a previously reported issue : https://issues.apache.org/jira/browse/JSPWIKI-383
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JSPWIKI-481) Wrong redirect from Search page
Posted by "Dirk Frederickx (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dirk Frederickx resolved JSPWIKI-481.
-------------------------------------
Resolution: Fixed
Fix Version/s: (was: 3.0)
Suggest to close for v2.8.3.
dirk
> Wrong redirect from Search page
> -------------------------------
>
> Key: JSPWIKI-481
> URL: https://issues.apache.org/jira/browse/JSPWIKI-481
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Priority: Minor
> Fix For: 2.8.3
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> If a user decides to go to UserPrefernces page from the search page, a wrong redirect parameter is put in the URL : http://xxx/UserPreferences.jsp?redirect=Search
> After saving the preferences, the user is taken to a page "Search" resulting in an error message "This page does not exist. Why don't you go and create it? "
> This is probably linked to a previously reported issue : https://issues.apache.org/jira/browse/JSPWIKI-383
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-481) Wrong redirect from Search page
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746726#action_12746726 ]
Harry Metske commented on JSPWIKI-481:
--------------------------------------
You cannot vote or change your vote on resolved issues.
> Wrong redirect from Search page
> -------------------------------
>
> Key: JSPWIKI-481
> URL: https://issues.apache.org/jira/browse/JSPWIKI-481
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1, 3.0
> Reporter: Bruno Peeters
> Priority: Minor
> Fix For: 2.8.3
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> If a user decides to go to UserPrefernces page from the search page, a wrong redirect parameter is put in the URL : http://xxx/UserPreferences.jsp?redirect=Search
> After saving the preferences, the user is taken to a page "Search" resulting in an error message "This page does not exist. Why don't you go and create it? "
> This is probably linked to a previously reported issue : https://issues.apache.org/jira/browse/JSPWIKI-383
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-481) Wrong redirect from Search page
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688052#action_12688052 ]
Janne Jalkanen commented on JSPWIKI-481:
----------------------------------------
Any opinions? Keep for 2.8.2 or bump to 2.8.3?
> Wrong redirect from Search page
> -------------------------------
>
> Key: JSPWIKI-481
> URL: https://issues.apache.org/jira/browse/JSPWIKI-481
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Priority: Minor
> Fix For: 2.8.2, 3.0
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> If a user decides to go to UserPrefernces page from the search page, a wrong redirect parameter is put in the URL : http://xxx/UserPreferences.jsp?redirect=Search
> After saving the preferences, the user is taken to a page "Search" resulting in an error message "This page does not exist. Why don't you go and create it? "
> This is probably linked to a previously reported issue : https://issues.apache.org/jira/browse/JSPWIKI-383
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-481) Wrong redirect from Search page
Posted by "Dirk Frederickx (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744926#action_12744926 ]
Dirk Frederickx commented on JSPWIKI-481:
-----------------------------------------
Fixed redirects to special pages both in v2.8.3 and v3.0.0.
dirk
> Wrong redirect from Search page
> -------------------------------
>
> Key: JSPWIKI-481
> URL: https://issues.apache.org/jira/browse/JSPWIKI-481
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Priority: Minor
> Fix For: 2.8.3, 3.0
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> If a user decides to go to UserPrefernces page from the search page, a wrong redirect parameter is put in the URL : http://xxx/UserPreferences.jsp?redirect=Search
> After saving the preferences, the user is taken to a page "Search" resulting in an error message "This page does not exist. Why don't you go and create it? "
> This is probably linked to a previously reported issue : https://issues.apache.org/jira/browse/JSPWIKI-383
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-481) Wrong redirect from Search page
Posted by "Dirk Frederickx (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746656#action_12746656 ]
Dirk Frederickx commented on JSPWIKI-481:
-----------------------------------------
Florian,
I don't see any issue in having the "FindPage" still referenced in a (very) few places.
When used, it will be properly redirected to the Search.jsp.
Anyway, a quick grep didn't show much references to this "FindPage", except from some in the "/wikipages".
So here is a good 'voting' candidate :D : shall we keep "FindPage" or do we remove it as reserved special-page in v3.xx ?
dirk
> Wrong redirect from Search page
> -------------------------------
>
> Key: JSPWIKI-481
> URL: https://issues.apache.org/jira/browse/JSPWIKI-481
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Priority: Minor
> Fix For: 2.8.3, 3.0
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> If a user decides to go to UserPrefernces page from the search page, a wrong redirect parameter is put in the URL : http://xxx/UserPreferences.jsp?redirect=Search
> After saving the preferences, the user is taken to a page "Search" resulting in an error message "This page does not exist. Why don't you go and create it? "
> This is probably linked to a previously reported issue : https://issues.apache.org/jira/browse/JSPWIKI-383
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JSPWIKI-481) Wrong redirect from Search page
Posted by "Dirk Frederickx (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dirk Frederickx resolved JSPWIKI-481.
-------------------------------------
Resolution: Fixed
Fixed scroll issues with css overflow on Safari and IE. Hopefully also fixes the FF issues, which I couldn't reproduce.
Plse confirm on FF.
dirk
> Wrong redirect from Search page
> -------------------------------
>
> Key: JSPWIKI-481
> URL: https://issues.apache.org/jira/browse/JSPWIKI-481
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Priority: Minor
> Fix For: 2.8.3, 3.0
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> If a user decides to go to UserPrefernces page from the search page, a wrong redirect parameter is put in the URL : http://xxx/UserPreferences.jsp?redirect=Search
> After saving the preferences, the user is taken to a page "Search" resulting in an error message "This page does not exist. Why don't you go and create it? "
> This is probably linked to a previously reported issue : https://issues.apache.org/jira/browse/JSPWIKI-383
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-481) Wrong redirect from Search page
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Janne Jalkanen updated JSPWIKI-481:
-----------------------------------
Fix Version/s: 3.0
2.8.2
Remaining Estimate: 0h
Original Estimate: 0h
Marking for 3.0 & 2.8.2. Probably needs different fixes (and yeah, is probably connected to JSPWIKI-383).
> Wrong redirect from Search page
> -------------------------------
>
> Key: JSPWIKI-481
> URL: https://issues.apache.org/jira/browse/JSPWIKI-481
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Priority: Minor
> Fix For: 2.8.2, 3.0
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> If a user decides to go to UserPrefernces page from the search page, a wrong redirect parameter is put in the URL : http://xxx/UserPreferences.jsp?redirect=Search
> After saving the preferences, the user is taken to a page "Search" resulting in an error message "This page does not exist. Why don't you go and create it? "
> This is probably linked to a previously reported issue : https://issues.apache.org/jira/browse/JSPWIKI-383
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (JSPWIKI-481) Wrong redirect from Search page
Posted by "Florian Holeczek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Florian Holeczek reopened JSPWIKI-481:
--------------------------------------
Hi Dirk,
the problem with your current solution is that there are several references to "FindPage" throughout the code and wiki pages. So I think the following points remain to do:
* decide how the page should be called in future: Search or FindPage
* apply the decision to the trunk
* due to compatibility reasons, support both names in the 2.8 branch
regards
Florian
> Wrong redirect from Search page
> -------------------------------
>
> Key: JSPWIKI-481
> URL: https://issues.apache.org/jira/browse/JSPWIKI-481
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Priority: Minor
> Fix For: 2.8.3, 3.0
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> If a user decides to go to UserPrefernces page from the search page, a wrong redirect parameter is put in the URL : http://xxx/UserPreferences.jsp?redirect=Search
> After saving the preferences, the user is taken to a page "Search" resulting in an error message "This page does not exist. Why don't you go and create it? "
> This is probably linked to a previously reported issue : https://issues.apache.org/jira/browse/JSPWIKI-383
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.