You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/11/07 21:51:45 UTC
[kudu-CR](branch-1.10.x) docs: recommend memkind for NVM cache users
Hello Kudu Jenkins, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14658
to review the following change.
Change subject: docs: recommend memkind for NVM cache users
......................................................................
docs: recommend memkind for NVM cache users
I intentionally omitted transitive dependencies; I assume that the memkind
package metadata properly expresses its own dependencies.
Change-Id: Ic87273ba2f051a0adad619138fc7fff92014c3e2
Reviewed-on: http://gerrit.cloudera.org:8080/14649
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit 6c646937b1fe1f4ab0aeb9ed638f00c5dd39257c)
---
M docs/installation.adoc
1 file changed, 21 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/14658/1
--
To view, visit http://gerrit.cloudera.org:8080/14658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic87273ba2f051a0adad619138fc7fff92014c3e2
Gerrit-Change-Number: 14658
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.10.x) docs: recommend memkind for NVM cache users
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14658 )
Change subject: docs: recommend memkind for NVM cache users
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic87273ba2f051a0adad619138fc7fff92014c3e2
Gerrit-Change-Number: 14658
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 08 Nov 2019 08:08:23 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.10.x) docs: recommend memkind for NVM cache users
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14658 )
Change subject: docs: recommend memkind for NVM cache users
......................................................................
Patch Set 1:
Unrelated test failure:
* ToolTest.TestHmsIgnoresDifferentMasters
--
To view, visit http://gerrit.cloudera.org:8080/14658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic87273ba2f051a0adad619138fc7fff92014c3e2
Gerrit-Change-Number: 14658
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 08 Nov 2019 08:08:10 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.10.x) docs: recommend memkind for NVM cache users
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14658 )
Change subject: docs: recommend memkind for NVM cache users
......................................................................
Patch Set 1:
> Do we actually need this backport? I thought we always publish the
> docs from master rather than release branches.
Indeed. We can omit this w.r.t. presence of online documentation. However, I thought it might be a good idea have this for the source release.
--
To view, visit http://gerrit.cloudera.org:8080/14658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic87273ba2f051a0adad619138fc7fff92014c3e2
Gerrit-Change-Number: 14658
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 08 Nov 2019 08:07:08 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.10.x) docs: recommend memkind for NVM cache users
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14658 )
Change subject: docs: recommend memkind for NVM cache users
......................................................................
Patch Set 1: Code-Review+2
Do we actually need this backport? I thought we always publish the docs from master rather than release branches.
--
To view, visit http://gerrit.cloudera.org:8080/14658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic87273ba2f051a0adad619138fc7fff92014c3e2
Gerrit-Change-Number: 14658
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 07 Nov 2019 22:25:17 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.10.x) docs: recommend memkind for NVM cache users
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14658 )
Change subject: docs: recommend memkind for NVM cache users
......................................................................
Patch Set 1: Code-Review+2
I guess we might publish from 1.11.x for the 1.11.1 release?
--
To view, visit http://gerrit.cloudera.org:8080/14658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic87273ba2f051a0adad619138fc7fff92014c3e2
Gerrit-Change-Number: 14658
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 07 Nov 2019 22:33:17 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.10.x) docs: recommend memkind for NVM cache users
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14658 )
Change subject: docs: recommend memkind for NVM cache users
......................................................................
Patch Set 1:
> I guess we might publish from 1.11.x for the 1.11.1 release?
I thought it might be a good idea have this for the source release.
--
To view, visit http://gerrit.cloudera.org:8080/14658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic87273ba2f051a0adad619138fc7fff92014c3e2
Gerrit-Change-Number: 14658
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 08 Nov 2019 08:07:30 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.10.x) docs: recommend memkind for NVM cache users
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: docs: recommend memkind for NVM cache users
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic87273ba2f051a0adad619138fc7fff92014c3e2
Gerrit-Change-Number: 14658
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.10.x) docs: recommend memkind for NVM cache users
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14658 )
Change subject: docs: recommend memkind for NVM cache users
......................................................................
docs: recommend memkind for NVM cache users
I intentionally omitted transitive dependencies; I assume that the memkind
package metadata properly expresses its own dependencies.
Change-Id: Ic87273ba2f051a0adad619138fc7fff92014c3e2
Reviewed-on: http://gerrit.cloudera.org:8080/14649
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit 6c646937b1fe1f4ab0aeb9ed638f00c5dd39257c)
Reviewed-on: http://gerrit.cloudera.org:8080/14658
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M docs/installation.adoc
1 file changed, 21 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Grant Henke: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic87273ba2f051a0adad619138fc7fff92014c3e2
Gerrit-Change-Number: 14658
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)