[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2083: IGNITE-19381 TimestampAware messages sometimes lacks timestamps

["korlov42 (via GitHub)" <gi...@apache.org>]

korlov42 commented on code in PR #2083:
URL: https://github.com/apache/ignite-3/pull/2083#discussion_r1198584017


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/SortedIndexLocker.java:
##########
@@ -188,14 +154,9 @@ public CompletableFuture<Lock> locksForInsert(UUID txId, BinaryRow tableRow, Row
         // Find next key.
         Cursor<IndexRow> cursor = storage.scan(prefix, null, SortedIndexStorage.GREATER);

Review Comment:
   good catch!



##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/SortedIndexLocker.java:
##########
@@ -45,18 +40,8 @@
  * <p>Simply acquires lock on a given row for lookup and remove, acquires lock on a next key for insert.
  */
 public class SortedIndexLocker implements IndexLocker {
-
-    private static final SchemaDescriptor INFINITY_TUPLE_SCHEMA = new SchemaDescriptor(
-            1,
-            new Column[]{
-                    new Column("indexId", NativeTypes.UUID, false),
-                    new Column("partId", NativeTypes.INT32, false)
-            },
-            new Column[0]
-    );
-
     /** Index INF+ value object. */
-    private final BinaryTuple positiveInf;
+    private final Integer positiveInf;

Review Comment:
   +1 for custom wrapper 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org