You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/01 15:01:27 UTC

[GitHub] [flink] Myasuka commented on a diff in pull request #19789: [FLINK-27734][web] Fix checkpoint interval in WebUI

Myasuka commented on code in PR #19789:
URL: https://github.com/apache/flink/pull/19789#discussion_r886914800


##########
flink-runtime-web/web-dashboard/.eslintrc.js:
##########
@@ -126,7 +126,9 @@ module.exports = {
     {
       files: ['*.html'],
       extends: ['plugin:@angular-eslint/template/recommended'],
-      rules: {}
+      rules: {
+        '@angular-eslint/template/eqeqeq': 'off'

Review Comment:
   I see there existing other places to use `===` in the web code, can we make the rule as `warn` instead of `off` as [doc](https://cn.eslint.org/docs/user-guide/configuring#configuring-rules) said.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org