[jira] Resolved: (SM-1633) servicemix-validation throws JBIException instead of FaultException

["Lars Heinemann (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/activemq/browse/SM-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Heinemann resolved SM-1633.
--------------------------------

    Fix Version/s: servicemix-validation-2008.02
       Resolution: Fixed

Fixed in Revision 704819

The org.apache.servicemix.jbi.exception.FaultException of the servicemix-utils is now used instead.

Thanks for pointing out this issue, Ron.




> servicemix-validation throws JBIException instead of FaultException
> -------------------------------------------------------------------
>
>                 Key: SM-1633
>                 URL: https://issues.apache.org/activemq/browse/SM-1633
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-validation
>    Affects Versions: servicemix-validation-2008.01
>            Reporter: Ron Gavlin
>            Assignee: Lars Heinemann
>             Fix For: servicemix-validation-2008.02
>
>
> The old lightweight validation component used to throw a org.apache.servicemix.jbi.FaultException in the following code snippet:
>                 if (!handlingErrorMethod.equalsIgnoreCase(FAULT_FLOW)) {
>                 // HANDLE AS JBI FAULT
>                 throw new FaultException("Failed to validate against schema: " + schema, exchange, fault);
>                 } else {
>                 MessageUtil.transfer(fault, out);
>                 return true;
>                 }
> In the new servicemix-validation component, a JBIException is thrown instead of a FaultException. The relevant code snippet follows:
>                 if (!handlingErrorMethod.equalsIgnoreCase(FAULT_FLOW)) {
>                     // HANDLE AS JBI FAULT
>                     throw new JBIException(
>                             "Failed to validate against schema: " + schema + "\n" + new SourceTransformer().toString(fault.getContent()));
>                 } else {
>                     MessageUtil.transfer(fault, out);
>                 }
> The new servicemix-validation component does not seem correct to me. It should throw a FaultException rather than a JBIException. I would suggest a unit test be written to verify this behavior.
> Ron 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.