You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Vampire (via GitHub)" <gi...@apache.org> on 2024/08/14 16:54:23 UTC
[PR] Do not try to load log factory on TCCL without commons-logging (#192) [commons-logging]
Vampire opened a new pull request, #280:
URL: https://github.com/apache/commons-logging/pull/280
Fixes LOGGING-192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not try to load log factory on TCCL without commons-logging (#192) [commons-logging]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #280:
URL: https://github.com/apache/commons-logging/pull/280#issuecomment-2289712257
Hello @Vampire
Thank you for your update.
Still build failures. You should probably test locally before pushing to avoid looping on build approvals. That would be quicker IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not try to load log factory on TCCL without commons-logging (#192) [commons-logging]
Posted by "Vampire (via GitHub)" <gi...@apache.org>.
Vampire commented on PR #280:
URL: https://github.com/apache/commons-logging/pull/280#issuecomment-2290860699
As the other PR contains the change I did here semantically, I think the changes are fine and should solve the problem.
I have a slight improvement to suggest and a logging that also previously was wrong.
See the updated changes here. :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not try to load log factory on TCCL without commons-logging (#192) [commons-logging]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #280:
URL: https://github.com/apache/commons-logging/pull/280#issuecomment-2289565817
Hello @Vampire,
Thank you for your PR.
Builds are failing.
Please rebase on master to pick up the GH CO Java 22 and experimental Java 23-ea builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not try to load log factory on TCCL without commons-logging (#192) [commons-logging]
Posted by "Vampire (via GitHub)" <gi...@apache.org>.
Vampire commented on PR #280:
URL: https://github.com/apache/commons-logging/pull/280#issuecomment-2289764149
Definitely.
And before I first sent the PR, I did `mvn verify` which succeeded without problems.
I'm not a newbie in the FOSS world, you know? ;-)
I now also did the `mvn` that i just now have seen in the readme.
But also that succeeds without problems.
So it is a bit harsh to just assume I send untested changes, even if it occasionally happens. ;-)
I can hardly guess that it is not failing just because of the Java version and that I should try with other Java versions,
especially as you said "there was an upstream problem, please rebase and push again", making me assume it was not my fault that the build errored out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not try to load log factory on TCCL without commons-logging (#192) [commons-logging]
Posted by "Vampire (via GitHub)" <gi...@apache.org>.
Vampire commented on PR #280:
URL: https://github.com/apache/commons-logging/pull/280#issuecomment-2289573271
Done, please re-approve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not try to load log factory on TCCL without commons-logging (#192) [commons-logging]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #280:
URL: https://github.com/apache/commons-logging/pull/280#issuecomment-2289938258
The test that is failing uses a restrictive `SecurityManager`, so:
- `baseClassLoader` becomes `null` (retrieving the TCCL is not allowed)
- `isClassAvailable` fails, since calling `Class.forName` with a `null` classloader requires additional privileges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not try to load log factory on TCCL without commons-logging (#192) [commons-logging]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #280:
URL: https://github.com/apache/commons-logging/pull/280#issuecomment-2290082516
PR #281 is now merged and the snapshot build is refreshed in https://repository.apache.org/content/repositories/snapshots/
Are OK to close this issue?
(Note that git master now disables certain tests on Java 21 and up since trying to set a security manager throws an exception.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize log factory detection (#192) [commons-logging]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #280:
URL: https://github.com/apache/commons-logging/pull/280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org