You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2022/02/07 17:15:41 UTC

[GitHub] [parquet-mr] prakharjain09 commented on a change in pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

prakharjain09 commented on a change in pull request #945:
URL: https://github.com/apache/parquet-mr/pull/945#discussion_r800879793



##########
File path: parquet-column/src/main/java/org/apache/parquet/column/page/PageReadStore.java
##########
@@ -43,6 +43,14 @@
    */
   long getRowCount();
 
+  /**
+   *
+   * @return the row index offset of this row group.
+   */
+  default Optional<Long> getRowIndexOffset() {

Review comment:
       @shangxinli I added this new method in the interface. This leads to build issues from japicmp-maven-plugin - METHOD_ADDED_TO_INTERFACE.
   
   I provided a default value for this method and this seems to solve the issue. Please provide your feedback on this approach/any alternate approach?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org